Commit 4d24a70
authored
Fix sleep between retries of startRecordingScreen (#603)
<!-- Please provide brief information about the PR, what it contains &
its purpose, new behaviors after the change. And let us know here if you
need any help: https://github.com/microsoft/HydraLab/issues/new -->
## Description
A minor fix for the sleep time between `startRecordingScreen`. The
`retryAndSleepWhenFalse` takes sleepSeconds param and it's set to 1000
second (probably a mistake). I changed the value to 10 second (align
with the other usages of this method).
## Pull Request Checklist
<!-- Put an x in the boxes that apply. This is simply a reminder of what
we are going to look for before merging your code. -->
- [ ] Tests for the changes have been added (for bug fixes / features)
- [x] Code compiles correctly with all tests are passed.
- [x] I've read the [contributing
guide](https://github.com/microsoft/HydraLab/blob/main/CONTRIBUTING.md#making-changes-to-the-code)
and followed the recommended practices.
- [ ] [Wikis](https://github.com/microsoft/HydraLab/wiki) or
[README](https://github.com/microsoft/HydraLab/blob/main/README.md) have
been reviewed and added / updated if needed (for bug fixes / features)
### Does this introduce a breaking change?
- [ ] Yes
- [x] No
## How you tested it
I encounter an issue running test on a mac machine. If appium failed to
start the recording the `retryAndSleepWhenFalse` enter a very long sleep
of 1000 seconds which block the test. Changing the value to 10 second
(align with the other usages of this method) did fix the issue.
Please check the type of change your PR introduces:
- [x] Bugfix
- [ ] Feature
- [ ] Technical design
- [ ] Build related changes
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Code style update (formatting, renaming) or Documentation content
changes
- [ ] Other (please describe):1 parent 11ab915 commit 4d24a70
File tree
1 file changed
+1
-1
lines changed- common/src/main/java/com/microsoft/hydralab/common/screen
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
0 commit comments