sanitize more config logs #990
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security by sanitizing configuration data before logging to prevent sensitive information exposure.
- Wrapped raw JSON inputs with
sanitize_configin logging calls. - Updated warning and info messages to use sanitized output.
- Follow-up adjustments from PR #988 to cover additional logging points.
Comments suppressed due to low confidence (3)
mlos_bench/services/config_persistence.py:197
- The exception message in the
raise ValueErrorstill uses the rawjsonand may expose sensitive data. Usesanitize_config(json)in the formatted message to ensure consistency and prevent leakage.
_LOG.error("Failed to parse config from JSON string: %s", sanitize_config(json))
mlos_bench/services/config_persistence.py:703
- [nitpick] Logging the entire
jsonslist may generate very large logs and impact readability. Consider logging a summary (e.g., count of services) or truncating long entries after sanitization.
_LOG.info("Load services: %s parent: %s", sanitize_config(jsons), parent.__class__.__name__)
mlos_bench/services/config_persistence.py:738
- [nitpick] The variable name
jsonsis ambiguous and could be confused with the JSON module. Consider renaming it toconfigsortunable_payloadsfor clarity.
def load_tunables(...):
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bpkroth
commented
Jun 13, 2025
bpkroth
commented
Jun 13, 2025
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Sanitize more config logging.
Description
Follow ups to #988
Type of Change
Testing
CI