Skip to content

Commit 352f86c

Browse files
authored
RunVSTest: Avoid parsing UT console output looking for errors or warnings (#630)
1 parent 75c91cb commit 352f86c

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/RunTests/RunVSTestTask.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,11 @@ protected override string GenerateFullPathToTool()
153153
/// <inheritdoc/>
154154
protected override void LogEventsFromTextOutput(string singleLine, MessageImportance messageImportance)
155155
{
156-
base.LogEventsFromTextOutput(singleLine, messageImportance);
156+
// Emit all log messages as regular log messages. The base class calls Log.LogMessageFromText which will
157+
// parses the message see if there are strings which "look like" errors or warnings and log them as such.
158+
// Since tests can log messages that look like errors or warnings, we want to avoid that and instead
159+
// completely rely on the exit code of vstest to determine if the task succeeded or not.
160+
Log.LogMessage(messageImportance, singleLine);
157161
}
158162

159163
/// <inheritdoc/>

0 commit comments

Comments
 (0)