Fix crash when we have no Perfetto CPU sampling stack (#62)

* Fix crash when we have no CPU sampling stack
* Fix some warnings due to upcoming API deprecations in 1.0 Toolkit SDK

Author: ivberg

LTTngDataExtensions/SourceDataCookers/Diagnostic Messages/DmesgDataCooker.cs

@@ -16,7 +16,6 @@ public class LTTngDmesgDataCooker
         : LTTngBaseSourceCooker
     {
         public const string Identifier = "DmesgDataCooker";
-        public const string CookerPath = LTTngConstants.SourceId + "/" + Identifier;
 
         public LTTngDmesgDataCooker()
             : base(Identifier)

LTTngDataExtensions/SourceDataCookers/Disk/LTTngDiskDataCooker.cs

@@ -32,7 +32,6 @@ public FileDescriptorInfo(string filepath, uint? deviceId)
         }
 
         public const string Identifier = "DiskDataCooker";
-        public const string CookerPath = LTTngConstants.SourceId + "/" + Identifier;
 
         private static class DiskDataKeys
         {

LTTngDataExtensions/SourceDataCookers/LTTngBaseSourceCooker.cs

@@ -19,7 +19,7 @@ public abstract class LTTngBaseSourceCooker
         protected static readonly ReadOnlyHashSet<string> EmptyDataKeys = new ReadOnlyHashSet<string>(emptyDataKeys);
 
         protected LTTngBaseSourceCooker(string cookerId)
-            : this(new DataCookerPath(LTTngConstants.SourceId, cookerId))
+            : this(DataCookerPath.ForSource(LTTngConstants.SourceId, cookerId))
         {
         }
 

LTTngDataExtensions/SourceDataCookers/Module/LTTngModuleDataCooker.cs

@@ -18,7 +18,6 @@ public class LTTngModuleDataCooker
         : LTTngBaseSourceCooker
     {
         public const string Identifier = "ModuleDataCooker";
-        public const string CookerPath = LTTngConstants.SourceId + "/" + Identifier;
 
         private DiscardedEventsTracker discardedEventsTracker = new DiscardedEventsTracker();
         private ExecutingThreadTracker threadTracker = new ExecutingThreadTracker();

LTTngDataExtensions/SourceDataCookers/Syscall/LTTngSyscallDataCooker.cs

@@ -18,7 +18,6 @@ public class LTTngSyscallDataCooker
         : LTTngBaseSourceCooker
     {
         public const string Identifier = "SyscallDataCooker";
-        public const string CookerPath = LTTngConstants.SourceId + "/" + Identifier;
 
         public static string UknownSyscallExit = "compat_syscall_exit_unknown";
 

LTTngDataExtensions/SourceDataCookers/Thread/LTTngThreadDataCooker.cs

@@ -363,8 +363,7 @@ private static class ThreadCreationDataKeys
         });
 
         public const string Identifier = "ThreadDataCooker";
-        public const string CookerPath = LTTngConstants.SourceId + "/" + Identifier;
-        public static readonly DataCookerPath DataCookerPath = new DataCookerPath(LTTngConstants.SourceId, LTTngThreadDataCooker.Identifier);
+        public static readonly DataCookerPath DataCookerPath = DataCookerPath.ForSource(LTTngConstants.SourceId, LTTngThreadDataCooker.Identifier);
 
         public LTTngThreadDataCooker()
             : base(Identifier)

LTTngDataExtensions/Tables/DiagnosticMessageTable.cs

@@ -3,21 +3,23 @@
 
 using System;
 using System.Collections.Generic;
+using LTTngCds.CookerData;
 using LTTngDataExtensions.SourceDataCookers.Diagnostic_Messages;
 using Microsoft.Performance.SDK.Extensibility;
 using Microsoft.Performance.SDK.Processing;
 
 namespace LTTngDataExtensions.Tables
 {
     [Table]
-    [RequiresCooker(LTTngDmesgDataCooker.CookerPath)]
+    [RequiresSourceCooker(LTTngConstants.SourceId, LTTngDmesgDataCooker.Identifier)]
     public class DiagnosticMessageTable
     {
         public static TableDescriptor TableDescriptor = new TableDescriptor(
             Guid.Parse("{A752AFA9-B30E-44ED-B5BA-348C55A63157}"),
             "DiagnosticMessages",
             "Diagnostic Messages",
-            "Linux LTTng");
+            "Linux LTTng",
+            defaultLayout: TableLayoutStyle.GraphAndTable);
 
         private static readonly ColumnConfiguration messageColumn =
             new ColumnConfiguration(
@@ -31,7 +33,7 @@ public class DiagnosticMessageTable
         public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieval tableData)
         {
             var messages = tableData.QueryOutput<IReadOnlyList<IDiagnosticMessage>>(
-                DataOutputPath.Create(LTTngDmesgDataCooker.CookerPath + "/DiagnosticMessages"));
+                DataOutputPath.ForSource(LTTngConstants.SourceId, LTTngDmesgDataCooker.Identifier, nameof(LTTngDmesgDataCooker.DiagnosticMessages)));
             if (messages.Count == 0)
             {
                 return;
@@ -46,7 +48,6 @@ public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieva
                     TableConfiguration.GraphColumn,
                     timestampColumn
                 },
-                Layout = TableLayoutStyle.GraphAndTable,
             };
 
             config.AddColumnRole(ColumnRole.StartTime, timestampColumn);

LTTngDataExtensions/Tables/DiskTable.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using LTTngCds.CookerData;
 using LTTngDataExtensions.DataOutputTypes;
 using LTTngDataExtensions.SourceDataCookers.Disk;
 using Microsoft.Performance.SDK;
@@ -12,15 +13,16 @@
 namespace LTTngDataExtensions.Tables
 {
     [Table]
-    [RequiresCooker(LTTngDiskDataCooker.CookerPath)]
+    [RequiresSourceCooker(LTTngConstants.SourceId, LTTngDiskDataCooker.Identifier)]
     ///[PrebuiltConfigurationsFilePath("Resources\\DiskActivityPrebuiltConfiguration.json")]
     public static class DiskTable
     {
         public static TableDescriptor TableDescriptor = new TableDescriptor(
             Guid.Parse("{B18A134C-0B62-4C02-B729-6579C8223AB3}"),
             "Disk",
             "Disk Activity",
-            "Linux LTTng");
+            "Linux LTTng",
+            defaultLayout: TableLayoutStyle.GraphAndTable);
 
         private static readonly ColumnConfiguration deviceIdColumn =
             new ColumnConfiguration(
@@ -155,7 +157,7 @@ public static class DiskTable
         public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieval tableData)
         {
             var diskEvents = tableData.QueryOutput<IReadOnlyList<IDiskActivity>>(
-                DataOutputPath.Create(LTTngDiskDataCooker.CookerPath + '/' + nameof(LTTngDiskDataCooker.DiskActivity)));
+                DataOutputPath.ForSource(LTTngConstants.SourceId, LTTngDiskDataCooker.Identifier, nameof(LTTngDiskDataCooker.DiskActivity)));
             if (diskEvents.Count == 0)
             {
                 return;
@@ -182,7 +184,6 @@ public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieva
                     issueTimeColumn,
                     completeTimeColumn
                 },
-                Layout = TableLayoutStyle.GraphAndTable,
             };
 
             var ioTimesByDevFileConfig = new TableConfiguration("IOTime by Device, FilePath")
@@ -207,7 +208,6 @@ public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieva
                     ioTimeAvgColumn,
                     ioTimeMaxColumn
                 },
-                Layout = TableLayoutStyle.GraphAndTable,
             };
 
             iosByDeviceThCmdConfig.AddColumnRole(ColumnRole.StartTime, insertTimeColumn);

LTTngDataExtensions/Tables/ExecutionEvent.cs

@@ -7,18 +7,20 @@
 using Microsoft.Performance.SDK.Extensibility;
 using Microsoft.Performance.SDK.Processing;
 using Microsoft.Performance.SDK;
+using LTTngCds.CookerData;
 
 namespace LTTngDataExtensions.Tables
 {
     [Table]
-    [RequiresCooker(LTTngThreadDataCooker.CookerPath)]
+    [RequiresSourceCooker(LTTngConstants.SourceId, LTTngThreadDataCooker.Identifier)]
     public class ExecutionEvent
     {
         public static TableDescriptor TableDescriptor = new TableDescriptor(
             Guid.Parse("{91A234C3-3A3C-4230-85DA-76DE1C8E86BA}"),
             "Execution Events",
             "Context Switches History",
-            "Linux LTTng");
+            "Linux LTTng",
+            defaultLayout: TableLayoutStyle.GraphAndTable);
 
         private static readonly ColumnConfiguration cpuColumn =
             new ColumnConfiguration(
@@ -141,7 +143,7 @@ public class ExecutionEvent
         public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieval tableData)
         {
             var threads = tableData.QueryOutput<IReadOnlyList<IExecutionEvent>>(
-                DataOutputPath.Create(LTTngThreadDataCooker.CookerPath + "/ExecutionEvents"));
+                DataOutputPath.ForSource(LTTngConstants.SourceId, LTTngThreadDataCooker.Identifier, nameof(LTTngThreadDataCooker.ExecutionEvents)));
             if (threads.Count == 0)
             {
                 return;
@@ -170,7 +172,6 @@ public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieva
                     switchInTimeColumn,
                     switchOutTimeColumn
                 },
-                Layout = TableLayoutStyle.GraphAndTable,
                 InitialFilterShouldKeep = false,
                 InitialFilterQuery = filterIdleSamplesQuery,
             };
@@ -203,7 +204,6 @@ public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieva
                     TableConfiguration.GraphColumn,
                     percentCpuUsagePreset,
                 },
-                Layout = TableLayoutStyle.GraphAndTable,
                 InitialFilterShouldKeep = false,
                 InitialFilterQuery = filterIdleSamplesQuery,
             };
@@ -236,7 +236,6 @@ public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieva
                     TableConfiguration.GraphColumn,
                     percentCpuUsagePreset,
                 },
-                Layout = TableLayoutStyle.GraphAndTable,
                 InitialFilterShouldKeep = false,
                 InitialFilterQuery = filterIdleSamplesQuery,
             };

LTTngDataExtensions/Tables/FileEventsTable.cs

@@ -8,18 +8,20 @@
 using Microsoft.Performance.SDK.Extensibility;
 using Microsoft.Performance.SDK;
 using Microsoft.Performance.SDK.Processing;
+using LTTngCds.CookerData;
 
 namespace LTTngDataExtensions.Tables
 {
     [Table]
-    [RequiresCooker(LTTngDiskDataCooker.CookerPath)]
+    [RequiresSourceCooker(LTTngConstants.SourceId, LTTngDiskDataCooker.Identifier)]
     public class FileEventsTable
     {
         public static TableDescriptor TableDescriptor = new TableDescriptor(
             Guid.Parse("{A636196C-2FD9-453D-B315-2FC07AD06A26}"),
             "FileEvents",
             "File Events",
-            "Linux LTTng");
+            "Linux LTTng",
+            defaultLayout: TableLayoutStyle.GraphAndTable);
 
         private static readonly ColumnConfiguration fileEventNameColumn =
             new ColumnConfiguration(
@@ -69,7 +71,7 @@ public class FileEventsTable
         public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieval tableData)
         {
             var fileEvents = tableData.QueryOutput<IReadOnlyList<IFileEvent>>(
-                DataOutputPath.Create(LTTngDiskDataCooker.CookerPath + '/' + nameof(LTTngDiskDataCooker.FileEvents)));
+                DataOutputPath.ForSource(LTTngConstants.SourceId, LTTngDiskDataCooker.Identifier, nameof(LTTngDiskDataCooker.FileEvents)));
             if (fileEvents.Count == 0)
             {
                 return;
@@ -91,7 +93,6 @@ public static void BuildTable(ITableBuilder tableBuilder, IDataExtensionRetrieva
                     fileEventStartTimeColumn,
                     fileEventEndTimeColumn
                 },
-                Layout = TableLayoutStyle.GraphAndTable,
             };
 
             config.AddColumnRole(ColumnRole.StartTime, fileEventStartTimeColumn);