Add OpenXR "render from PV cam" note (#11127)

* Add info boxes about PV cam on OpenXR

* Update URLs

* Add helpboxes about the OpenXR behavior

Author: keveleigh

Assets/MRTK/Providers/OpenXR/Editor/MRTK.OpenXR.Editor.asmdef

@@ -3,6 +3,7 @@
     "rootNamespace": "Microsoft.MixedReality.Toolkit.XRSDK.OpenXR.Editor",
     "references": [
         "Microsoft.MixedReality.Toolkit",
+        "Microsoft.MixedReality.Toolkit.Editor.Utilities",
         "Microsoft.MixedReality.Toolkit.Editor.Inspectors",
         "Microsoft.MixedReality.Toolkit.Providers.OpenXR"
     ],
@@ -17,6 +18,12 @@
     "defineConstraints": [
         "UNITY_2020_2_OR_NEWER"
     ],
-    "versionDefines": [],
+    "versionDefines": [
+        {
+            "name": "com.microsoft.mixedreality.openxr",
+            "expression": "",
+            "define": "MSFT_OPENXR"
+        }
+    ],
     "noEngineReferences": false
 }

Assets/MRTK/Providers/OpenXR/Editor/OpenXRCameraSettingsProfileInspector.cs

@@ -14,12 +14,12 @@ public class OpenXRCameraSettingsProfileInspector : BaseMixedRealityToolkitConfi
     {
         private const string ProfileTitle = "OpenXR Camera Settings";
         private const string ProfileDescription = "";
-
-        private SerializedProperty reprojectionMethod;
+        private const string DepthReprojectionDocURL = "https://docs.microsoft.com/windows/mixed-reality/hologram-stability#reprojection";
 
         private static readonly GUIContent ReprojectionMethodTitle = new GUIContent("HoloLens 2 Reprojection Method");
+        private static GUIContent mrcSettingsButtonContent = null;
 
-        private const string DepthReprojectionDocURL = "https://docs.microsoft.com/windows/mixed-reality/hologram-stability#reprojection";
+        private SerializedProperty reprojectionMethod;
 
         protected override void OnEnable()
         {
@@ -35,6 +35,32 @@ public override void OnInspectorGUI()
             {
                 serializedObject.Update();
 
+                EditorGUILayout.HelpBox("Render from PV camera is now enabled by default when running with the Mixed Reality OpenXR Plugin. " +
+                    "It can be turned off from the \"Mixed Reality Features\" settings in the OpenXR plug-in settings. " +
+                    "Look for \"Disable First Person Observer\".", MessageType.Info);
+
+#if MSFT_OPENXR
+                mrcSettingsButtonContent ??= new GUIContent()
+                {
+                    image = EditorGUIUtility.IconContent("Settings").image,
+                    text = " OpenXR plug-in settings",
+                };
+
+                using (new EditorGUILayout.HorizontalScope())
+                {
+                    GUILayout.FlexibleSpace();
+                    // The settings button should always be enabled.
+                    using (new GUIEnabledWrapper())
+                    {
+                        if (GUILayout.Button(mrcSettingsButtonContent, EditorStyles.miniButton, GUILayout.MaxWidth(250f)))
+                        {
+                            SettingsService.OpenProjectSettings("Project/XR Plug-in Management/OpenXR");
+                        }
+                    }
+                    GUILayout.FlexibleSpace();
+                }
+#endif
+
                 EditorGUILayout.Space();
                 using (new EditorGUILayout.HorizontalScope())
                 {

Assets/MRTK/Providers/WindowsMixedReality/Shared/Editor/WindowsMixedRealityCameraSettingsProfileInspector.cs

@@ -22,9 +22,9 @@ public class WindowsMixedRealityCameraSettingsProfileInspector : BaseMixedRealit
         private static readonly GUIContent PVCameraRenderingTitle = new GUIContent("Render from PV Camera (Align holograms)");
         private static readonly GUIContent ReprojectionMethodTitle = new GUIContent("HoloLens 2 Reprojection Method");
 
-        private const string MRCDocURL = "https://docs.microsoft.com/windows/mixed-reality/mixed-reality-capture-for-developers#render-from-the-pv-camera-opt-in";
-        private const string DepthReprojectionDocURL = "https://docs.microsoft.com/windows/mixed-reality/hologram-stability#reprojection";
-        private const string ReadingModeDocURL = "https://docs.microsoft.com/en-us/hololens/hololens2-display#what-improvements-are-coming-that-will-improve-hololens-2-image-quality";
+        private const string MRCDocURL = "https://learn.microsoft.com/windows/mixed-reality/develop/advanced-concepts/mixed-reality-capture-overview#render-from-the-pv-camera-opt-in";
+        private const string DepthReprojectionDocURL = "https://learn.microsoft.com/windows/mixed-reality/develop/advanced-concepts/hologram-stability#reprojection";
+        private const string ReadingModeDocURL = "https://learn.microsoft.com/hololens/hololens2-display#what-improvements-are-coming-that-will-improve-hololens-2-image-quality";
 
         protected override void OnEnable()
         {
@@ -52,6 +52,7 @@ public override void OnInspectorGUI()
 
                 EditorGUILayout.HelpBox("On legacy XR, render from PV camera is supported in Unity 2018.4.35f1 and newer if using Unity 2018 and Unity 2019.4.26f1 and newer if using Unity 2019.", MessageType.Info);
                 EditorGUILayout.HelpBox("On Windows XR Plugin, render from PV camera is supported in versions 2.8.0, 4.5.0, and 5.3.0 (and newer in each respective major version).", MessageType.Info);
+                EditorGUILayout.HelpBox("This checkbox is ignored on OpenXR and is now enabled by default when running with the Mixed Reality OpenXR Plugin. See the OpenXR Camera Settings profile for more info.", MessageType.Info);
                 EditorGUILayout.PropertyField(renderFromPVCameraForMixedRealityCapture, PVCameraRenderingTitle);
 
                 EditorGUILayout.Space();