Skip to content

Commit 0c611f6

Browse files
author
David Kline (ANALOG)
committed
complete scaffolding, shorten enum names, update docs
1 parent d583334 commit 0c611f6

28 files changed

+147
-101
lines changed

Assets/MixedRealityToolkit-SDK/Features/SpatialAwareness/System/MixedRealitySpatialAwarenessPlanarSurfaceDescription.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ public Vector3 Normal
2121
{ get; private set; }
2222

2323
/// <inheritdoc />
24-
public MixedRealitySpatialAwarenessSurfaceTypes SurfaceType
24+
public SpatialAwarenessSurfaceTypes SurfaceType
2525
{ get; private set; }
2626

2727
public MixedRealitySpatialAwarenessPlanarSurfaceDescription(
2828
Vector3 position,
2929
Bounds boundingBox,
3030
Vector3 normal,
31-
MixedRealitySpatialAwarenessSurfaceTypes surfaceType) : base(position)
31+
SpatialAwarenessSurfaceTypes surfaceType) : base(position)
3232
{
3333
BoundingBox = boundingBox;
3434
Normal = normal;

Assets/MixedRealityToolkit-SDK/Features/SpatialAwareness/System/MixedRealitySpatialAwarenessSystem.cs

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
using Microsoft.MixedReality.Toolkit.Core.Interfaces.SpatialAwarenessSystem;
77
using Microsoft.MixedReality.Toolkit.Core.Interfaces.SpatialAwarenessSystem.Handlers;
88
using Microsoft.MixedReality.Toolkit.Core.Managers;
9-
using Microsoft.MixedReality.Toolkit.Core.Utilities;
109
using System.Collections;
1110
using System.Collections.Generic;
1211
using UnityEngine;
@@ -245,7 +244,7 @@ private void RaiseSurfaceAdded(
245244
Vector3 position,
246245
Bounds boundingBox,
247246
Vector3 normal,
248-
MixedRealitySpatialAwarenessSurfaceTypes surfaceType,
247+
SpatialAwarenessSurfaceTypes surfaceType,
249248
GameObject surfaceObject = null)
250249
{
251250
// todo
@@ -276,7 +275,7 @@ private void RaiseSurfaceUpdated(
276275
Vector3 position,
277276
Bounds boundingBox,
278277
Vector3 normal,
279-
MixedRealitySpatialAwarenessSurfaceTypes surfaceType,
278+
SpatialAwarenessSurfaceTypes surfaceType,
280279
GameObject surfaceObject = null)
281280
{
282281
// todo
@@ -405,18 +404,26 @@ public void ResumeObserver()
405404
{
406405
if (IsObserverRunning) { return; }
407406

407+
#if UNITY_WSA
408408
// todo
409+
#endif // UNITY_WSA
410+
411+
IsObserverRunning = true;
409412
}
410413

411414
/// <inheritdoc />
412415
public void SuspendObserver()
413416
{
414417
if (!IsObserverRunning) { return; }
415418

419+
#if UNITY_WSA
416420
// todo
421+
#endif // UNITY_WSA
422+
423+
IsObserverRunning = false;
417424
}
418425

419-
#region Mesh Handling implementation
426+
#region Mesh Handling implementation
420427

421428
/// <inheritdoc />
422429
public bool UseMeshSystem { get; set; } = true;
@@ -427,10 +434,10 @@ public void SuspendObserver()
427434
/// <inheritdoc />
428435
public int MeshPhysicsLayerMask => 1 << MeshPhysicsLayer;
429436

430-
private MixedRealitySpatialAwarenessMeshLevelOfDetail meshLevelOfDetail = MixedRealitySpatialAwarenessMeshLevelOfDetail.Coarse;
437+
private SpatialAwarenessMeshLevelOfDetail meshLevelOfDetail = SpatialAwarenessMeshLevelOfDetail.Coarse;
431438

432439
/// <inheritdoc />
433-
public MixedRealitySpatialAwarenessMeshLevelOfDetail MeshLevelOfDetail
440+
public SpatialAwarenessMeshLevelOfDetail MeshLevelOfDetail
434441
{
435442
get
436443
{
@@ -447,7 +454,7 @@ public MixedRealitySpatialAwarenessMeshLevelOfDetail MeshLevelOfDetail
447454
if (meshLevelOfDetail != value)
448455
{
449456
// Non-custom values automatically modify MeshTrianglesPerCubicMeter
450-
if (value != MixedRealitySpatialAwarenessMeshLevelOfDetail.Custom)
457+
if (value != SpatialAwarenessMeshLevelOfDetail.Custom)
451458
{
452459
meshTrianglesPerCubicMeter = (int)value;
453460
}
@@ -457,7 +464,7 @@ public MixedRealitySpatialAwarenessMeshLevelOfDetail MeshLevelOfDetail
457464
}
458465
}
459466

460-
private int meshTrianglesPerCubicMeter = (int)MixedRealitySpatialAwarenessMeshLevelOfDetail.Coarse;
467+
private int meshTrianglesPerCubicMeter = (int)SpatialAwarenessMeshLevelOfDetail.Coarse;
461468

462469
/// <inheritdoc />
463470
public int MeshTrianglesPerCubicMeter
@@ -504,9 +511,9 @@ public Dictionary<uint, GameObject> GetMeshObjects()
504511
return new Dictionary<uint, GameObject>(0);
505512
}
506513

507-
#endregion Mesh Handling implementation
514+
#endregion Mesh Handling implementation
508515

509-
#region Surface Finding Handling implementation
516+
#region Surface Finding Handling implementation
510517

511518
/// <inheritdoc />
512519
public bool UseSurfaceFindingSystem { get; set; } = false;
@@ -558,8 +565,8 @@ public Dictionary<uint, GameObject> GetSurfaceObjects()
558565
return new Dictionary<uint, GameObject>(0);
559566
}
560567

561-
#endregion Surface Finding Handling implementation
568+
#endregion Surface Finding Handling implementation
562569

563-
#endregion IMixedRealitySpatialAwarenessSystem Implementation
570+
#endregion IMixedRealitySpatialAwarenessSystem Implementation
564571
}
565572
}

Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/IMixedRealitySpatialAwarenessPlanarSurfaceDescription.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ public interface IMixedRealitySpatialAwarenessPlanarSurfaceDescription : IMixedR
2323
/// <summary>
2424
/// The semantic (ex: Floor) associated with the surface.
2525
/// </summary>
26-
MixedRealitySpatialAwarenessSurfaceTypes SurfaceType { get; }
26+
SpatialAwarenessSurfaceTypes SurfaceType { get; }
2727
}
2828
}

Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/MixedRealitySpatialAwarenessProfile.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@ public class MixedRealitySpatialAwarenessProfile : ScriptableObject
6565

6666
[SerializeField]
6767
[Tooltip("Level of detail for the mesh")]
68-
private MixedRealitySpatialAwarenessMeshLevelOfDetail meshLevelOfDetail = MixedRealitySpatialAwarenessMeshLevelOfDetail.Coarse;
68+
private SpatialAwarenessMeshLevelOfDetail meshLevelOfDetail = SpatialAwarenessMeshLevelOfDetail.Coarse;
6969

7070
/// <summary>
7171
/// The desired Unity Physics Layer on which to set the spatial mesh.
7272
/// </summary>
73-
public MixedRealitySpatialAwarenessMeshLevelOfDetail MeshLevelOfDetail => meshLevelOfDetail;
73+
public SpatialAwarenessMeshLevelOfDetail MeshLevelOfDetail => meshLevelOfDetail;
7474

7575
[SerializeField]
7676
[Tooltip("Level of detail, in triangles per cubic meter.\nIgnored unless MeshLevelOfDetail is set to Custom.")]

Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/MixedRealitySpatialAwarenessEventType.cs renamed to Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/SpatialAwarenessEventType.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Microsoft.MixedReality.Toolkit.Core.Definitions.SpatialAwarenessSystem
66
/// <summary>
77
/// Enumeration defining the types of events that spatial awareness subsystems will send.
88
/// </summary>
9-
public enum MixedRealitySpatialAwarenessEventType
9+
public enum SpatialAwarenessEventType
1010
{
1111
/// <summary>
1212
/// A spatial awareness subsystem is reporting that a new spatial element

Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/MixedRealitySpatialAwarenessEventType.cs.meta renamed to Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/SpatialAwarenessEventType.cs.meta

File renamed without changes.

Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/MixedRealitySpatialAwarenessMeshLevelOfDetail.cs renamed to Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/SpatialAwarenessMeshLevelOfDetail.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace Microsoft.MixedReality.Toolkit.Core.Definitions.SpatialAwarenessSystem
99
/// <remarks>
1010
/// The integral values for these levels of detail generally map to triangle density, in triangles per cubic meter.
1111
/// /remarks>
12-
public enum MixedRealitySpatialAwarenessMeshLevelOfDetail
12+
public enum SpatialAwarenessMeshLevelOfDetail
1313
{
1414
/// <summary>
1515
/// The custom level of detail allows specifying a custom value for

Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/MixedRealitySpatialAwarenessMeshLevelOfDetail.cs.meta renamed to Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/SpatialAwarenessMeshLevelOfDetail.cs.meta

File renamed without changes.

Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/MixedRealitySpatialAwarenessSurfaceTypes.cs renamed to Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/SpatialAwarenessSurfaceTypes.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,28 @@ namespace Microsoft.MixedReality.Toolkit.Core.Definitions.SpatialAwarenessSystem
66
/// <summary>
77
/// Enumeration defining the types of planar surfaces that are supported by the spatial awareness surface finding subsystem.
88
/// </summary>
9-
public enum MixedRealitySpatialAwarenessSurfaceTypes
9+
[System.Flags]
10+
public enum SpatialAwarenessSurfaceTypes
1011
{
1112
/// <summary>
1213
/// An unknown / unsupported type of surface.
1314
/// </summary>
14-
Unknown = 0,
15+
Unknown = 1 << 0,
1516

1617
/// <summary>
1718
/// The environment’s floor.
1819
/// </summary>
19-
Floor,
20+
Floor = 1 << 1,
2021

2122
/// <summary>
2223
/// The environment’s ceiling.
2324
/// </summary>
24-
Ceiling,
25+
Ceiling = 1 << 2,
2526

2627
/// <summary>
2728
/// A wall within the user’s space.
2829
/// </summary>
29-
Wall,
30+
Wall = 1 << 3,
3031

3132
/// <summary>
3233
/// A raised, horizontal surface such as a shelf.
@@ -35,6 +36,6 @@ public enum MixedRealitySpatialAwarenessSurfaceTypes
3536
/// Platforms, like floors, that can be used for placing objects
3637
/// requiring a horizontal surface.
3738
/// </remarks>
38-
Platform
39+
Platform = 1 << 4
3940
}
4041
}

Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/MixedRealitySpatialAwarenessSurfaceTypes.cs.meta renamed to Assets/MixedRealityToolkit/_Core/Definitions/SpatialAwareness/SpatialAwarenessSurfaceTypes.cs.meta

File renamed without changes.

0 commit comments

Comments
 (0)