Skip to content

Commit 1107436

Browse files
author
David Kline (ANALOG)
committed
pr feedback
1 parent 3baf7fd commit 1107436

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

Assets/MixedRealityToolkit-SDK/Features/SpatialAwareness/System/MixedRealitySpatialAwarenessBaseDescription.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ namespace Microsoft.MixedReality.Toolkit.SDK.SpatialAwarenessSystem
1313
public class MixedRealitySpatialAwarenessBaseDescription : IMixedRealitySpatialAwarenessBaseDescription
1414
{
1515
/// <inheritdoc />
16-
public Vector3 Position
17-
{ get; private set; }
16+
public Vector3 Position { get; private set; }
1817

1918
public MixedRealitySpatialAwarenessBaseDescription(Vector3 position)
2019
{
@@ -56,7 +55,7 @@ int IEqualityComparer.GetHashCode(object obj)
5655

5756
public override int GetHashCode()
5857
{
59-
string s = $"Position({Position.x},{Position.y},{Position.z})";
58+
string s = $"Position({Position})";
6059
return s.GetHashCode();
6160
}
6261

Assets/MixedRealityToolkit-SDK/Features/SpatialAwareness/System/MixedRealitySpatialAwarenessMeshDescription.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ namespace Microsoft.MixedReality.Toolkit.SDK.SpatialAwarenessSystem
1313
public class MixedRealitySpatialAwarenessMeshDescription : MixedRealitySpatialAwarenessBaseDescription, IMixedRealitySpatialAwarenessMeshDescription
1414
{
1515
/// <inheritdoc />
16-
public Mesh Mesh
17-
{get; private set;}
16+
public Mesh Mesh {get; private set;}
1817

1918
public MixedRealitySpatialAwarenessMeshDescription(Vector3 position, Mesh mesh) : base(position)
2019
{
@@ -57,7 +56,7 @@ int IEqualityComparer.GetHashCode(object obj)
5756

5857
public override int GetHashCode()
5958
{
60-
string s = $"Position({Position.x},{Position.y},{Position.z}):MeshHash({Mesh.GetHashCode()}";
59+
string s = $"Position({Position}):MeshHash({Mesh.GetHashCode()}";
6160
return s.GetHashCode();
6261
}
6362

Assets/MixedRealityToolkit-SDK/Features/SpatialAwareness/System/MixedRealitySpatialAwarenessPlanarSurfaceDescription.cs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,13 @@ namespace Microsoft.MixedReality.Toolkit.SDK.SpatialAwarenessSystem
1313
public class MixedRealitySpatialAwarenessPlanarSurfaceDescription : MixedRealitySpatialAwarenessBaseDescription, IMixedRealitySpatialAwarenessPlanarSurfaceDescription
1414
{
1515
/// <inheritdoc />
16-
public Bounds BoundingBox
17-
{ get; private set; }
16+
public Bounds BoundingBox { get; private set; }
1817

1918
/// <inheritdoc />
20-
public Vector3 Normal
21-
{ get; private set; }
19+
public Vector3 Normal { get; private set; }
2220

2321
/// <inheritdoc />
24-
public SpatialAwarenessSurfaceTypes SurfaceType
25-
{ get; private set; }
22+
public SpatialAwarenessSurfaceTypes SurfaceType { get; private set; }
2623

2724
public MixedRealitySpatialAwarenessPlanarSurfaceDescription(
2825
Vector3 position,
@@ -80,7 +77,7 @@ int IEqualityComparer.GetHashCode(object obj)
8077

8178
public override int GetHashCode()
8279
{
83-
string s = $"Position({Position.x},{Position.y},{Position.z}):{SurfaceType.ToString()}:Bounds({BoundingBox.min},{BoundingBox.max}):Normal({Normal.x},{Normal.y},{Normal.z}";
80+
string s = $"Position({Position}):{SurfaceType.ToString()}:Bounds({BoundingBox.min},{BoundingBox.max}):Normal({Normal.x},{Normal.y},{Normal.z}";
8481
return s.GetHashCode();
8582
}
8683

0 commit comments

Comments
 (0)