Add xml comments and IInputSourceInfoProvider

Author: Robert El-Soudani

Assets/HoloToolkit/Input/Scripts/Focus/InputSourcePointer.cs

@@ -65,21 +65,12 @@ public bool OwnsInput(BaseEventData eventData)
 
         public bool InputIsFromSource(BaseEventData eventData)
         {
-            var inputData = (eventData as BaseInputEventData);
+            var inputData = (eventData as IInputSourceInfoProvider);
 
-            if (inputData != null)
-            {
-                return (inputData.InputSource == InputSource) && (inputData.SourceId == InputSourceId);
-            }
-
-            var pointerInputEventData = (eventData as PointerInputEventData);
-
-            if (pointerInputEventData != null)
-            {
-                return (pointerInputEventData.InputSource == InputSource) && (pointerInputEventData.InputSourceId == InputSourceId);
-            }
-
-            return false;
+            return (inputData != null)
+                && (inputData.InputSource == InputSource)
+                && (inputData.SourceId == InputSourceId)
+                ;
         }
     }
 }

Assets/HoloToolkit/Input/Scripts/InputEventData/BaseInputEventData.cs

@@ -8,7 +8,7 @@ namespace HoloToolkit.Unity.InputModule
     /// <summary>
     /// Base class of all input events.
     /// </summary>
-    public abstract class BaseInputEventData : BaseEventData
+    public abstract class BaseInputEventData : BaseEventData, IInputSourceInfoProvider
     {
         /// <summary>
         /// The source the input event originates from.

Assets/HoloToolkit/Input/Scripts/InputEventData/PointerInputEventData.cs

@@ -1,16 +1,20 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
-using HoloToolkit.Unity.InputModule;
 using UnityEngine.EventSystems;
 
 namespace HoloToolkit.Unity.InputModule
 {
-    public class PointerInputEventData : PointerEventData
+    /// <summary>
+    /// Describes a Unity pointer event that was generated by a specific input source and ID.
+    /// </summary>
+    public class PointerInputEventData :
+        PointerEventData,
+        IInputSourceInfoProvider
     {
         public IInputSource InputSource { get; set; }
 
-        public uint InputSourceId { get; set; }
+        public uint SourceId { get; set; }
 
         public PointerInputEventData(EventSystem eventSystem) : base(eventSystem)
         {

Assets/HoloToolkit/Input/Scripts/Utilities/InputSourceInfo.cs

@@ -1,13 +1,16 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
+using System;
+
 namespace HoloToolkit.Unity.InputModule
 {
     /// <summary>
     /// InputSourceInfo gives you the input source like hands or motion controller.
     /// It will also report the source id for that source.
     /// </summary>
-    public struct InputSourceInfo
+    public struct InputSourceInfo :
+        IInputSourceInfoProvider
     {
         public IInputSource InputSource;
         public uint SourceId;
@@ -19,9 +22,34 @@ public InputSourceInfo(IInputSource inputSource, uint sourceId) :
             SourceId = sourceId;
         }
 
+        IInputSource IInputSourceInfoProvider.InputSource
+        {
+            get { return InputSource; }
+        }
+
+        uint IInputSourceInfoProvider.SourceId
+        {
+            get { return SourceId; }
+        }
+
+        public bool Matches(IInputSourceInfoProvider other)
+        {
+            return ((other != null) && Matches(other.InputSource, other.SourceId));
+        }
+
         public bool Matches(IInputSource otherInputSource, uint otherSourceId)
         {
             return ((InputSource == otherInputSource) && (SourceId == otherSourceId));
         }
     }
+
+    /// <summary>
+    /// IInputSourceInfoProvider gives you the input source like hands or motion controller.
+    /// It will also report the source id for that source.
+    /// </summary>
+    public interface IInputSourceInfoProvider
+    {
+        IInputSource InputSource { get; }
+        uint SourceId { get; }
+    }
 }

Assets/HoloToolkit/Utilities/Scripts/HashCodes.cs

@@ -3,6 +3,10 @@
 
 namespace HoloToolkit.Unity
 {
+    /// <summary>
+    /// Provides helper methods for combining hash codes of many properties or objects into an
+    /// aggregated hash code.
+    /// </summary>
     public static class HashCodes
     {
         public static int Combine(int first, int second)