Added Const MaximumCharacterLength

StephenHodgson · StephenHodgson · commit 1da02f21c5ad · 2017-08-02T16:37:39.000-07:00
diff --git a/Assets/HoloToolkit/Sharing/Scripts/Utilities/ManualIpConfiguration.cs b/Assets/HoloToolkit/Sharing/Scripts/Utilities/ManualIpConfiguration.cs
@@ -10,6 +10,11 @@ namespace HoloToolkit.Sharing.Utilities
     /// </summary>
     public class ManualIpConfiguration : MonoBehaviour
     {
+        /// <summary>
+        /// The maximum length of characters in a IPv4 address.
+        /// </summary>
+        private const int MaximumCharacterLength = 12;
+
         public string IpAddress { get { return ipAddress.text; } }
 
         /// <summary>
@@ -152,7 +157,7 @@ public void InputString(string input)
                 ipAddress.text = string.Empty;
             }
 
-            if (ipAddress.text.Length < 15)
+            if (ipAddress.text.Length < MaximumCharacterLength)
             {
                 ipAddress.text += input;
             }

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,11 @@ namespace HoloToolkit.Sharing.Utilities`
`10`	`10`	`/// </summary>`
`11`	`11`	`public class ManualIpConfiguration : MonoBehaviour`
`12`	`12`	`{`
	`13`	`+ /// <summary>`
	`14`	`+ /// The maximum length of characters in a IPv4 address.`
	`15`	`+ /// </summary>`
	`16`	`+ private const int MaximumCharacterLength = 12;`
	`17`	`+`
`13`	`18`	`public string IpAddress { get { return ipAddress.text; } }`
`14`	`19`
`15`	`20`	`/// <summary>`
`@@ -152,7 +157,7 @@ public void InputString(string input)`
`152`	`157`	`ipAddress.text = string.Empty;`
`153`	`158`	`}`
`154`	`159`
`155`		`- if (ipAddress.text.Length < 15)`
	`160`	`+ if (ipAddress.text.Length < MaximumCharacterLength)`
`156`	`161`	`{`
`157`	`162`	`ipAddress.text += input;`
`158`	`163`	`}`