PR review fixes

Author: Stephen Hodgson

Assets/HoloToolkit/Sharing/Scripts/SyncModel/SyncArray.cs

@@ -37,13 +37,13 @@ namespace HoloToolkit.Sharing.SyncModel
         /// Type of objects in the array.
         /// This is cached so that we don't have to call typeof(T) more than once.
         /// </summary>
-        protected Type ArrayType;
+        protected readonly Type arrayType;
 
         public SyncArray(string field)
             : base(field)
         {
             dataArray = new Dictionary<string, T>();
-            ArrayType = typeof(T);
+            arrayType = typeof(T);
         }
 
         public SyncArray() : this(string.Empty) { }
@@ -56,7 +56,7 @@ public SyncArray() : this(string.Empty) { }
         protected virtual T CreateObject(ObjectElement objectElement)
         {
             Type objectType = SyncSettings.Instance.GetDataModelType(objectElement.GetObjectType()).AsType();
-            if (!objectType.IsSubclassOf(ArrayType) && objectType != ArrayType)
+            if (!objectType.IsSubclassOf(arrayType) && objectType != arrayType)
             {
                 throw new InvalidCastException(string.Format("Object of incorrect type added to SyncArray: Expected {0}, got {1} ", objectType, objectElement.GetObjectType().GetString()));
             }
@@ -212,7 +212,6 @@ private void OnInitializationComplete(SyncObject obj)
         /// <returns></returns>
         private T AddObject(ObjectElement existingElement)
         {
-            //bool isLocal = false;
             string id = existingElement.GetName();
 
             // Create a new object and assign the element
@@ -224,12 +223,6 @@ private T AddObject(ObjectElement existingElement)
             // Update internal map
             dataArray[id] = newObject;
 
-            // If it's local, make sure to initialize it so it can be used immediately.
-            //if (isLocal)
-            //{
-            //    newObject.InitializeLocal(Element);
-            //}
-
             return newObject;
         }
     }

Assets/HoloToolkit/Sharing/Scripts/SyncModel/SyncQuaternion.cs

@@ -21,7 +21,7 @@ public class SyncQuaternion : SyncObject
 #if UNITY_EDITOR
         public override object RawValue
         {
-            get { return new Quaternion(x.Value, y.Value, z.Value, w.Value); }
+            get { return Value; }
         }
 #endif
 

Assets/HoloToolkit/Sharing/Scripts/SyncModel/SyncVector3.cs

@@ -20,7 +20,7 @@ public class SyncVector3 : SyncObject
 #if UNITY_EDITOR
         public override object RawValue
         {
-            get { return new Vector3(x.Value, y.Value, z.Value); }
+            get { return Value; }
         }
 #endif
 

Assets/HoloToolkit/Utilities/Scripts/WorldAnchorManager.cs

@@ -170,7 +170,7 @@ private void CreateAnchor(GameObject gameObjectToAnchor, string anchorName)
             }
             else
             {
-                // Othertimes we must wait for the
+                // Other times we must wait for the tracking system to locate the world.
                 anchor.OnTrackingChanged += Anchor_OnTrackingChanged;
             }
         }