Rework collection updating to one place

Author: keveleigh

Assets/MRTK/Tools/RuntimeTools/Tools/InputFeatureUsageTool/ListInputFeatureUsages.cs

@@ -57,14 +57,12 @@ private void Update()
 
             listInputDevicesTextMesh.text = $"Detected {sourceCount} input source{(sourceCount > 1 ? "s:" : sourceCount != 0 ? ":" : "s")}\n";
 
+            bool collectionNeedsUpdating = false;
+
             for (int i = displayFeatureUsagesTextMeshes.Count; i < sourceCount; i++)
             {
                 displayFeatureUsagesTextMeshes.Add(Instantiate(displayFeatureUsagesPrefab, gameObject.transform).GetComponentInChildren<TextMesh>());
-                // For optimal performance, only update the collection when adding the final text panel
-                if (i == sourceCount - 1)
-                {
-                    gridObjectCollection.UpdateCollection();
-                }
+                collectionNeedsUpdating = true;
             }
 
             for (int i = 0; i < displayFeatureUsagesTextMeshes.Count; i++)
@@ -80,15 +78,15 @@ private void Update()
                     if (textMesh.transform.parent.gameObject.activeSelf)
                     {
                         textMesh.transform.parent.gameObject.SetActive(false);
-                        gridObjectCollection.UpdateCollection();
+                        collectionNeedsUpdating = true;
                     }
                     continue;
                 }
 
                 if (!textMesh.transform.parent.gameObject.activeSelf)
                 {
                     textMesh.transform.parent.gameObject.SetActive(true);
-                    gridObjectCollection.UpdateCollection();
+                    collectionNeedsUpdating = true;
                 }
 
                 InputDevice inputDevice = inputDevices[i];
@@ -169,6 +167,11 @@ private void Update()
                     }
                 }
             }
+
+            if (collectionNeedsUpdating)
+            {
+                gridObjectCollection.UpdateCollection();
+            }
 #else
             listInputDevicesTextMesh.text = $"This feature is only supported on Unity 2019.3 or newer.";
 #endif // UNITY_2019_3_OR_NEWER