only detach children when calling Destroy

Author: Alexander Seeck

Assets/MixedRealityToolkit.Services/BoundarySystem/MixedRealityBoundarySystem.cs

@@ -81,14 +81,14 @@ public override void Destroy()
             // and clean up the parent.
             if (boundaryVisualizationParent != null)
             {
-                boundaryVisualizationParent.transform.DetachChildren();
 
                 if (Application.isEditor)
                 {
                     Object.DestroyImmediate(boundaryVisualizationParent);
                 }
                 else
                 {
+                    boundaryVisualizationParent.transform.DetachChildren();
                     Object.Destroy(boundaryVisualizationParent);
                 }
 

Assets/MixedRealityToolkit.Services/DiagnosticsSystem/MixedRealityDiagnosticsSystem.cs

@@ -62,13 +62,13 @@ public override void Destroy()
         {
             if (diagnosticVisualizationParent != null)
             {
-                diagnosticVisualizationParent.transform.DetachChildren();
                 if (Application.isEditor)
                 {
                     Object.DestroyImmediate(diagnosticVisualizationParent);
                 }
                 else
                 {
+                    diagnosticVisualizationParent.transform.DetachChildren();
                     Object.Destroy(diagnosticVisualizationParent);
                 }
 

Assets/MixedRealityToolkit.Services/SpatialAwarenessSystem/MixedRealitySpatialAwarenessSystem.cs

@@ -83,13 +83,13 @@ public override void Destroy()
                 // Detach the child objects and clean up the parent.
                 if (spatialAwarenessObjectParent != null)
                 {
-                    spatialAwarenessObjectParent.transform.DetachChildren();
                     if (Application.isEditor)
                     {
                         Object.DestroyImmediate(spatialAwarenessObjectParent);
                     }
                     else
                     {
+                        spatialAwarenessObjectParent.transform.DetachChildren();
                         Object.Destroy(spatialAwarenessObjectParent);
                     }
                     spatialAwarenessObjectParent = null;