Skip to content

Commit 40b1d2a

Browse files
committed
Additional formatting and refactoring
1 parent 0db48ef commit 40b1d2a

File tree

1 file changed

+8
-15
lines changed

1 file changed

+8
-15
lines changed

Assets/MixedRealityToolkit.Services/InputSystem/MixedRealityInputSystem.cs

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ public override void Disable()
245245
public override void HandleEvent<T>(BaseEventData eventData, ExecuteEvents.EventFunction<T> eventHandler)
246246
{
247247
Debug.Assert(eventData != null);
248-
Debug.Assert(!(eventData is MixedRealityPointerEventData), "HandleEvent called with a pointer event. All events raised by pointer should call HandlePointerEvent");
248+
Debug.Assert(!(eventData is MixedRealityPointerEventData), "HandleEvent called with a pointer event. All events raised by pointer should call HandlePointerEvent");
249249

250250
if (disabledRefCount > 0)
251251
{
@@ -254,7 +254,7 @@ public override void HandleEvent<T>(BaseEventData eventData, ExecuteEvents.Event
254254

255255
var baseInputEventData = ExecuteEvents.ValidateEventData<BaseInputEventData>(eventData);
256256
DispatchEventToGlobalListeners(baseInputEventData, eventHandler);
257-
257+
258258
if (baseInputEventData.used)
259259
{
260260
// All global listeners get a chance to see the event,
@@ -277,7 +277,7 @@ public override void HandleEvent<T>(BaseEventData eventData, ExecuteEvents.Event
277277
DispatchEventToFallbackHandlers(baseInputEventData, eventHandler);
278278
}
279279
}
280-
280+
281281
/// <summary>
282282
/// Handles a pointer event
283283
/// Assumption: We only send pointer events to the objects that pointers are focusing, except for global event listeners (which listen to everything)
@@ -304,7 +304,7 @@ private void HandlePointerEvent<T>(BaseEventData eventData, ExecuteEvents.EventF
304304

305305
Debug.Assert(pointerEventData.Pointer != null, "Trying to dispatch event on pointer but pointerEventData is null");
306306

307-
DispatchEventToObjectFocusedByPointer(pointerEventData.Pointer, baseInputEventData, false, eventHandler);
307+
DispatchEventToObjectFocusedByPointer(pointerEventData.Pointer, baseInputEventData, false, eventHandler);
308308

309309
if (!baseInputEventData.used)
310310
{
@@ -323,7 +323,7 @@ private void DispatchEventToGlobalListeners<T>(BaseInputEventData baseInputEvent
323323
Debug.Assert(baseInputEventData.InputSource != null, $"Failed to find an input source for {baseInputEventData}");
324324

325325
// Send the event to global listeners
326-
base.HandleEvent(baseInputEventData, eventHandler);
326+
base.HandleEvent(baseInputEventData, eventHandler);
327327
}
328328

329329
private void DispatchEventToFallbackHandlers<T>(BaseInputEventData baseInputEventData, ExecuteEvents.EventFunction<T> eventHandler) where T : IEventSystemHandler
@@ -336,12 +336,11 @@ private void DispatchEventToFallbackHandlers<T>(BaseInputEventData baseInputEven
336336
}
337337
}
338338

339-
340339
/// <summary>
341340
/// Dispatch an input event to the object focused by the given IMixedRealityPointer.
342341
/// If a modal dialog is active, dispatch the pointer event to that modal dialog
343342
/// Returns true if the event was handled by a modal handler
344-
private bool DispatchEventToObjectFocusedByPointer<T>(IMixedRealityPointer mixedRealityPointer, BaseInputEventData baseInputEventData,
343+
private bool DispatchEventToObjectFocusedByPointer<T>(IMixedRealityPointer mixedRealityPointer, BaseInputEventData baseInputEventData,
345344
bool modalEventHandled, ExecuteEvents.EventFunction<T> eventHandler) where T : IEventSystemHandler
346345
{
347346
GameObject focusedObject = FocusProvider?.GetFocusedObject(mixedRealityPointer);
@@ -849,10 +848,7 @@ public void RaiseFocusExit(IMixedRealityPointer pointer, GameObject unfocusedObj
849848
/// <inheritdoc />
850849
public void RaisePointerDown(IMixedRealityPointer pointer, Handedness handedness, MixedRealityInputAction inputAction)
851850
{
852-
// Create input event
853-
pointerEventData.Initialize(pointer, handedness, inputAction);
854-
855-
ExecutePointerDown(HandlePointerDown(pointer));
851+
RaisePointerDown(pointer, inputAction, handedness);
856852
}
857853

858854
/// <inheritdoc />
@@ -933,10 +929,7 @@ private void HandleClick()
933929
/// <inheritdoc />
934930
public void RaisePointerUp(IMixedRealityPointer pointer, Handedness handedness, MixedRealityInputAction inputAction)
935931
{
936-
// Create input event
937-
pointerEventData.Initialize(pointer, handedness, inputAction);
938-
939-
ExecutePointerUp(HandlePointerUp(pointer));
932+
RaisePointerUp(pointer, inputAction, handedness);
940933
}
941934

942935
/// <inheritdoc />

0 commit comments

Comments
 (0)