Skip to content

Commit 4a83f37

Browse files
cleanup pass
1 parent 4631f88 commit 4a83f37

File tree

4 files changed

+6
-17
lines changed

4 files changed

+6
-17
lines changed

Assets/MixedRealityToolkit-SDK/Features/UX/Scripts/Pointers/TouchPointer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public override bool TryGetPointerPosition(out Vector3 position)
6767
{
6868
position = Vector3.zero;
6969
if (fingerId < 0) { return false; }
70-
position = Result?.Details.Point ?? CameraCache.Main.ScreenPointToRay(UnityEngine.Input.GetTouch(FingerId).position).GetPoint(PointerExtent); ;
70+
position = Result?.Details.Point ?? CameraCache.Main.ScreenPointToRay(UnityEngine.Input.GetTouch(FingerId).position).GetPoint(PointerExtent);
7171
return true;
7272
}
7373

Assets/MixedRealityToolkit/_Core/Definitions/InputSystem/MixedRealityInputSystemProfile.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public MixedRealityPointerProfile PointerProfile
5353
get { return pointerProfile; }
5454
private set { pointerProfile = value; }
5555
}
56+
5657
private IMixedRealitySpeechSystem speechSystem;
5758

5859
/// <summary>
@@ -63,7 +64,7 @@ public MixedRealityPointerProfile PointerProfile
6364
/// <summary>
6465
/// Is the speech Commands Enabled?
6566
/// </summary>
66-
public bool IsSpeechCommandsEnabled => speechCommandsProfile != null && MixedRealityManager.Instance.ActiveProfile.IsInputSystemEnabled && SpeechSystem != null;
67+
public bool IsSpeechCommandsEnabled => speechCommandsProfile != null && SpeechSystem != null && MixedRealityManager.Instance.ActiveProfile.IsInputSystemEnabled;
6768

6869
[SerializeField]
6970
[Tooltip("Speech Command profile for wiring up Voice Input to Actions.")]
@@ -115,6 +116,5 @@ public MixedRealityControllerMappingProfile ControllerMappingProfile
115116
get { return controllerMappingProfile; }
116117
private set { controllerMappingProfile = value; }
117118
}
118-
119119
}
120120
}

Assets/MixedRealityToolkit/_Core/Inspectors/Profiles/MixedRealityControllerMappingProfileInspector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright (c) Microsoft Corporation. All rights reserved.
22
// Licensed under the MIT License. See LICENSE in the project root for license information.
33

4-
using System;
54
using Microsoft.MixedReality.Toolkit.Core.Definitions.Devices;
65
using Microsoft.MixedReality.Toolkit.Core.Definitions.Utilities;
76
using Microsoft.MixedReality.Toolkit.Core.Devices.OpenVR;
@@ -10,6 +9,7 @@
109
using Microsoft.MixedReality.Toolkit.Core.Extensions;
1110
using Microsoft.MixedReality.Toolkit.Core.Interfaces.Devices;
1211
using Microsoft.MixedReality.Toolkit.Core.Managers;
12+
using System;
1313
using System.Collections.Generic;
1414
using System.Linq;
1515
using UnityEditor;

Assets/MixedRealityToolkit/_Core/Inspectors/Profiles/MixedRealityInputSystemProfileInspector.cs

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,22 +46,11 @@ public override void OnInspectorGUI()
4646
return;
4747
}
4848

49-
if (!MixedRealityManager.Instance.ActiveProfile.IsInputSystemEnabled)
49+
if (GUILayout.Button("Back to Configuration Profile"))
5050
{
51-
EditorGUILayout.HelpBox("No input system is enabled, or you need to specify the type in the main configuration profile.", MessageType.Error);
52-
53-
if (GUILayout.Button("Back to Configuration Profile"))
54-
{
55-
Selection.activeObject = MixedRealityManager.Instance.ActiveProfile;
56-
}
57-
58-
return;
51+
Selection.activeObject = MixedRealityManager.Instance.ActiveProfile;
5952
}
6053

61-
if (GUILayout.Button("Back to Input Profile"))
62-
{
63-
Selection.activeObject = MixedRealityManager.Instance.ActiveProfile.InputSystemProfile;
64-
}
6554
EditorGUILayout.Space();
6655
EditorGUILayout.LabelField("Input System Profile", EditorStyles.boldLabel);
6756
EditorGUILayout.HelpBox("The Input System Profile helps developers configure input no matter what platform you're building for.", MessageType.Info);

0 commit comments

Comments
 (0)