Skip to content

Commit 596a532

Browse files
committed
Fix up some test comments, test strings, and make cube smaller so it works on other cameras
1 parent d2e3b7a commit 596a532

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

Assets/MixedRealityToolkit.Tests/PlayModeTests/PointerTests.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,39 +112,40 @@ private IEnumerator TestPointerFieldOfViewHelper(IMixedRealityPointer myPointer,
112112
Assert.IsNotNull(myPointer);
113113
Assert.IsTrue(myPointer.IsInteractionEnabled, "Pointer should be enabled because it is inside giant cube.");
114114

115+
cube.transform.localScale = Vector3.one * 0.1f;
115116
// Move cube in front of camera so it is visible
116117
cube.transform.Translate(Vector3.forward * 1f);
117118
yield return testHand.MoveTo(cube.transform.position);
118119
yield return PlayModeTestUtilities.WaitForInputSystemUpdate();
119-
Assert.IsTrue(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should be enabled because it is near cube and visible.");
120+
Assert.IsTrue(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should be enabled. Cube size {cube.transform.localScale} location {cube.transform.position}.");
120121

121122
// Make cube no longer visible
122123
cube.transform.Translate(Vector3.up * 10);
123124
yield return testHand.MoveTo(cube.transform.position);
124125
yield return PlayModeTestUtilities.WaitForInputSystemUpdate();
125-
Assert.IsFalse(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should NOT be enabled because hand is near object that is not in FOV.");
126+
Assert.IsFalse(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should NOT be enabled, cube not in FOV. Cube size {cube.transform.localScale} location {cube.transform.position}.");
126127

127-
// For sphere and poke pointers, test that setting
128+
// For sphere and poke pointers, test that setting IgnoreCollidersNotInFOV works
128129
if (myPointer is SpherePointer spherePointer)
129130
{
130131
spherePointer.IgnoreCollidersNotInFOV = false;
131132
yield return PlayModeTestUtilities.WaitForInputSystemUpdate();
132-
Assert.IsTrue(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should be enabled.");
133+
Assert.IsTrue(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should be enabled because IgnoreCollidersNotInFOV is false.");
133134
spherePointer.IgnoreCollidersNotInFOV = true;
134135
}
135136
else if (myPointer is PokePointer pokePointer)
136137
{
137138
pokePointer.IgnoreCollidersNotInFOV = false;
138139
yield return PlayModeTestUtilities.WaitForInputSystemUpdate();
139-
Assert.IsTrue(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should be enabled.");
140+
Assert.IsTrue(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should be enabled because IgnoreCollidersNotInFOV is false.");
140141
pokePointer.IgnoreCollidersNotInFOV = true;
141142
}
142143

143144
// Move it back to be visible again
144145
cube.transform.Translate(Vector3.up * -10f);
145146
yield return testHand.MoveTo(cube.transform.position);
146147
yield return PlayModeTestUtilities.WaitForInputSystemUpdate();
147-
Assert.IsTrue(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should be enabled because it is near object inside of FOV.");
148+
Assert.IsTrue(myPointer.IsInteractionEnabled, $"Pointer {myPointer.PointerName} should be enabled because it is near object inside of FOV. Cube size {cube.transform.localScale} location {cube.transform.position}.");
148149
}
149150

150151
/// <summary>

0 commit comments

Comments
 (0)