Skip to content

Commit 5e8ea36

Browse files
author
davidkline-ms
committed
configurator updates and change cleanup
1 parent 4011eeb commit 5e8ea36

File tree

5 files changed

+4
-275
lines changed

5 files changed

+4
-275
lines changed

Assets/MixedRealityToolkit/Inspectors/Setup/MixedRealityProjectConfiguratorWindow.cs

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,6 @@ public class MixedRealityProjectConfiguratorWindow : EditorWindow
1717
{
1818
{ MRConfig.ForceTextSerialization, true },
1919
{ MRConfig.VisibleMetaFiles, true },
20-
#if UNITY_2019_3_OR_NEWER
21-
{ MRConfig.XRManagerEnabled, false },
22-
// XR Manager platforms
23-
{ MRConfig.XRManagerWindows, true },
24-
{ MRConfig.XRManagerOculus, true },
25-
{ MRConfig.XRManagerAndroid, false },
26-
{ MRConfig.XRManageriOS, false },
27-
#endif // UNITY_2019_3_OR_NEWER
2820
{ MRConfig.VirtualRealitySupported, true },
2921
{ MRConfig.SinglePassInstancing, true },
3022
{ MRConfig.SpatialAwarenessLayer, true },
@@ -57,10 +49,6 @@ public class MixedRealityProjectConfiguratorWindow : EditorWindow
5749

5850
private bool showConfigurations = true;
5951

60-
#if UNITY_2019_3_OR_NEWER
61-
private bool showXRManagerPlatforms = true;
62-
#endif // UNITY_2019_3_OR_NEWER
63-
6452
/// <summary>
6553
/// Show the MRTK Project Configurator utility window or focus if already opened
6654
/// </summary>
@@ -152,30 +140,19 @@ private void RenderConfigurations()
152140
EditorGUILayout.LabelField("Project Settings", EditorStyles.boldLabel);
153141
RenderToggle(MRConfig.ForceTextSerialization, "Enable Force Text Serialization");
154142
RenderToggle(MRConfig.VisibleMetaFiles, "Enable Visible meta files");
155-
#if UNITY_2019_3_OR_NEWER
156-
RenderToggle(MRConfig.XRManagerEnabled, "Enable XR Manager");
157-
showXRManagerPlatforms = EditorGUILayout.Foldout(showXRManagerPlatforms, "XR Manager Platforms", true);
158-
if (showXRManagerPlatforms)
159-
{
160-
using (new EditorGUI.IndentLevelScope())
161-
{
162-
RenderToggle(MRConfig.XRManagerWindows, "Windows XR");
163-
RenderToggle(MRConfig.XRManagerOculus, "Oculus XR");
164-
RenderToggle(MRConfig.XRManagerAndroid, "Android ARCore XR");
165-
RenderToggle(MRConfig.XRManageriOS, "iOS ARKit XR");
166-
}
167-
}
168-
#endif // UNITY_2019_3_OR_NEWER
169143
if (!MixedRealityOptimizeUtils.IsBuildTargetAndroid() && !MixedRealityOptimizeUtils.IsBuildTargetIOS())
170144
{
171145
#if UNITY_2019_3_OR_NEWER
172146
RenderToggle(MRConfig.VirtualRealitySupported, "Enable Legacy XR");
173147
#else
174-
175148
RenderToggle(MRConfig.VirtualRealitySupported, "Enable VR Supported");
176149
#endif // UNITY_2019_3_OR_NEWER
177150
}
151+
#if UNITY_2019_3_OR_NEWER
152+
RenderToggle(MRConfig.SinglePassInstancing, "Set Single Pass Instanced rendering path (legacy XR API)");
153+
#else
178154
RenderToggle(MRConfig.SinglePassInstancing, "Set Single Pass Instanced rendering path");
155+
#endif // UNITY_2019_3_OR_NEWER
179156
RenderToggle(MRConfig.SpatialAwarenessLayer, "Set Default Spatial Awareness Layer");
180157
RenderToggle(MRConfig.EnableMSBuildForUnity, "Enable MSBuild for Unity");
181158
EditorGUILayout.Space();

Assets/MixedRealityToolkit/Utilities/Editor/PackageManifest/PackageManifestUpdater.cs

Lines changed: 0 additions & 201 deletions
This file was deleted.

Assets/MixedRealityToolkit/Utilities/Editor/PackageManifest/PackageManifestUpdater.cs.meta

Lines changed: 0 additions & 11 deletions
This file was deleted.

Assets/MixedRealityToolkit/Utilities/Editor/Setup/MixedRealityProjectConfigurator.cs

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,6 @@ public enum Configurations
3333
SinglePassInstancing,
3434
SpatialAwarenessLayer,
3535
EnableMSBuildForUnity,
36-
#if UNITY_2019_3_OR_NEWER
37-
XRManagerEnabled,
38-
// XR Manager platforms
39-
XRManagerWindows,
40-
XRManagerOculus,
41-
XRManagerAndroid,
42-
XRManageriOS,
43-
#endif // UNITY_2019_3_OR_NEWER
4436

4537
// WSA Capabilities
4638
SpatialPerceptionCapability = 1000,
@@ -66,13 +58,6 @@ public enum Configurations
6658
{ Configurations.LatestScriptingRuntime, () => { return IsLatestScriptingRuntime(); } },
6759
{ Configurations.ForceTextSerialization, () => { return IsForceTextSerialization(); } },
6860
{ Configurations.VisibleMetaFiles, () => { return IsVisibleMetaFiles(); } },
69-
#if UNITY_2019_3_OR_NEWER
70-
{ Configurations.XRManagerEnabled, () => { return false; /* todo */ } },
71-
{ Configurations.XRManagerWindows, () => { return false; /* todo */ } },
72-
{ Configurations.XRManagerOculus, () => { return false; /* todo */ } },
73-
{ Configurations.XRManagerAndroid, () => { return false; /* todo */ } },
74-
{ Configurations.XRManageriOS, () => { return false; /* todo */ } },
75-
#endif
7661
// Ensure compatibility with the pre-2019.3 XR architecture for customers / platforms
7762
// with legacy requirements.
7863
#pragma warning disable 0618
@@ -109,13 +94,6 @@ public enum Configurations
10994
{ Configurations.LatestScriptingRuntime, () => { SetLatestScriptingRuntime(); } },
11095
{ Configurations.ForceTextSerialization, () => { SetForceTextSerialization(); } },
11196
{ Configurations.VisibleMetaFiles, () => { SetVisibleMetaFiles(); } },
112-
#if UNITY_2019_3_OR_NEWER
113-
{ Configurations.XRManagerEnabled, () => { /* todo */ } },
114-
{ Configurations.XRManagerWindows, () => { /* todo */ } },
115-
{ Configurations.XRManagerOculus, () => { /* todo */ } },
116-
{ Configurations.XRManagerAndroid, () => { /* todo */ } },
117-
{ Configurations.XRManageriOS, () => { /* todo */ } },
118-
#endif
11997
// Ensure compatibility with the pre-2019.3 XR architecture for customers / platforms
12098
// with legacy requirements.
12199
#pragma warning disable 0618

Assets/MixedRealityToolkit/Utilities/Editor/XRSettingsUtilities.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,7 @@
11
// Copyright (c) Microsoft Corporation.
22
// Licensed under the MIT License.
33

4-
using System.Collections.Generic;
54
using UnityEditor;
6-
using UnityEngine;
7-
8-
#if UNITY_2019_3_OR_NEWER
9-
using UnityEditor.PackageManager;
10-
using UnityEditor.PackageManager.Requests;
11-
using PackageInfo = UnityEditor.PackageManager.PackageInfo;
12-
#endif // UNITY_2019_3_OR_NEWER
13-
14-
#if XR_MANAGEMENT_ENABLED
15-
using System.Threading;
16-
using UnityEngine.XR.Management;
17-
#endif //XR_MANAGEMENT_ENABLED
185

196
namespace Microsoft.MixedReality.Toolkit.Utilities.Editor
207
{
@@ -47,6 +34,5 @@ public static bool LegacyXREnabled
4734
#pragma warning restore 0618
4835
}
4936
}
50-
5137
}
5238
}

0 commit comments

Comments
 (0)