null check pr feedback

Author: David Kline (ANALOG)

Assets/MixedRealityToolkit.Services/BoundarySystem/MixedRealityBoundarySystem.cs

@@ -29,6 +29,11 @@ public MixedRealityBoundarySystem(
             ExperienceScale scale) : base(registrar, profile)
         {
             Scale = scale;
+
+            if (playspace == null)
+            {
+                Debug.LogError("The MixedRealityBoundarySystem object requires a valid playspace Transform.");
+            }
             Playspace = playspace;
         }
 

Assets/MixedRealityToolkit.Services/DiagnosticsSystem/MixedRealityDiagnosticsSystem.cs

@@ -21,6 +21,10 @@ public MixedRealityDiagnosticsSystem(
             MixedRealityDiagnosticsProfile profile,
             Transform playspace) : base(registrar, profile)
         {
+            if (playspace == null)
+            {
+                Debug.LogError("The MixedRealityDiagnosticSystem object requires a valid playspace Transform.");
+            }
             Playspace = playspace;
         }
 

Assets/MixedRealityToolkit.Services/InputSystem/FocusProvider.cs

@@ -942,7 +942,7 @@ public void OnSourceLost(SourceStateEventData eventData)
                 if (gazeProviderPointingData != null && eventData.InputSource.Pointers[i].PointerId == gazeProviderPointingData.Pointer.PointerId)
                 {
                     // If the source lost is the gaze input source, then reset it.
-                    if (eventData.InputSource.SourceId == ((IMixedRealityInputSystem)Service).GazeProvider.GazeInputSource.SourceId)
+                    if (eventData.InputSource.SourceId == ((IMixedRealityInputSystem)Service).GazeProvider?.GazeInputSource.SourceId)
                     {
                         gazeProviderPointingData.ResetFocusedObjects();
                         gazeProviderPointingData = null;

Assets/MixedRealityToolkit.Services/InputSystem/MixedRealityInputSystem.cs

@@ -30,6 +30,15 @@ public MixedRealityInputSystem(
             MixedRealityInputSystemProfile profile,
             Transform playspace) : base(registrar, profile)
         {
+            if (registrar == null)
+            {
+                Debug.LogError("The MixedRealityInputSystem object requires a valid IMixedRealityServiceRegistrar instance.");
+            }
+
+            if (playspace == null)
+            {
+                Debug.LogError("The MixedRealityInputSystem object requires a valid playspace Transform.");
+            }
             Playspace = playspace;
         }
 

Assets/MixedRealityToolkit.Services/SpatialAwarenessSystem/MixedRealitySpatialAwarenessSystem.cs

@@ -20,7 +20,12 @@ namespace Microsoft.MixedReality.Toolkit.Services.SpatialAwarenessSystem
     public class MixedRealitySpatialAwarenessSystem : BaseCoreSystem, IMixedRealitySpatialAwarenessSystem
     {
         public MixedRealitySpatialAwarenessSystem(IMixedRealityServiceRegistrar registrar) : base(registrar, null) // spatial awareness does not yet use a profile
-        { }
+        {
+            if (registrar == null)
+            {
+                Debug.LogError("The MixedRealitySpatialAwarenessSystem object requires a valid IMixedRealityServiceRegistrar instance.");
+            }
+        }
 
         #region IMixedRealityToolkit Implementation
 

Assets/MixedRealityToolkit.Services/TeleportSystem/MixedRealityTeleportSystem.cs

@@ -21,8 +21,18 @@ public MixedRealityTeleportSystem(
             IMixedRealityServiceRegistrar registrar,
             Transform playspace) : base(registrar, null) // Teleport system does not use a profile
         {
-            Playspace = playspace;
+            if (registrar == null)
+            {
+                Debug.LogError("The MixedRealityTeleportSystem object requires a valid IMixedRealityServiceRegistrar instance.");
+            }
             IsInputSystemEnabled = (registrar.GetService<IMixedRealityInputSystem>(showLogs: false) != null);
+
+            if (playspace == null)
+            {
+                Debug.LogError("The MixedRealityTeleportSystem object requires a valid playspace Transform.");
+            }
+
+            Playspace = playspace;
         } 
 
         private TeleportEventData teleportEventData;