Removed WatchForThemeChange variable and checks so that widgets always check for theme updates by default. The performance hit seems minimal and the functionality is valuable enough to promote it to the default behavior.

Author: killerantz

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Controls/ButtonThemeWidget.cs

@@ -31,9 +31,6 @@ public class ButtonThemeWidget : InteractiveThemeWidget
         [Tooltip("scale animation component: optional")]
         public ScaleToValue ScaleSize;
 
-        [Tooltip("Upate the widget's theme and refresh if the theme tag changes")]
-        public bool WatchForThemeChange = false;
-
         // themes
         private ColorInteractiveTheme mColorTheme;
         private Vector3InteractiveTheme mPositionTheme;
@@ -150,7 +147,7 @@ public override void SetState(Interactive.ButtonStateEnum state)
 
         private void Update()
         {
-            if(WatchForThemeChange && (!mCheckScaleThemeTag.Equals(ScaleThemeTag) || !mCheckPositionThemeTag.Equals(PositionThemeTag) || !mCheckColorThemeTag.Equals(ColorThemeTag)))
+            if(!mCheckScaleThemeTag.Equals(ScaleThemeTag) || !mCheckPositionThemeTag.Equals(PositionThemeTag) || !mCheckColorThemeTag.Equals(ColorThemeTag))
             {
                 SetTheme();
                 RefreshIfNeeded();

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Controls/ButtonThemeWidgetLabel.cs

@@ -25,9 +25,6 @@ public class ButtonThemeWidgetLabel : InteractiveThemeWidget
         [Tooltip("position animation component: optional")]
         public MoveToPosition MovePosition;
 
-        [Tooltip("Upate the widget's theme and refresh if the theme tag changes")]
-        public bool WatchForThemeChange = false;
-
         // themes
         private ColorInteractiveTheme mColorTheme;
         private Vector3InteractiveTheme mPositionTheme;
@@ -123,7 +120,7 @@ public override void SetState(Interactive.ButtonStateEnum state)
 
         private void Update()
         {
-            if (WatchForThemeChange && (!mCheckPositionThemeTag.Equals(PositionThemeTag) || !mCheckColorThemeTag.Equals(ColorThemeTag)))
+            if (!mCheckPositionThemeTag.Equals(PositionThemeTag) || !mCheckColorThemeTag.Equals(ColorThemeTag))
             {
                 SetTheme();
                 RefreshIfNeeded();

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Controls/ButtonThemeWidgetOutline.cs

@@ -29,9 +29,6 @@ public class ButtonThemeWidgetOutline : InteractiveThemeWidget
         [Tooltip("A color tween component : required, but could be on a different object")]
         public ColorTransition ColorBlender;
 
-        [Tooltip("Upate the widget's theme and refresh if the theme tag changes")]
-        public bool WatchForThemeChange = false;
-
         private ColorInteractiveTheme mInnerColorTheme;
         private ColorInteractiveTheme mOuterColorTheme;
 
@@ -100,7 +97,7 @@ public override void SetState(Interactive.ButtonStateEnum state)
 
         private void Update()
         {
-            if (WatchForThemeChange && (!mCheckOuterColorThemeTag.Equals(OuterColorThemeTag) || !mCheckInnerColorThemeTag.Equals(InnerColorThemeTag)))
+            if (!mCheckOuterColorThemeTag.Equals(OuterColorThemeTag) || !mCheckInnerColorThemeTag.Equals(InnerColorThemeTag))
             {
                 SetTheme();
                 RefreshIfNeeded();

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Controls/SliderGestureControl.cs

@@ -151,7 +151,6 @@ public override void ManipulationUpdate(Vector3 startGesturePosition, Vector3 cu
 
             // get the current delta
             float delta =  (CurrentDistance > 0) ? CurrentPercentage : -CurrentPercentage;
-            print(delta);
 
             // combine the delta with the current slider position so the slider does not start over every time
             mDeltaValue = Mathf.Clamp01(delta + mCachedValue);

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Widgets/MaterialColorThemeWidget.cs

@@ -20,9 +20,6 @@ public class MaterialColorThemeWidget : InteractiveThemeWidget
         [Tooltip("A component for color transitions: optional")]
         public ColorTransition ColorBlender;
 
-        [Tooltip("Upate the widget's theme and refresh if the theme tag changes")]
-        public bool WatchForThemeChange = false;
-
         private ColorInteractiveTheme mColorTheme;
         private Material mMaterial;
 
@@ -88,7 +85,7 @@ public override void SetState(Interactive.ButtonStateEnum state)
 
         private void Update()
         {
-            if (WatchForThemeChange && (!mCheckThemeTag.Equals(ThemeTag)))
+            if (!mCheckThemeTag.Equals(ThemeTag))
             {
                 SetTheme();
                 RefreshIfNeeded();

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Widgets/PositionThemeWidget.cs

@@ -19,9 +19,6 @@ public class PositionThemeWidget : InteractiveThemeWidget
         [Tooltip("Move to Position, a component for animating position")]
         public MoveToPosition MovePositionTweener;
 
-        [Tooltip("Upate the widget's theme and refresh if the theme tag changes")]
-        public bool WatchForThemeChange = false;
-
         private Vector3InteractiveTheme mPositionTheme;
 
         private string mCheckThemeTag = "";
@@ -80,7 +77,7 @@ public override void SetState(Interactive.ButtonStateEnum state)
 
         private void Update()
         {
-            if (WatchForThemeChange && (!mCheckThemeTag.Equals(ThemeTag)))
+            if (!mCheckThemeTag.Equals(ThemeTag))
             {
                 SetTheme();
                 RefreshIfNeeded();

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Widgets/ScaleThemeWidget.cs

@@ -19,9 +19,6 @@ public class ScaleThemeWidget : InteractiveThemeWidget
         [Tooltip("Scale to Value component for animating scale")]
         public ScaleToValue ScaleTweener;
 
-        [Tooltip("Upate the widget's theme and refresh if the theme tag changes")]
-        public bool WatchForThemeChange = false;
-
         private Vector3InteractiveTheme mScaleTheme;
         private Material mMaterial;
 
@@ -81,7 +78,7 @@ public override void SetState(Interactive.ButtonStateEnum state)
 
         private void Update()
         {
-            if (WatchForThemeChange && (!mCheckThemeTag.Equals(ThemeTag)))
+            if (!mCheckThemeTag.Equals(ThemeTag))
             {
                 SetTheme();
                 RefreshIfNeeded();

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Widgets/TextMeshColorThemeWidget.cs

@@ -20,9 +20,6 @@ public class TextMeshColorThemeWidget : InteractiveThemeWidget
         [Tooltip("A component for color transitions: optional")]
         public ColorTransition ColorBlender;
 
-        [Tooltip("Upate the widget's theme and refresh if the theme tag changes")]
-        public bool WatchForThemeChange = false;
-
         private ColorInteractiveTheme mTextColorTheme;
         private TextMesh mTextMesh;
 
@@ -82,7 +79,7 @@ public override void SetState(Interactive.ButtonStateEnum state)
 
         private void Update()
         {
-            if (WatchForThemeChange && (!mCheckThemeTag.Equals(ThemeTag)))
+            if (!mCheckThemeTag.Equals(ThemeTag))
             {
                 SetTheme();
                 RefreshIfNeeded();

Assets/HoloToolkit-Examples/InteractiveElements/Scripts/Widgets/TextureThemeWidget.cs

@@ -19,9 +19,6 @@ public class TextureThemeWidget : InteractiveThemeWidget
         [Tooltip("The target object with the material to swap textures on : optional, leave blank for self")]
         public GameObject Target;
 
-        [Tooltip("Upate the widget's theme and refresh if the theme tag changes")]
-        public bool WatchForThemeChange = false;
-
         // The theme with the texture states
         private TextureInteractiveTheme mTextureTheme;
 
@@ -100,7 +97,7 @@ private void SetTexture(Interactive.ButtonStateEnum state)
 
         private void Update()
         {
-            if(WatchForThemeChange && (!mCheckThemeTag.Equals(ThemeTag)))
+            if(!mCheckThemeTag.Equals(ThemeTag))
             {
                 SetTheme();
                 RefreshIfNeeded();