Skip to content

Commit 70b6428

Browse files
author
Andrei Borodin
committed
Latest
2 parents 54c806c + 74f238f commit 70b6428

File tree

45 files changed

+295
-74
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+295
-74
lines changed

.github/pull_request_template.md

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,22 @@
1-
Overview
2-
---
1+
## Overview
32

43

5-
Changes
6-
---
4+
## Changes
75
- Fixes: # .
6+
7+
8+
## Verification
9+
> This optional section is a place where you can detail the specific type of verification
10+
> you want from reviewers. For example, if you want reviewers to checkout the PR locally
11+
> and validate the functionality of specific scenarios, provide instructions
12+
> on the specific scenarios and what you want verified.
13+
>
14+
> If there are specific areas of concern or question feel free to highlight them here so
15+
> that reviewers can watch out for those issues.
16+
>
17+
> As a reviewer, it is possible to check out this change locally by using the following
18+
> commands (substituting {PR_ID} with the ID of this pull request):
19+
>
20+
> git fetch origin pull/{PR_ID}/head:name_of_local_branch
21+
>
22+
> git checkout name_of_local_branch

Assets/MixedRealityToolkit.Examples/Demos/Audio/Scripts/LoFiFilterSelection.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,11 @@ public void OnPointerClicked(MixedRealityPointerEventData eventData)
8484
public void OnPointerDown(MixedRealityPointerEventData eventData)
8585
{ }
8686

87+
/// <summary>
88+
/// This script does not handle pointer dragged events.
89+
/// </summary>
90+
public void OnPointerDragged(MixedRealityPointerEventData eventData) { }
91+
8792
/// <summary>
8893
/// This script does not handle pointer up events.
8994
/// </summary>

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_BasicSetup/Scripts/ColorTap.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ void IMixedRealityPointerHandler.OnPointerDown(MixedRealityPointerEventData even
5353
}
5454
}
5555

56+
void IMixedRealityPointerHandler.OnPointerDragged(MixedRealityPointerEventData eventData) { }
57+
5658
void IMixedRealityPointerHandler.OnPointerClicked(MixedRealityPointerEventData eventData) { }
5759
}
5860
}

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_ScrollPanZoom/Scripts/BaseClasses/PanZoomBase.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -547,6 +547,8 @@ void IMixedRealityPointerHandler.OnPointerDown(MixedRealityPointerEventData even
547547
isZooming = true;
548548
}
549549

550+
void IMixedRealityPointerHandler.OnPointerDragged(MixedRealityPointerEventData eventData) { }
551+
550552
void IMixedRealityPointerHandler.OnPointerClicked(MixedRealityPointerEventData eventData) { }
551553

552554
void IMixedRealityFocusHandler.OnFocusEnter(FocusEventData eventData)

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_TargetPositioning/Scripts/GrabReleaseDetector.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ void IMixedRealityPointerHandler.OnPointerDown(MixedRealityPointerEventData even
2323
OnGrab.Invoke();
2424
}
2525

26+
void IMixedRealityPointerHandler.OnPointerDragged(MixedRealityPointerEventData eventData) { }
27+
2628
void IMixedRealityPointerHandler.OnPointerUp(MixedRealityPointerEventData eventData)
2729
{
2830
Debug.Log("OnRelease");

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_TargetPositioning/Scripts/MoveObjByEyeGaze.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,8 @@ void IMixedRealityPointerHandler.OnPointerDown(MixedRealityPointerEventData even
304304
}
305305
}
306306

307+
void IMixedRealityPointerHandler.OnPointerDragged(MixedRealityPointerEventData eventData) { }
308+
307309
void IMixedRealityPointerHandler.OnPointerClicked(MixedRealityPointerEventData eventData) { }
308310
#endregion
309311

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_TargetSelections/Scripts/TargetGroupIterator.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,8 @@ void IMixedRealityPointerHandler.OnPointerUp(MixedRealityPointerEventData eventD
302302

303303
void IMixedRealityPointerHandler.OnPointerDown(MixedRealityPointerEventData eventData) { }
304304

305+
void IMixedRealityPointerHandler.OnPointerDragged(MixedRealityPointerEventData eventData) { }
306+
305307
void IMixedRealityPointerHandler.OnPointerClicked(MixedRealityPointerEventData eventData)
306308
{
307309
if (eventData.MixedRealityInputAction == selectAction)

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_Visualizer/Scripts/OnSelect_VisualizerInputController.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ void IMixedRealityPointerHandler.OnPointerClicked(MixedRealityPointerEventData e
3535

3636
void IMixedRealityPointerHandler.OnPointerDown(MixedRealityPointerEventData eventData) { }
3737

38+
void IMixedRealityPointerHandler.OnPointerDragged(MixedRealityPointerEventData eventData) { }
39+
3840
void IMixedRealityPointerHandler.OnPointerUp(MixedRealityPointerEventData eventData) { }
3941
}
4042
}

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/General/Profiles/EyeTrackingDemoInputSimulationProfile.asset

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ MonoBehaviour:
2626
moveVertical: Vertical
2727
mouseX: Mouse X
2828
mouseY: Mouse Y
29-
lookHorizontal: LookHorizontal
30-
lookVertical: LookVertical
29+
lookHorizontal: AXIS_4
30+
lookVertical: AXIS_5
3131
simulateEyePosition: 1
3232
handSimulationMode: 2
3333
toggleLeftHandKey: 116

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/General/Scripts/Targeting/DwellSelection.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,8 @@ void IMixedRealityPointerHandler.OnPointerDown(MixedRealityPointerEventData even
279279
{
280280
}
281281

282+
void IMixedRealityPointerHandler.OnPointerDragged(MixedRealityPointerEventData eventData) { }
283+
282284
void IMixedRealityPointerHandler.OnPointerClicked(MixedRealityPointerEventData eventData)
283285
{
284286
ResetDwellFeedback();

0 commit comments

Comments
 (0)