[2.8.1] Fix null ref in WindowsMixedRealityXRSDKArticulatedHand (#10622)

* Fix null ref in WindowsMixedRealityXRSDKArticulatedHand

* Update to 2.8.1

Author: keveleigh

Assets/MRTK/Providers/WindowsMixedReality/XRSDK/Controllers/WindowsMixedRealityXRSDKArticulatedHand.cs

@@ -47,7 +47,7 @@ public WindowsMixedRealityXRSDKArticulatedHand(
         private readonly ArticulatedHandDefinition handDefinition;
         private readonly WindowsMixedRealityHandMeshProvider handMeshProvider;
 
-        private readonly MixedRealityPose[] unityJointPoses = null;
+        private MixedRealityPose[] jointPoses = null;
 
         private static readonly HandFinger[] handFingers = Enum.GetValues(typeof(HandFinger)) as HandFinger[];
         private readonly List<Bone> fingerBones = new List<Bone>();
@@ -66,9 +66,9 @@ public WindowsMixedRealityXRSDKArticulatedHand(
         /// <inheritdoc/>
         public bool TryGetJoint(TrackedHandJoint joint, out MixedRealityPose pose)
         {
-            if (unityJointPoses != null)
+            if (jointPoses != null)
             {
-                pose = unityJointPoses[(int)joint];
+                pose = jointPoses[(int)joint];
                 return pose != default(MixedRealityPose);
             }
 
@@ -136,6 +136,11 @@ private void UpdateHandData(InputDevice inputDevice)
 
                 if (inputDevice.TryGetFeatureValue(CommonUsages.handData, out Hand hand))
                 {
+                    if (jointPoses == null)
+                    {
+                        jointPoses = new MixedRealityPose[ArticulatedHandPose.JointCount];
+                    }
+
                     foreach (HandFinger finger in handFingers)
                     {
                         if (hand.TryGetFingerBones(finger, fingerBones))
@@ -157,18 +162,18 @@ private void UpdateHandData(InputDevice inputDevice)
                                     position = MixedRealityPlayspace.TransformPoint(position);
                                     rotation = MixedRealityPlayspace.Rotation * rotation;
 
-                                    unityJointPoses[ConvertToArrayIndex(finger, i)] = new MixedRealityPose(position, rotation);
+                                    jointPoses[ConvertToArrayIndex(finger, i)] = new MixedRealityPose(position, rotation);
                                 }
                             }
 
                             // Unity doesn't provide a palm joint, so we synthesize one here
                             MixedRealityPose palmPose = CurrentControllerPose;
                             palmPose.Rotation *= (ControllerHandedness == Handedness.Left ? leftPalmOffset : rightPalmOffset);
-                            unityJointPoses[(int)TrackedHandJoint.Palm] = palmPose;
+                            jointPoses[(int)TrackedHandJoint.Palm] = palmPose;
                         }
                     }
 
-                    handDefinition?.UpdateHandJoints(unityJointPoses);
+                    handDefinition?.UpdateHandJoints(jointPoses);
                 }
             }
         }

Assets/MRTK/Tests/EditModeTests/Core/Utilities/BuildAndDeploy/UwpAppxBuildToolsTest.cs

@@ -26,7 +26,7 @@ class UwpAppxBuildToolsTest
                      xmlns:mobile='http://schemas.microsoft.com/appx/manifest/mobile/windows10'
                      IgnorableNamespaces='uap uap2 uap3 uap4 mp mobile iot'
                      xmlns='http://schemas.microsoft.com/appx/manifest/foundation/windows10'>
-              <Identity Name='Microsoft.MixedReality.Toolkit' Publisher='CN=Microsoft' Version='2.8.0.0' />
+              <Identity Name='Microsoft.MixedReality.Toolkit' Publisher='CN=Microsoft' Version='2.8.1.0' />
               <mp:PhoneIdentity PhoneProductId='85c8bcd4-fbac-44ed-adf6-bfc01242a27f' PhonePublisherId='00000000-0000-0000-0000-000000000000' />
               <Properties>
                 <DisplayName>MixedRealityToolkit</DisplayName>

ProjectSettings/ProjectSettings.asset

@@ -121,7 +121,7 @@ PlayerSettings:
     16:10: 1
     16:9: 1
     Others: 1
-  bundleVersion: 2.8.0
+  bundleVersion: 2.8.1
   preloadedAssets: []
   metroInputSource: 0
   wsaTransparentSwapchain: 0
@@ -700,7 +700,7 @@ PlayerSettings:
   m_RenderingPath: 1
   m_MobileRenderingPath: 1
   metroPackageName: Microsoft.MixedReality.Toolkit
-  metroPackageVersion: 2.8.0.0
+  metroPackageVersion: 2.8.1.0
   metroCertificatePath: Assets/WSATestCertificate.pfx
   metroCertificatePassword: 
   metroCertificateSubject: Microsoft

pipelines/config/settings.yml

@@ -12,7 +12,7 @@ variables:
   # match (see scripts/packaging/versionmetadata.ps1)
   # ProjectSettings/ProjectSettings.asset:  bundleVersion: x.x.x
   # ProjectSettings/ProjectSettings.asset:  metroPackageVersion: x.x.x.0
-  MRTKVersion: 2.8.0
+  MRTKVersion: 2.8.1
   MRTKReleaseTag: ''  # final version component, e.g. 'RC2.1' or empty string
   ToolsRepoName: mixedrealitytoolkit.build
   ToolsDir: $(Build.SourcesDirectory)\$(ToolsRepoName)