Skip to content

Commit 75bb9ab

Browse files
removed link renderer caching as we only need them for updating visibility or flattening
1 parent 7e14773 commit 75bb9ab

File tree

1 file changed

+10
-7
lines changed
  • Assets/MixedRealityToolkit.SDK/Experimental/Features/UX/BoundsControl/Visuals

1 file changed

+10
-7
lines changed

Assets/MixedRealityToolkit.SDK/Experimental/Features/UX/BoundsControl/Visuals/Links.cs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ public Link(Transform linkTransform, CardinalAxisType linkAxis)
2626
}
2727

2828
private List<Link> links = new List<Link>();
29-
private List<Renderer> linkRenderers = new List<Renderer>();
3029

3130
private LinksConfiguration config;
3231

@@ -63,11 +62,12 @@ internal void ResetVisibility(bool isVisible)
6362
{
6463
if (links != null)
6564
{
66-
for (int i = 0; i < linkRenderers.Count; ++i)
65+
for (int i = 0; i < links.Count; ++i)
6766
{
68-
if (linkRenderers[i] != null)
67+
Renderer linkRenderer = links[i].transform.gameObject.GetComponent<Renderer>();
68+
if (linkRenderer != null)
6969
{
70-
linkRenderers[i].enabled = isVisible;
70+
linkRenderer.enabled = isVisible;
7171
}
7272
}
7373
}
@@ -122,11 +122,15 @@ internal void UpdateLinkScales(Vector3 currentBoundsExtents)
122122

123123
internal void Flatten(ref int[] flattenedHandles)
124124
{
125-
if (flattenedHandles != null && linkRenderers != null)
125+
if (flattenedHandles != null)
126126
{
127127
for (int i = 0; i < flattenedHandles.Length; ++i)
128128
{
129-
linkRenderers[flattenedHandles[i]].enabled = false;
129+
Renderer linkRenderer = links[flattenedHandles[i]].transform.gameObject.GetComponent<Renderer>();
130+
if (linkRenderer)
131+
{
132+
linkRenderer.enabled = false;
133+
}
130134
}
131135
}
132136
}
@@ -173,7 +177,6 @@ internal void CreateLinks(RotationHandles rotationHandles, Transform parent, Vec
173177
link.transform.position = rotationHandles.GetEdgeCenter(i);
174178
link.transform.parent = parent;
175179
Renderer linkRenderer = link.GetComponent<Renderer>();
176-
linkRenderers.Add(linkRenderer);
177180

178181
if (config.WireframeMaterial != null)
179182
{

0 commit comments

Comments
 (0)