Add PR validation for AssemblyInfo.cs

Author: keveleigh

scripts/ci/common.psm1

@@ -107,4 +107,20 @@ function IsMetaFile {
     process {
         [IO.Path]::GetExtension($Filename).ToLower() -eq ".meta"
     }
-}
+}
+
+<#
+.SYNOPSIS
+    Returns true if the given file is a Unity asmdef file and
+    false otherwise. Uses the extension of the file, not the actual
+    content to determine this.
+#>
+function IsAsmDef {
+    [CmdletBinding()]
+    param(
+        [string]$Filename
+    )
+    process {
+        [IO.Path]::GetExtension($Filename).ToLower() -eq ".asmdef"
+    }
+}

scripts/ci/validatecode.ps1

@@ -274,6 +274,25 @@ function CheckForActualFile {
     }
 }
 
+<#
+.SYNOPSIS
+    Checks if all assembly definitions have a corresponding AssemblyInfo.cs checked in.
+    Returns true if the AssemblyInfo is missing.
+#>
+function CheckForAssemblyInfo {
+    [CmdletBinding()]
+    param(
+        [string]$FileName
+    )
+    process {
+        if (-not (Test-Path (Join-Path -Path (Split-Path $FileName) -ChildPath "AssemblyInfo.cs"))) {
+            Write-Warning "AssemblyInfo.cs missing for $FileName. Please be sure to check it in alongside this asmdef."
+            $true;
+        }
+        $false;
+    }
+}
+
 function CheckScript {
     [CmdletBinding()]
     param(
@@ -346,9 +365,9 @@ function CheckUnityScene {
         [string]$FileName
     )
     process {
-        # Checks if there is more than one MixedRealityPlayspace objects in each example unity scene
         $containsIssue = $false
 
+        # Checks if there is more than one MixedRealityPlayspace objects in each example unity scene
         $MatchesPlayspaces = Select-String MixedRealityPlayspace $FileName -AllMatches
         $NumPlayspaces = $MatchesPlayspaces.Matches.Count
 
@@ -369,6 +388,22 @@ function CheckUnityScene {
     }
 }
 
+function CheckAssemblyDefinition {
+    [CmdletBinding()]
+    param(
+        [string]$FileName
+    )
+    process {
+        $containsIssue = $false
+
+        if (CheckForAssemblyInfo $FileName) {
+            $containsIssue = $true
+        }
+
+        $containsIssue
+    }
+}
+
 # If the file containing the list of changes was provided and actually exists,
 # this validation should scope to only those changed files.
 if ($ChangesFile -and (Test-Path $ChangesFile -PathType leaf)) {
@@ -383,7 +418,8 @@ if ($ChangesFile -and (Test-Path $ChangesFile -PathType leaf)) {
         if (((IsCSharpFile -Filename $changedFile) -and (CheckScript $changedFile)) -or
             ((IsAssetFile -Filename $changedFile) -and (CheckAsset $changedFile)) -or
             ((IsUnityScene -Filename $changedFile) -and (CheckUnityScene $changedFile)) -or
-            ((IsMetaFile -Filename $changedFile) -and (CheckForActualFile $changedFile))) {
+            ((IsMetaFile -Filename $changedFile) -and (CheckForActualFile $changedFile)) -or 
+            ((IsAsmDef -Filename $changedFile) -and (CheckAssemblyDefinition $changedFile))) {
             $containsIssue = $true;
         }
     }
@@ -420,6 +456,13 @@ else {
             $containsIssue = $true
         }
     }
+
+    $asmdefs = Get-ChildItem $Directory *.asmdef -File -Recurse | Select-Object FullName
+    foreach ($asmdef in $asmdefs) {
+        if (CheckAssemblyDefinition $asmdef.FullName) {
+            $containsIssue = $true
+        }
+    }
 }
 
 $folders = Get-ChildItem $Directory -Directory -Recurse | Select-Object FullName