Correctly crops icons when generating them

Author: Stephen Hodgson

Assets/HoloToolkit/Utilities/Scripts/Editor/SetIconsWindow.cs

@@ -272,13 +272,19 @@ private static string CloneAndResizeToFile(PlayerSettings.WSAImageType type, Pla
 
                 // Resize clone to desired size
                 TextureScale.Bilinear(clone, (int)iconSize.x, (int)iconSize.y);
-                clone.Compress(true);
-                AssetDatabase.SaveAssets();
 
-                if (clone.GetRawTextureData().Length > 204800)
+                // Crop
+                Color[] pix = clone.GetPixels(0, 0, (int)iconSize.x, (int)iconSize.y);
+                clone = new Texture2D((int)iconSize.x, (int)iconSize.y, TextureFormat.ARGB32, false);
+                clone.SetPixels(pix);
+                clone.Apply();
+
+                var rawData = clone.EncodeToPNG();
+                File.WriteAllBytes(filePath, rawData);
+
+                if (rawData.Length > 204800)
                 {
                     Debug.LogWarningFormat("{0} exceeds the minimum file size of 204,800 bytes, please use a smaller image for generating your icons.", clone.name);
-                    return string.Empty;
                 }
             }
             catch (Exception e)

Assets/HoloToolkit/Utilities/Scripts/Editor/TextureScale.cs

@@ -1,5 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
+// See http://wiki.unity3d.com/index.php/TextureScale
 
 using System.Threading;
 using UnityEngine;
@@ -107,7 +108,7 @@ private static void ThreadedScale(Texture2D tex, int newWidth, int newHeight, bo
                 }
             }
 
-            tex.Resize(newWidth, newHeight, TextureFormat.RGB24, false);
+            tex.Resize(newWidth, newHeight, TextureFormat.ARGB32, false);
             tex.SetPixels(newColors);
             tex.Apply();