MixedRealityPlacespace accessor returns Transform now

Ecnassianer · Ecnassianer · commit 7f754ff27b3b · 2018-09-12T16:06:55.000-07:00
diff --git a/Assets/MixedRealityToolkit-Examples/Demos/Boundary/Scripts/BoundaryVisualizationDemo.cs b/Assets/MixedRealityToolkit-Examples/Demos/Boundary/Scripts/BoundaryVisualizationDemo.cs
@@ -44,7 +44,7 @@ private void Awake()
         {
             markerParent = new GameObject();
             markerParent.name = "Boundary Demo Markers";
-            markerParent.transform.parent = MixedRealityManager.Instance.MixedRealityPlayspace.transform;
+            markerParent.transform.parent = MixedRealityManager.Instance.MixedRealityPlayspace;
         }
 
         private void Start()
diff --git a/Assets/MixedRealityToolkit-SDK/Features/Boundary/MixedRealityBoundaryManager.cs b/Assets/MixedRealityToolkit-SDK/Features/Boundary/MixedRealityBoundaryManager.cs
@@ -189,7 +189,7 @@ public override void Destroy()
         private GameObject CreateBoundaryVisualizationParent()
         {
             GameObject visualizationParent = new GameObject("Boundary System Visualizations");
-            visualizationParent.transform.parent = MixedRealityManager.Instance.MixedRealityPlayspace.transform;
+            visualizationParent.transform.parent = MixedRealityManager.Instance.MixedRealityPlayspace;
 
             return visualizationParent;
         }
@@ -456,7 +456,7 @@ public bool Contains(Vector3 location, Boundary.Type boundaryType = Boundary.Typ
             }
 
             // Handle the user teleporting (boundary moves with them).
-            location = MixedRealityManager.Instance.MixedRealityPlayspace.transform.InverseTransformPoint(location);
+            location = MixedRealityManager.Instance.MixedRealityPlayspace.InverseTransformPoint(location);
 
             if (FloorHeight.Value > location.y ||
                 BoundaryHeight < location.y)
@@ -499,7 +499,7 @@ public bool TryGetRectangularBoundsParams(out Vector2 center, out float angle, o
             }
 
             // Handle the user teleporting (boundary moves with them).
-            Vector3 transformedCenter = MixedRealityManager.Instance.MixedRealityPlayspace.transform.TransformPoint(
+            Vector3 transformedCenter = MixedRealityManager.Instance.MixedRealityPlayspace.TransformPoint(
                 new Vector3(rectangularBounds.Center.x, 0f, rectangularBounds.Center.y));
 
             center = new Vector2(transformedCenter.x, transformedCenter.z);
@@ -530,9 +530,9 @@ public GameObject GetFloorVisualization()
             currentFloorObject.name = "Boundary System Floor";
             currentFloorObject.transform.localScale = new Vector3(floorScale.x, boundaryObjectThickness, floorScale.y);
             currentFloorObject.transform.Translate(new Vector3(
-                MixedRealityManager.Instance.MixedRealityPlayspace.transform.position.x, 
+                MixedRealityManager.Instance.MixedRealityPlayspace.position.x, 
                 FloorHeight.Value - (currentFloorObject.transform.localScale.y * 0.5f), 
-                MixedRealityManager.Instance.MixedRealityPlayspace.transform.position.z));
+                MixedRealityManager.Instance.MixedRealityPlayspace.position.z));
             currentFloorObject.GetComponent<Renderer>().sharedMaterial = MixedRealityManager.Instance.ActiveProfile.BoundaryVisualizationProfile.FloorMaterial;
 
             return currentFloorObject;
@@ -606,9 +606,9 @@ public GameObject GetTrackedAreaVisualization()
             currentTrackedAreaObject.layer = ignoreRaycastLayerValue;
             currentTrackedAreaObject.AddComponent<LineRenderer>();
             currentTrackedAreaObject.transform.Translate(new Vector3(
-                MixedRealityManager.Instance.MixedRealityPlayspace.transform.position.x,
+                MixedRealityManager.Instance.MixedRealityPlayspace.position.x,
                 boundaryObjectRenderOffset,
-                MixedRealityManager.Instance.MixedRealityPlayspace.transform.position.z));
+                MixedRealityManager.Instance.MixedRealityPlayspace.position.z));
 
             // Configure the renderer properties.
             float lineWidth = 0.01f;
diff --git a/Assets/MixedRealityToolkit-SDK/Features/Teleportation/MixedRealityTeleportManager.cs b/Assets/MixedRealityToolkit-SDK/Features/Teleportation/MixedRealityTeleportManager.cs
@@ -238,7 +238,7 @@ private void ProcessTeleportationRequest(TeleportEventData eventData)
         {
             isProcessingTeleportRequest = true;
 
-            var cameraParent = MixedRealityManager.Instance.MixedRealityPlayspace.transform;
+            var cameraParent = MixedRealityManager.Instance.MixedRealityPlayspace;
 
             targetRotation = Vector3.zero;
             targetRotation.y = eventData.Pointer.PointerOrientation;
diff --git a/Assets/MixedRealityToolkit-SDK/Features/UX/Scripts/Pointers/TeleportPointer.cs b/Assets/MixedRealityToolkit-SDK/Features/UX/Scripts/Pointers/TeleportPointer.cs
@@ -303,7 +303,7 @@ public override void OnPositionInputChanged(InputEventData<Vector2> eventData)
                             {
                                 canMove = false;
                                 // Rotate the camera by the rotation amount.  If our angle is positive then rotate in the positive direction, otherwise in the opposite direction.
-                                MixedRealityManager.Instance.MixedRealityPlayspace.transform.RotateAround(CameraCache.Main.transform.position, Vector3.up, angle >= 0.0f ? rotationAmount : -rotationAmount);
+                                MixedRealityManager.Instance.MixedRealityPlayspace.RotateAround(CameraCache.Main.transform.position, Vector3.up, angle >= 0.0f ? rotationAmount : -rotationAmount);
                             }
                             else // We may be trying to strafe backwards.
                             {
@@ -317,10 +317,10 @@ public override void OnPositionInputChanged(InputEventData<Vector2> eventData)
                                 if (offsetStrafeAngle > 0 && offsetStrafeAngle < backStrafeActivationAngle)
                                 {
                                     canMove = false;
-                                    var height = MixedRealityManager.Instance.MixedRealityPlayspace.transform.position.y;
-                                    var newPosition = -CameraCache.Main.transform.forward * strafeAmount + MixedRealityManager.Instance.MixedRealityPlayspace.transform.position;
+                                    var height = MixedRealityManager.Instance.MixedRealityPlayspace.position.y;
+                                    var newPosition = -CameraCache.Main.transform.forward * strafeAmount + MixedRealityManager.Instance.MixedRealityPlayspace.position;
                                     newPosition.y = height;
-                                    MixedRealityManager.Instance.MixedRealityPlayspace.transform.position = newPosition;
+                                    MixedRealityManager.Instance.MixedRealityPlayspace.position = newPosition;
                                 }
                             }
                         }
diff --git a/Assets/MixedRealityToolkit/_Core/Devices/BaseController.cs b/Assets/MixedRealityToolkit/_Core/Devices/BaseController.cs
@@ -203,7 +203,7 @@ private void TryRenderControllerModel(Type controllerType)
             // If we've got a controller model prefab, then place it in the scene.
             if (controllerModel != null)
             {
-                var controllerObject = UnityEngine.Object.Instantiate(controllerModel, MixedRealityManager.Instance.MixedRealityPlayspace.transform);
+                var controllerObject = UnityEngine.Object.Instantiate(controllerModel, MixedRealityManager.Instance.MixedRealityPlayspace);
                 controllerObject.name = $"{ControllerHandedness}_{controllerObject.name}";
                 var poseSynchronizer = controllerObject.GetComponent<IMixedRealityControllerPoseSynchronizer>();
 
diff --git a/Assets/MixedRealityToolkit/_Core/Devices/BaseDeviceManager.cs b/Assets/MixedRealityToolkit/_Core/Devices/BaseDeviceManager.cs
@@ -99,7 +99,7 @@ protected virtual IMixedRealityPointer[] RequestPointers(SystemType controllerTy
                     {
                         var pointerObject = Object.Instantiate(pointerProfile.PointerPrefab);
                         var pointer = pointerObject.GetComponent<IMixedRealityPointer>();
-                        pointerObject.transform.SetParent(MixedRealityManager.Instance.MixedRealityPlayspace.transform);
+                        pointerObject.transform.SetParent(MixedRealityManager.Instance.MixedRealityPlayspace);
 
                         if (pointer != null)
                         {
diff --git a/Assets/MixedRealityToolkit/_Core/Devices/MixedReality/WindowsMixedRealityController.cs b/Assets/MixedRealityToolkit/_Core/Devices/MixedReality/WindowsMixedRealityController.cs
@@ -243,10 +243,10 @@ private void UpdateGripData(InteractionSourceState interactionSourceState, Mixed
                         interactionSourceState.sourcePose.TryGetPosition(out currentGripPosition, InteractionSourceNode.Grip);
                         interactionSourceState.sourcePose.TryGetRotation(out currentGripRotation, InteractionSourceNode.Grip);
 
-                        if (MixedRealityManager.Instance.MixedRealityPlayspace.transform != null)
+                        if (MixedRealityManager.Instance.MixedRealityPlayspace != null)
                         {
-                            currentGripPose.Position = MixedRealityManager.Instance.MixedRealityPlayspace.transform.TransformPoint(currentGripPosition);
-                            currentGripPose.Rotation = Quaternion.Euler(MixedRealityManager.Instance.MixedRealityPlayspace.transform.TransformDirection(currentGripRotation.eulerAngles));
+                            currentGripPose.Position = MixedRealityManager.Instance.MixedRealityPlayspace.TransformPoint(currentGripPosition);
+                            currentGripPose.Rotation = Quaternion.Euler(MixedRealityManager.Instance.MixedRealityPlayspace.TransformDirection(currentGripRotation.eulerAngles));
                         }
                         else
                         {
diff --git a/Assets/MixedRealityToolkit/_Core/Managers/MixedRealityManager.cs b/Assets/MixedRealityToolkit/_Core/Managers/MixedRealityManager.cs
@@ -341,12 +341,12 @@ private void InitializeInternal()
             }
         }
 
-        private GameObject mixedRealityPlayspace;
+        private Transform mixedRealityPlayspace;
 
         /// <summary>
         /// Returns the MixedRealityPlayspace for the local player
         /// </summary>
-        public GameObject MixedRealityPlayspace
+        public Transform MixedRealityPlayspace
         {
             get {
                 AssertIsInitialized();
@@ -356,8 +356,8 @@ public GameObject MixedRealityPlayspace
                 }
                 else
                 {
-                    mixedRealityPlayspace = new GameObject("MixedRealityPlayspace");
-                    CameraCache.Main.transform.SetParent(mixedRealityPlayspace.transform);
+                    mixedRealityPlayspace = new GameObject("MixedRealityPlayspace").transform;
+                    CameraCache.Main.transform.SetParent(mixedRealityPlayspace);
 
                     // It's very important that the MixedRealityPlayspace align with the tracked space,
                     // otherwise reality-locked things like playspace boundaries won't be aligned properly.

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ private void Awake()`
`44`	`44`	`{`
`45`	`45`	`markerParent = new GameObject();`
`46`	`46`	`markerParent.name = "Boundary Demo Markers";`
`47`		`- markerParent.transform.parent = MixedRealityManager.Instance.MixedRealityPlayspace.transform;`
	`47`	`+ markerParent.transform.parent = MixedRealityManager.Instance.MixedRealityPlayspace;`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`private void Start()`
Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ private void ProcessTeleportationRequest(TeleportEventData eventData)`
`238`	`238`	`{`
`239`	`239`	`isProcessingTeleportRequest = true;`
`240`	`240`
`241`		`- var cameraParent = MixedRealityManager.Instance.MixedRealityPlayspace.transform;`
	`241`	`+ var cameraParent = MixedRealityManager.Instance.MixedRealityPlayspace;`
`242`	`242`
`243`	`243`	`targetRotation = Vector3.zero;`
`244`	`244`	`targetRotation.y = eventData.Pointer.PointerOrientation;`
Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ public override void OnPositionInputChanged(InputEventData<Vector2> eventData)`
`303`	`303`	`{`
`304`	`304`	`canMove = false;`
`305`	`305`	`// Rotate the camera by the rotation amount. If our angle is positive then rotate in the positive direction, otherwise in the opposite direction.`
`306`		`- MixedRealityManager.Instance.MixedRealityPlayspace.transform.RotateAround(CameraCache.Main.transform.position, Vector3.up, angle >= 0.0f ? rotationAmount : -rotationAmount);`
	`306`	`+ MixedRealityManager.Instance.MixedRealityPlayspace.RotateAround(CameraCache.Main.transform.position, Vector3.up, angle >= 0.0f ? rotationAmount : -rotationAmount);`
`307`	`307`	`}`
`308`	`308`	`else // We may be trying to strafe backwards.`
`309`	`309`	`{`
`@@ -317,10 +317,10 @@ public override void OnPositionInputChanged(InputEventData<Vector2> eventData)`
`317`	`317`	`if (offsetStrafeAngle > 0 && offsetStrafeAngle < backStrafeActivationAngle)`
`318`	`318`	`{`
`319`	`319`	`canMove = false;`
`320`		`- var height = MixedRealityManager.Instance.MixedRealityPlayspace.transform.position.y;`
`321`		`- var newPosition = -CameraCache.Main.transform.forward * strafeAmount + MixedRealityManager.Instance.MixedRealityPlayspace.transform.position;`
	`320`	`+ var height = MixedRealityManager.Instance.MixedRealityPlayspace.position.y;`
	`321`	`+ var newPosition = -CameraCache.Main.transform.forward * strafeAmount + MixedRealityManager.Instance.MixedRealityPlayspace.position;`
`322`	`322`	`newPosition.y = height;`
`323`		`- MixedRealityManager.Instance.MixedRealityPlayspace.transform.position = newPosition;`
	`323`	`+ MixedRealityManager.Instance.MixedRealityPlayspace.position = newPosition;`
`324`	`324`	`}`
`325`	`325`	`}`
`326`	`326`	`}`
Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ private void TryRenderControllerModel(Type controllerType)`
`203`	`203`	`// If we've got a controller model prefab, then place it in the scene.`
`204`	`204`	`if (controllerModel != null)`
`205`	`205`	`{`
`206`		`- var controllerObject = UnityEngine.Object.Instantiate(controllerModel, MixedRealityManager.Instance.MixedRealityPlayspace.transform);`
	`206`	`+ var controllerObject = UnityEngine.Object.Instantiate(controllerModel, MixedRealityManager.Instance.MixedRealityPlayspace);`
`207`	`207`	`controllerObject.name = $"{ControllerHandedness}_{controllerObject.name}";`
`208`	`208`	`var poseSynchronizer = controllerObject.GetComponent<IMixedRealityControllerPoseSynchronizer>();`
`209`	`209`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ protected virtual IMixedRealityPointer[] RequestPointers(SystemType controllerTy`
`99`	`99`	`{`
`100`	`100`	`var pointerObject = Object.Instantiate(pointerProfile.PointerPrefab);`
`101`	`101`	`var pointer = pointerObject.GetComponent<IMixedRealityPointer>();`
`102`		`- pointerObject.transform.SetParent(MixedRealityManager.Instance.MixedRealityPlayspace.transform);`
	`102`	`+ pointerObject.transform.SetParent(MixedRealityManager.Instance.MixedRealityPlayspace);`
`103`	`103`
`104`	`104`	`if (pointer != null)`
`105`	`105`	`{`
Original file line number	Diff line number	Diff line change
`@@ -243,10 +243,10 @@ private void UpdateGripData(InteractionSourceState interactionSourceState, Mixed`
`243`	`243`	`interactionSourceState.sourcePose.TryGetPosition(out currentGripPosition, InteractionSourceNode.Grip);`
`244`	`244`	`interactionSourceState.sourcePose.TryGetRotation(out currentGripRotation, InteractionSourceNode.Grip);`
`245`	`245`
`246`		`- if (MixedRealityManager.Instance.MixedRealityPlayspace.transform != null)`
	`246`	`+ if (MixedRealityManager.Instance.MixedRealityPlayspace != null)`
`247`	`247`	`{`
`248`		`- currentGripPose.Position = MixedRealityManager.Instance.MixedRealityPlayspace.transform.TransformPoint(currentGripPosition);`
`249`		`- currentGripPose.Rotation = Quaternion.Euler(MixedRealityManager.Instance.MixedRealityPlayspace.transform.TransformDirection(currentGripRotation.eulerAngles));`
	`248`	`+ currentGripPose.Position = MixedRealityManager.Instance.MixedRealityPlayspace.TransformPoint(currentGripPosition);`
	`249`	`+ currentGripPose.Rotation = Quaternion.Euler(MixedRealityManager.Instance.MixedRealityPlayspace.TransformDirection(currentGripRotation.eulerAngles));`
`250`	`250`	`}`
`251`	`251`	`else`
`252`	`252`	`{`
Original file line number	Diff line number	Diff line change
`@@ -341,12 +341,12 @@ private void InitializeInternal()`
`341`	`341`	`}`
`342`	`342`	`}`
`343`	`343`
`344`		`- private GameObject mixedRealityPlayspace;`
	`344`	`+ private Transform mixedRealityPlayspace;`
`345`	`345`
`346`	`346`	`/// <summary>`
`347`	`347`	`/// Returns the MixedRealityPlayspace for the local player`
`348`	`348`	`/// </summary>`
`349`		`- public GameObject MixedRealityPlayspace`
	`349`	`+ public Transform MixedRealityPlayspace`
`350`	`350`	`{`
`351`	`351`	`get {`
`352`	`352`	`AssertIsInitialized();`
`@@ -356,8 +356,8 @@ public GameObject MixedRealityPlayspace`
`356`	`356`	`}`
`357`	`357`	`else`
`358`	`358`	`{`
`359`		`- mixedRealityPlayspace = new GameObject("MixedRealityPlayspace");`
`360`		`- CameraCache.Main.transform.SetParent(mixedRealityPlayspace.transform);`
	`359`	`+ mixedRealityPlayspace = new GameObject("MixedRealityPlayspace").transform;`
	`360`	`+ CameraCache.Main.transform.SetParent(mixedRealityPlayspace);`
`361`	`361`
`362`	`362`	`// It's very important that the MixedRealityPlayspace align with the tracked space,`
`363`	`363`	`// otherwise reality-locked things like playspace boundaries won't be aligned properly.`