Fix bug where the start and end positions modified by the handles drawn in the scene would not persist when user pressed play.

Author: Julia Schwarz

Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/Sliders/PinchSlider.cs

@@ -52,24 +52,29 @@ private enum SliderAxis
         [SerializeField]
         [Tooltip("Where the slider track starts, as distance from center along slider axis, in local space units.")]
         private float sliderStartDistance = -.5f;
+        public float SliderStartDistance
+        {
+            get { return sliderStartDistance; }
+            set { sliderStartDistance = value; }
+        }
+
         [SerializeField]
         [Tooltip("Where the slider track ends, as distance from center along slider axis, in local space units.")]
         private float sliderEndDistance = .5f;
+        public float SliderEndDistance
+        {
+            get { return sliderEndDistance; }
+            set { sliderEndDistance = value; }
+        }
 
         /// <summary>
         /// Gets the start position of the slider, in world space, or zero if invalid.
         /// Sets the start position of the slider, in world space, projected to the slider's axis.
         /// </summary>
         public Vector3 SliderStartPosition
         {
-            get
-            {
-                return transform.TransformPoint(GetSliderAxis() * sliderStartDistance);
-            }
-            set
-            {
-                sliderStartDistance = Vector3.Dot(transform.InverseTransformPoint(value), GetSliderAxis());
-            }
+            get { return transform.TransformPoint(GetSliderAxis() * sliderStartDistance); }
+            set { sliderStartDistance = Vector3.Dot(transform.InverseTransformPoint(value), GetSliderAxis()); }
         }
 
         /// <summary>
@@ -78,14 +83,8 @@ public Vector3 SliderStartPosition
         /// </summary>
         public Vector3 SliderEndPosition
         {
-            get
-            {
-                return transform.TransformPoint(GetSliderAxis() * sliderEndDistance);
-            }
-            set
-            {
-                sliderEndDistance = Vector3.Dot(transform.InverseTransformPoint(value), GetSliderAxis());
-            }
+            get { return transform.TransformPoint(GetSliderAxis() * sliderEndDistance); }
+            set { sliderEndDistance = Vector3.Dot(transform.InverseTransformPoint(value), GetSliderAxis()); }
         }
 
         /// <summary>
@@ -95,6 +94,7 @@ public Vector3 SliderTrackDirection
         {
             get { return SliderEndPosition - SliderStartPosition; }
         }
+
         #endregion
 
         #region Event Handlers

Assets/MixedRealityToolkit.SDK/Inspectors/UX/Sliders/PinchSliderInspector.cs

@@ -29,23 +29,32 @@ private void OnSceneGUI()
                 Handles.color = Color.cyan;
                 Vector3 startPos = slider.SliderStartPosition;
                 Vector3 endPos = slider.SliderEndPosition;
-
                 Handles.DrawLine(startPos, endPos);
 
-                float handleSize = HandleUtility.GetHandleSize(startPos) * 0.15f;
 
+                EditorGUI.BeginChangeCheck();
+                
+                float handleSize = HandleUtility.GetHandleSize(startPos) * 0.15f;
                 slider.SliderStartPosition = Handles.FreeMoveHandle(startPos,
                     Quaternion.identity,
                     handleSize,
                     Vector3.zero,
                     Handles.SphereHandleCap);
-
                 slider.SliderEndPosition = Handles.FreeMoveHandle(endPos,
                     Quaternion.identity,
                     handleSize,
                     Vector3.zero,
                     Handles.SphereHandleCap);
 
+                if (EditorGUI.EndChangeCheck())
+                {
+                    var sliderStartSerialized = serializedObject.FindProperty("sliderStartDistance");
+                    var sliderEndSerialized = serializedObject.FindProperty("sliderEndDistance");
+                    sliderStartSerialized.floatValue = slider.SliderStartDistance;
+                    sliderEndSerialized.floatValue = slider.SliderEndDistance;
+                    serializedObject.ApplyModifiedProperties();
+                }
+
                 DrawLabelWithDottedLine(startPos + (Vector3.up * handleSize * 10f), startPos, handleSize, "slider start");
                 DrawLabelWithDottedLine(endPos + (Vector3.up * handleSize * 10f), endPos, handleSize, "slider end");
             }