Caching ActualFlattenAxis result for subsequent checks

Zee2 · Zee2 · commit 99a36f5264fe · 2021-06-21T20:16:48.000-07:00
diff --git a/Assets/MRTK/SDK/Features/UX/Scripts/BoundsControl/BoundsControl.cs b/Assets/MRTK/SDK/Features/UX/Scripts/BoundsControl/BoundsControl.cs
@@ -1250,15 +1250,16 @@ private void TransformTarget(HandleType transformType)
                     // If non-uniform scaling or uniform scaling only on the non-flattened axes
                     if (ScaleHandlesConfig.ScaleBehavior != HandleScaleMode.Uniform || !UniformScaleOnFlattenedAxis)
                     {
-                        if (ActualFlattenAxis == FlattenModeType.FlattenX)
+                        var currentActualFlattenAxis = ActualFlattenAxis; // Calculate flatten axis once
+                        if (currentActualFlattenAxis == FlattenModeType.FlattenX)
                         {
                             scaleFactor.x = 1;
                         }
-                        if (ActualFlattenAxis == FlattenModeType.FlattenY)
+                        if (currentActualFlattenAxis == FlattenModeType.FlattenY)
                         {
                             scaleFactor.y = 1;
                         }
-                        if (ActualFlattenAxis == FlattenModeType.FlattenZ)
+                        if (currentActualFlattenAxis == FlattenModeType.FlattenZ)
                         {
                             scaleFactor.z = 1;
                         }

Original file line number	Diff line number	Diff line change
`@@ -1250,15 +1250,16 @@ private void TransformTarget(HandleType transformType)`
`1250`	`1250`	`// If non-uniform scaling or uniform scaling only on the non-flattened axes`
`1251`	`1251`	`if (ScaleHandlesConfig.ScaleBehavior != HandleScaleMode.Uniform \|\| !UniformScaleOnFlattenedAxis)`
`1252`	`1252`	`{`
`1253`		`- if (ActualFlattenAxis == FlattenModeType.FlattenX)`
	`1253`	`+ var currentActualFlattenAxis = ActualFlattenAxis; // Calculate flatten axis once`
	`1254`	`+ if (currentActualFlattenAxis == FlattenModeType.FlattenX)`
`1254`	`1255`	`{`
`1255`	`1256`	`scaleFactor.x = 1;`
`1256`	`1257`	`}`
`1257`		`- if (ActualFlattenAxis == FlattenModeType.FlattenY)`
	`1258`	`+ if (currentActualFlattenAxis == FlattenModeType.FlattenY)`
`1258`	`1259`	`{`
`1259`	`1260`	`scaleFactor.y = 1;`
`1260`	`1261`	`}`
`1261`		`- if (ActualFlattenAxis == FlattenModeType.FlattenZ)`
	`1262`	`+ if (currentActualFlattenAxis == FlattenModeType.FlattenZ)`
`1262`	`1263`	`{`
`1263`	`1264`	`scaleFactor.z = 1;`
`1264`	`1265`	`}`