Skip to content

Commit 9ba100b

Browse files
author
David Kline
authored
Merge pull request #6742 from davidkline-ms/pv6732
Mark MRC capture settings as experimental, disabled by default
2 parents 9ec9fbd + f9cecb2 commit 9ba100b

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

Assets/MixedRealityToolkit.Providers/WindowsMixedReality/Editor/WindowsMixedRealityCameraSettingsProfileInspector.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,16 @@ public override void OnInspectorGUI()
3737
serializedObject.Update();
3838

3939
EditorGUILayout.Space();
40-
EditorGUILayout.LabelField("Mixed Reality Capture Settings", EditorStyles.boldLabel);
41-
4240
using (new EditorGUILayout.HorizontalScope())
4341
{
44-
EditorGUILayout.PropertyField(renderFromPVCameraForMixedRealityCapture, pvCameraRenderingTitle);
42+
EditorGUILayout.LabelField("Mixed Reality Capture Settings (Experimental)", EditorStyles.boldLabel);
4543
InspectorUIUtility.RenderDocumentationButton(MRCDocURL);
4644
}
4745

46+
EditorGUILayout.HelpBox("Render from PV Camera is supported on Unity 2018.4.12f1 or newer and 2019.3 or newer. Enabling the feature on other versions may result in incorrect capture behavior.", MessageType.Info);
47+
48+
EditorGUILayout.PropertyField(renderFromPVCameraForMixedRealityCapture, pvCameraRenderingTitle);
49+
4850
serializedObject.ApplyModifiedProperties();
4951
}
5052
}

Assets/MixedRealityToolkit.Providers/WindowsMixedReality/Profiles/DefaultWindowsMixedRealityCameraSettingsProfile.asset

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ MonoBehaviour:
1313
m_Name: DefaultWindowsMixedRealityCameraSettingsProfile
1414
m_EditorClassIdentifier:
1515
isCustomProfile: 0
16-
renderFromPVCameraForMixedRealityCapture: 1
16+
renderFromPVCameraForMixedRealityCapture: 0

Assets/MixedRealityToolkit.Providers/WindowsMixedReality/WindowsMixedRealityCameraSettingsProfile.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ namespace Microsoft.MixedReality.Toolkit.WindowsMixedReality
99
/// <summary>
1010
/// Configuration profile for the Windows Mixed Reality Camera settings provider.
1111
/// </summary>
12-
[CreateAssetMenu(menuName = "Mixed Reality Toolkit/Profiles/Windows Mixed Reality Camera Settings Profile", fileName = "DefaultWindowsMixedRealityCameraSettingsProfile", order = 100)]
12+
[CreateAssetMenu(menuName = "Mixed Reality Toolkit/Profiles/Windows Mixed Reality Camera Settings Profile", fileName = "WindowsMixedRealityCameraSettingsProfile", order = 100)]
1313
[MixedRealityServiceProfile(typeof(WindowsMixedRealityCameraSettings))]
1414
public class WindowsMixedRealityCameraSettingsProfile : BaseCameraSettingsProfile
1515
{
1616
[SerializeField]
1717
[Tooltip("If enabled, will render scene from PV camera projection matrix while MRC is active. This will ensure that holograms, such as hand meshes, remain visibly aligned in the video output.")]
18-
private bool renderFromPVCameraForMixedRealityCapture = true;
18+
private bool renderFromPVCameraForMixedRealityCapture = false;
1919

2020
/// <summary>
2121
/// Whether to use photo/video camera rendering for Mixed Reality Capture on Windows.

0 commit comments

Comments
 (0)