Skip to content

Commit 9c9ce7e

Browse files
Updated Input Action Rules Inspector
1 parent 6470ad7 commit 9c9ce7e

File tree

4 files changed

+361
-17
lines changed

4 files changed

+361
-17
lines changed

Assets/MixedRealityToolkit-SDK/Features/Input/MixedRealityInputManager.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public class MixedRealityInputManager : MixedRealityEventManager, IMixedRealityI
7373
private SpeechEventData speechEventData;
7474
private DictationEventData dictationEventData;
7575

76-
public MixedRealityInputActionRulesProfile CurrentInputActionRulesProfile { get; set; }
76+
private MixedRealityInputActionRulesProfile CurrentInputActionRulesProfile { get; set; }
7777

7878
#region IMixedRealityManager Implementation
7979

@@ -1444,7 +1444,7 @@ public void RaiseDictationError(IMixedRealityInputSource source, string dictatio
14441444

14451445
#region Rules
14461446

1447-
private MixedRealityInputAction ProcessRules_Internal<T1, T2>(MixedRealityInputAction inputAction, T1[] inputActionRules, T2 criteria) where T1 : struct, IInputActionRule<T2>
1447+
private static MixedRealityInputAction ProcessRules_Internal<T1, T2>(MixedRealityInputAction inputAction, T1[] inputActionRules, T2 criteria) where T1 : struct, IInputActionRule<T2>
14481448
{
14491449
for (int i = 0; i < inputActionRules.Length; i++)
14501450
{
@@ -1456,6 +1456,12 @@ private MixedRealityInputAction ProcessRules_Internal<T1, T2>(MixedRealityInputA
14561456
return inputAction;
14571457
}
14581458

1459+
if (inputActionRules[i].BaseAction.AxisConstraint != inputActionRules[i].RuleAction.AxisConstraint)
1460+
{
1461+
Debug.LogError("Input Action Rule doesn't have the same Axis Constraint as the Base Action!");
1462+
return inputAction;
1463+
}
1464+
14591465
return inputActionRules[i].RuleAction;
14601466
}
14611467
}

Assets/MixedRealityToolkit-SDK/Profiles/MixedRealityInputActionRulesProfile.asset

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,10 @@ MonoBehaviour:
1111
m_Script: {fileID: 11500000, guid: ee54661ca8af487c9db40e57d479fa48, type: 3}
1212
m_Name: MixedRealityInputActionRulesProfile
1313
m_EditorClassIdentifier:
14+
isCustomProfile: 0
15+
inputActionRulesDigital: []
16+
inputActionRulesSingleAxis: []
17+
inputActionRulesDualAxis: []
18+
inputActionRulesVectorAxis: []
19+
inputActionRulesQuaternionAxis: []
20+
inputActionRulesPoseAxis: []

Assets/MixedRealityToolkit/_Core/Definitions/InputSystem/MixedRealityInputActionRulesProfile.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
namespace Microsoft.MixedReality.Toolkit.Core.Definitions.InputSystem
88
{
99
[CreateAssetMenu(menuName = "Mixed Reality Toolkit/Mixed Reality Input Action Rules Profile", fileName = "MixedRealityInputActionRulesProfile", order = (int)CreateProfileMenuItemIndices.InputActionRules)]
10-
public class MixedRealityInputActionRulesProfile : ScriptableObject
10+
public class MixedRealityInputActionRulesProfile : BaseMixedRealityProfile
1111
{
1212
[SerializeField]
1313
private InputActionRuleDigital[] inputActionRulesDigital;

0 commit comments

Comments
 (0)