Skip to content

Commit a3fb916

Browse files
RogPodgekeveleigh
andauthored
Finger cursor and pointer naming rework (#9280)
* initial commit for finger cursor rework * renamed gaze cursor prefab to something more appropriate, labeled gaze cursor prefab field * cursors now decoupled from their parent pointers, cursors and pointers are now named appropriately based on their handedness in the heirarchy * minor unit test updates * addressed PR comments, provided named constants * fixed code validation issue, provided variable clarity * Update Assets/MRTK/SDK/Features/UX/Scripts/Pointers/SpherePointer.cs Co-authored-by: Kurtis <[email protected]> * Update Assets/MRTK/SDK/Features/UX/Scripts/Pointers/BaseControllerPointer.cs Co-authored-by: Kurtis <[email protected]> * added comments concerning assumptions made about the object hierarchy Co-authored-by: Kurtis <[email protected]>
1 parent 8f3a023 commit a3fb916

16 files changed

+343
-320
lines changed

Assets/MRTK/Core/Inspectors/Profiles/MixedRealityPointerProfileInspector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public override void OnInspectorGUI()
6666
EditorGUILayout.LabelField("Gaze Settings", EditorStyles.boldLabel);
6767
{
6868
EditorGUILayout.Space();
69-
EditorGUILayout.PropertyField(gazeCursorPrefab);
69+
EditorGUILayout.PropertyField(gazeCursorPrefab, new GUIContent("Gaze Cursor Prefab"));
7070
EditorGUILayout.PropertyField(gazeProviderType);
7171
EditorGUILayout.PropertyField(useHeadGazeOverride);
7272
EditorGUILayout.PropertyField(isEyeTrackingEnabled);

Assets/MRTK/Core/Providers/InputSimulation/SimulatedArticulatedHandPoses.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2031,7 +2031,7 @@ public static void LoadDefaultGesturePoses()
20312031
""z"": -0.0008905145805329084
20322032
},
20332033
""rotation"": {
2034-
""x"": -0.4986042380332947,
2034+
""x"": 0.4986042380332947,
20352035
""y"": -0.10437075048685074,
20362036
""z"": 0.07316453754901886,
20372037
""w"": 0.8577484488487244

0 commit comments

Comments
 (0)