update from pr feedback

Author: David Kline (ANALOG)

Assets/MixedRealityToolkit.Services/BoundarySystem/MixedRealityBoundarySystem.cs

@@ -590,7 +590,6 @@ public bool Contains(Vector3 location, Boundary.Type boundaryType = Boundary.Typ
             }
 
             // Handle the user teleporting (boundary moves with them).
-            // todo: update...
             location = Playspace.InverseTransformPoint(location);
 
             if (FloorHeight.Value > location.y ||
@@ -634,7 +633,6 @@ public bool TryGetRectangularBoundsParams(out Vector2 center, out float angle, o
             }
 
             // Handle the user teleporting (boundary moves with them).
-            // todo: update...
             Vector3 transformedCenter = Playspace.TransformPoint(
                 new Vector3(rectangularBounds.Center.x, 0f, rectangularBounds.Center.y));
 
@@ -670,7 +668,6 @@ public GameObject GetFloorVisualization()
             currentFloorObject = GameObject.CreatePrimitive(PrimitiveType.Cube);
             currentFloorObject.name = "Boundary System Floor";
             currentFloorObject.transform.localScale = new Vector3(floorScale.x, boundaryObjectThickness, floorScale.y);
-            // todo: update...
             currentFloorObject.transform.Translate(new Vector3(
                 Playspace.position.x,
                 FloorHeight.Value - (currentFloorObject.transform.localScale.y * 0.5f),
@@ -758,7 +755,6 @@ public GameObject GetTrackedAreaVisualization()
             currentTrackedAreaObject = new GameObject("Tracked Area");
             currentTrackedAreaObject.layer = ignoreRaycastLayerValue;
             currentTrackedAreaObject.AddComponent<LineRenderer>();
-            // todo: update...
             currentTrackedAreaObject.transform.Translate(new Vector3(
                 Playspace.position.x,
                 boundaryObjectRenderOffset,

Assets/MixedRealityToolkit.Services/InputSystem/MixedRealityInputSystem.cs

@@ -103,7 +103,11 @@ public override void Initialize()
             bool addedComponents = false;
 
             MixedRealityInputSystemProfile profile = ConfigurationProfile as MixedRealityInputSystemProfile;
-            if (profile == null) { return; }
+            if (profile == null)
+            {
+                Debug.LogError("The Input system is missing the required Input System Profile!");
+                return;
+            }
 
             if (!Application.isPlaying)
             {
@@ -142,12 +146,6 @@ public override void Initialize()
                 CameraCache.Main.gameObject.EnsureComponent<StandaloneInputModule>();
             }
 
-            if (profile == null)
-            {
-                Debug.LogError("The Input system is missing the required Input System Profile!");
-                return;
-            }
-
             if (profile.InputActionRulesProfile != null)
             {
                 CurrentInputActionRulesProfile = profile.InputActionRulesProfile;

Assets/MixedRealityToolkit/Interfaces/SpatialAwareness/Observers/IMixedRealitySpatialAwarenessMeshObserver.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
 using Microsoft.MixedReality.Toolkit.Core.Definitions.SpatialAwarenessSystem;
-
 using System.Collections.Generic;
 using UnityEngine;
 

Assets/MixedRealityToolkit/Providers/BaseDeviceManager.cs

@@ -15,7 +15,6 @@ namespace Microsoft.MixedReality.Toolkit.Core.Providers
     /// <summary>
     /// Base Device manager to inherit from.
     /// </summary>
-    // todo: inherit BaseDataProvider...
     public class BaseDeviceManager : BaseExtensionService, IMixedRealityDeviceManager
     {
         /// <summary>

Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs

@@ -399,7 +399,7 @@ private void InitializeServiceLocator()
 #if UNITY_EDITOR                
                 LayerExtensions.SetupLayer(31, "Spatial Awareness");
 #endif
-                object[] args = { this }; // todo: add profile
+                object[] args = { this };
                 if (!RegisterService<IMixedRealitySpatialAwarenessSystem>(ActiveProfile.SpatialAwarenessSystemSystemType, args: args) && SpatialAwarenessSystem != null)
                 {
                     Debug.LogError("Failed to start the Spatial Awareness System!");
@@ -433,7 +433,6 @@ private void InitializeServiceLocator()
 
                     if (typeof(IMixedRealityDataProvider).IsAssignableFrom(configuration.ComponentType.Type))
                     {
-                        // todo: pass the service instance to the data provider
                         RegisterService<IMixedRealityDataProvider>(configuration.ComponentType, configuration.RuntimePlatform, this, null, configuration.ComponentName, configuration.Priority, configuration.ConfigurationProfile);
 
                     }
@@ -443,7 +442,7 @@ private void InitializeServiceLocator()
                     }
                     else
                     {
-                        // todo: unsupported type
+                        Debug.LogWarning($"{configuration.ComponentName} does not implement IMixedRealityDataProvider or IMixedRealityExtensionService and could not be registered");
                     }
                 }
             }
@@ -729,11 +728,10 @@ public Transform MixedRealityPlayspace
 #if UNITY_EDITOR
         private void OnValidate()
         {
-            // todo: trying something
-            //if (!newInstanceBeingInitialized && !IsInitialized && !UnityEditor.EditorApplication.isPlayingOrWillChangePlaymode)
-            //{
-            //    ConfirmInitialized();
-            //}
+            if (!newInstanceBeingInitialized && !IsInitialized && !UnityEditor.EditorApplication.isPlayingOrWillChangePlaymode)
+            {
+                ConfirmInitialized();
+            }
         }
 #endif // UNITY_EDITOR