[~] Split IInputHandler in two interfaces: IInputHandler, which is for input up/down, and IInputClickHandler, which is for click events (the tap gesture).

Author: maxouellet

Assets/HoloToolkit-Examples/ColorPicker/GazeableColorPicker.cs

@@ -1,11 +1,10 @@
 using HoloToolkit.Unity.InputModule;
 using UnityEngine;
-using UnityEngine.UI;
 using UnityEngine.Events;
 
 namespace Lighthouse
 {
-    public class GazeableColorPicker : MonoBehaviour, IFocusable, IInputHandler
+    public class GazeableColorPicker : MonoBehaviour, IFocusable, IInputClickHandler
     {
         public Renderer rendererComponent;
 
@@ -47,16 +46,6 @@ public void OnFocusExit()
             gazing = false;
         }
 
-        public void OnInputUp(InputEventData eventData)
-        {
-            // Nothing to do
-        }
-
-        public void OnInputDown(InputEventData eventData)
-        {
-            // Nothing to do
-        }
-
         public void OnInputClicked(InputEventData eventData)
         {
             UpdatePickedColor(OnPickedColor);

Assets/HoloToolkit-Examples/GazeRuler/Scripts/MeasureManager.cs

@@ -8,7 +8,7 @@
 /// <summary>
 /// manager all measure tools here
 /// </summary>
-public class MeasureManager : Singleton<MeasureManager>, IHoldHandler, IInputHandler
+public class MeasureManager : Singleton<MeasureManager>, IHoldHandler, IInputClickHandler
 {
     private IGeometry manager;
     public GeometryMode Mode;
@@ -99,16 +99,6 @@ public void OnHoldCanceled(HoldEventData eventData)
         // Nothing to do
     }
 
-    public void OnInputUp(InputEventData eventData)
-    {
-        // Nothing to do
-    }
-
-    public void OnInputDown(InputEventData eventData)
-    {
-        // Nothing to do
-    }
-
     public void OnInputClicked(InputEventData eventData)
     {
         OnSelect();

Assets/HoloToolkit-Examples/SharingWithUNET/Scripts/PlayerController.cs

@@ -11,7 +11,7 @@ namespace HoloToolkit.Examples.SharingWithUNET
     /// Controls player behavior (local and remote).
     /// </summary>
     [NetworkSettings(sendInterval = 0.033f)]
-    public class PlayerController : NetworkBehaviour, IInputHandler
+    public class PlayerController : NetworkBehaviour, IInputClickHandler
     {
         /// <summary>
         /// The game object that represents the 'bullet' for 
@@ -131,16 +131,6 @@ void CmdFire()
             Destroy(nextBullet, 8.0f);
         }
 
-        public void OnInputUp(InputEventData eventData)
-        {
-            // Nothing to do
-        }
-
-        public void OnInputDown(InputEventData eventData)
-        {
-            // Nothing to do
-        }
-
         public void OnInputClicked(InputEventData eventData)
         {
             if (isLocalPlayer)

Assets/HoloToolkit-Examples/SpatialUnderstanding/SpatialUnderstanding-FeatureOverview/Scripts/AppState.cs

@@ -6,7 +6,7 @@
 using System;
 using HoloToolkit.Unity.InputModule;
 
-public class AppState : Singleton<AppState>, ISourceStateHandler, IInputHandler
+public class AppState : Singleton<AppState>, ISourceStateHandler, IInputClickHandler
 {
     // Consts
     public float kMinAreaForStats = 5.0f;
@@ -252,16 +252,6 @@ public void OnSourceLost(SourceStateEventData eventData)
         }
     }
 
-    public void OnInputUp(InputEventData eventData)
-    {
-        // Nothing to do
-    }
-
-    public void OnInputDown(InputEventData eventData)
-    {
-        // Nothing to do
-    }
-
     public void OnInputClicked(InputEventData eventData)
     {
         if ((SpatialUnderstanding.Instance.ScanState == SpatialUnderstanding.ScanStates.Scanning) &&

Assets/HoloToolkit/Input/README.md

@@ -12,7 +12,8 @@ Game objects that want to consume input events can implement one or many **input
 
 - **IFocusable** for focus enter and exit. The focus can be triggered by the user's gaze or any other gaze source.
 - **IHoldHandle** for the Windows hold gesture.
-- **IInputHandler** for source up, down and clicked. The source can be a hand that tapped, a clicker that was pressed, etc.
+- **IInputHandler** for source up and down. The source can be a hand that tapped, a clicker that was pressed, etc.
+- **IInputClickHandler** for source clicked. The source can be a hand that tapped, a clicker that was pressed, etc.
 - **IManipulationHandler** for the Windows manipulation gesture.
 - **INavigationnHandler** for the Windows navigation gesture.
 - **ISourceStateHandler** for the source detected and source lost events.

Assets/HoloToolkit/Input/Scripts/Cursor/ICursor.cs

@@ -8,7 +8,7 @@ namespace HoloToolkit.Unity.InputModule
     /// <summary>
     /// Cursor Interface for handling input events and setting visiblity.
     /// </summary>
-    public interface ICursor : IInputHandler, ISourceStateHandler
+    public interface ICursor : IInputHandler, IInputClickHandler, ISourceStateHandler
     {
         /// <summary>
         /// Position of the cursor.

Assets/HoloToolkit/Input/Scripts/InputEvents/IInputClickHandler.cs

@@ -0,0 +1,15 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
+using UnityEngine.EventSystems;
+
+namespace HoloToolkit.Unity.InputModule
+{
+    /// <summary>
+    /// Interface to implement to react to simple click input.
+    /// </summary>
+    public interface IInputClickHandler : IEventSystemHandler
+    {
+        void OnInputClicked(InputEventData eventData);
+    }
+}

Assets/HoloToolkit/Input/Scripts/InputEvents/IInputClickHandler.cs.meta

@@ -12,6 +12,5 @@ public interface IInputHandler : IEventSystemHandler
     {
         void OnInputUp(InputEventData eventData);
         void OnInputDown(InputEventData eventData);
-        void OnInputClicked(InputEventData eventData);
     }
 }

Assets/HoloToolkit/Input/Scripts/InputEvents/IInputHandler.cs

@@ -363,7 +363,7 @@ private void InputSource_SourceClicked(object sender, SourceClickEventArgs e)
             inputEventData.Initialize(e.InputSource, e.SourceId);
 
             // Handler for execute events
-            ExecuteEvents.EventFunction<IInputHandler> eventHandler = (inputHandler, eventData) => { inputHandler.OnInputClicked(inputEventData); };
+            ExecuteEvents.EventFunction<IInputClickHandler> eventHandler = (inputHandler, eventData) => { inputHandler.OnInputClicked(inputEventData); };
 
             // Pass handler through HandleEvent to perform modal/fallback logic
             HandleEvent(inputEventData, eventHandler);