Merge pull request #10209 from wonkee-kim/fix/construct-gltf-standard-shader-material-color

keveleigh · keveleigh · commit b3ce15a2e4b8 · 2021-09-09T15:43:34.000-07:00
Fix gltf object appears black
diff --git a/Assets/MRTK/Core/Utilities/Gltf/Serialization/ConstructGltf.cs b/Assets/MRTK/Core/Utilities/Gltf/Serialization/ConstructGltf.cs
@@ -360,7 +360,10 @@ private static async Task<Material> CreateStandardShaderMaterial(GltfObject gltf
                 material.mainTexture = gltfObject.images[gltfMaterial.pbrMetallicRoughness.baseColorTexture.index].Texture;
             }
 
-            material.color = gltfMaterial.pbrMetallicRoughness.baseColorFactor.GetColorValue();
+            if (gltfMaterial.pbrMetallicRoughness?.baseColorFactor != null)
+            {
+                material.color = gltfMaterial.pbrMetallicRoughness.baseColorFactor.GetColorValue();
+            }
 
             if (gltfMaterial.alphaMode == "MASK")
             {

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,10 @@ private static async Task<Material> CreateStandardShaderMaterial(GltfObject gltf`
`360`	`360`	`material.mainTexture = gltfObject.images[gltfMaterial.pbrMetallicRoughness.baseColorTexture.index].Texture;`
`361`	`361`	`}`
`362`	`362`
`363`		`- material.color = gltfMaterial.pbrMetallicRoughness.baseColorFactor.GetColorValue();`
	`363`	`+ if (gltfMaterial.pbrMetallicRoughness?.baseColorFactor != null)`
	`364`	`+ {`
	`365`	`+ material.color = gltfMaterial.pbrMetallicRoughness.baseColorFactor.GetColorValue();`
	`366`	`+ }`
`364`	`367`
`365`	`368`	`if (gltfMaterial.alphaMode == "MASK")`
`366`	`369`	`{`