Skip to content

Commit c036b2e

Browse files
author
David Kline
authored
Merge pull request #3002 from Akshat111999/master
Spelling and Punctuation changes are done
2 parents b4b4b7e + 3a99b34 commit c036b2e

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

BreakingChanges.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Breaking Changes
22

33
- **Renaming HoloToolkit-Unity repository to MixedRealityToolkit-Unity** to align with product direction.
4-
- Technically **all your checkins and redirect links will continue to work as-is** but we wanted to give a better heads up on this.
4+
- Technically **all your check-ins and redirect links will continue to work as-is** but we wanted to give a better heads up on this.
55
- All other dependent repositories will undergo a similar name change.
66
- We are **not breaking toolkit folder names and namespaces at this time.**
7-
- Instead we are taking a staggered approach for breaking changes based on developer feedback.
7+
- Instead, we are taking a staggered approach for breaking changes based on developer feedback.
88

99
| Breaking change description | Notes |
1010
| --- | --- |
1111
| Rename repository to MixedRealityToolkit-Unity. | <ul><li>Recommend you do: $git remote set-url origin new_url.</li><li>Recommend reading: https://help.github.com/articles/renaming-a-repository ; https://github.com/blog/1508-repository-redirects-are-here</li></ul>|
12-
| Updating toolkit namespace to MixedReality | <ul><li>Update folder names, class names and namespace names post 2017.2.0 release.</li></ul>|
12+
| Updating toolkit namespace to MixedReality | <ul><li>Update folder names, class names and namespace names post 2017.2.0 release.</li></ul>|

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ If you have any questions, please reach out on the [HoloLens forums](https://for
55

66
# Process
77

8-
1. [Make a proposal](https://github.com/Microsoft/HoloToolkit-Unity/issues) (either new, or for one of the elements in our backlog)
8+
1. [Make a proposal](https://github.com/Microsoft/HoloToolkit-Unity/issues) (either new or for one of the elements in our backlog)
99
2. Identify the appropriate development branch
1010
3. Implement the proposal and its tests.
1111
4. Ensure that your implementation meets the [coding guidelines](CodingGuidelines.md).
@@ -22,9 +22,9 @@ This will let us have a brief discussion about the problem and, hopefully, ident
2222

2323
Note: If you wish to work on something that already exists on our backlog, you can use that work item as your proposal.
2424

25-
# Identifing the development branch
25+
# Identifying the development branch
2626

27-
The master branch does not accept direct pull requests. Each change must be submitted through an appropriate developement branch. Each upcoming MRTK release has its own development branch (ex: may18_dev).
27+
The master branch does not accept direct pull requests. Each change must be submitted through an appropriate development branch. Each upcoming MRTK release has its own development branch (ex: may18_dev).
2828

2929
To identify the appropriate development branch:
3030

@@ -46,7 +46,7 @@ NOTE: A project maintainer may retarget your PR to a different development branc
4646
5. Make sure that all the tests continue to pass.
4747
6. Ensure the code is [WACK compliant](https://developer.microsoft.com/en-us/windows/develop/app-certification-kit). To do this, generate a Visual Studio solution, right click on project; Store -> Create App Packages. Follow the prompts and run WACK tests. Make sure they all succeed.
4848
7. Ensure you update the [README](https://github.com/Microsoft/HoloToolkit-Unity/blob/master/README.md) with additional documentation as needed.
49-
8. Also update the [HoloToolkit-Unity wiki](https://github.com/Microsoft/HoloToolkit-Unity/wiki) if you think it will be useful for other developers.
49+
8. Also, update the [HoloToolkit-Unity wiki](https://github.com/Microsoft/HoloToolkit-Unity/wiki) if you think it will be useful for other developers.
5050

5151
# Pull request
5252

0 commit comments

Comments
 (0)