Skip to content

Commit c0c4abb

Browse files
committed
Revert "Additional name updates"
This reverts commit e7adf22.
1 parent e7adf22 commit c0c4abb

File tree

4 files changed

+39
-34
lines changed

4 files changed

+39
-34
lines changed

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_ScrollPanZoom/Scripts/BaseClasses/PanZoomBase.cs

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -49,24 +49,24 @@ public abstract class PanZoomBase : MonoBehaviour,
4949
/// <summary>
5050
/// Zoom acceleration defining the steepness of logistic speed function mapping.
5151
/// </summary>
52-
internal float zoomAcceleration = 10f;
52+
internal float ZoomAcceleration = 10f;
5353

5454
/// <summary>
5555
/// Maximum zoom speed.
5656
/// </summary>
5757
[Tooltip("Maximum speed when zooming.")]
58-
internal float zoomSpeedMax = 0.02f;
58+
internal float ZoomSpeedMax = 0.02f;
5959

6060
/// <summary>
6161
/// Minimum scale of the texture for zoom in - e.g., 0.5f (half the original size).
6262
/// </summary>
63-
internal float zoomMinScale = 0.1f;
63+
internal float ZoomMinScale = 0.1f;
6464

6565
/// <summary>
6666
/// Maximum scale of the texture for zoom out - e.g., 1f (the original size) or 2.0f
6767
/// (double the original size).
6868
/// </summary>
69-
internal float zoomMaxScale = 1.0f;
69+
internal float ZoomMaxScale = 1.0f;
7070

7171
/// <summary>
7272
/// Size of the GameObject's collider when being looked at.
@@ -116,7 +116,7 @@ public abstract class PanZoomBase : MonoBehaviour,
116116
private Vector3 navPos = Vector3.zero;
117117
private bool isFocused = false;
118118
internal bool isZooming = false;
119-
internal bool zoomGestureEnabledOnStartup = false;
119+
internal bool ZoomGestureEnabledOnStartup = false;
120120
private bool handZoomEnabled = false;
121121

122122
protected Vector3 originalRatio;
@@ -140,7 +140,7 @@ protected virtual void Start()
140140
{
141141
// Init children
142142
Initialize();
143-
handZoomEnabled = zoomGestureEnabledOnStartup;
143+
handZoomEnabled = ZoomGestureEnabledOnStartup;
144144
Initialize();
145145

146146
// Init eye tracking target
@@ -434,8 +434,8 @@ private void UpdateZoom()
434434
if (zoomDir != 0)
435435
{
436436
// Following a logistic function; -0.5 because dynamicZoom [0,1];
437-
zoomSpeed = zoomSpeedMax / (1 + Mathf.Pow(2.71828f, -zoomAcceleration * (dynamicZoom - 0.5f))) * Time.deltaTime;
438-
zoomSpeed = Mathf.Clamp(zoomSpeed, 0, zoomSpeedMax);
437+
zoomSpeed = ZoomSpeedMax / (1 + Mathf.Pow(2.71828f, -ZoomAcceleration * (dynamicZoom - 0.5f))) * Time.deltaTime;
438+
zoomSpeed = Mathf.Clamp(zoomSpeed, 0, ZoomSpeedMax);
439439

440440
// Zoom in: Zoom toward zoom pivot + corrective pan motions
441441
if (zoomDir < 0)
@@ -453,23 +453,23 @@ private void UpdateZoom()
453453
protected Vector2 LimitScaling(Vector2 newScale)
454454
{
455455
// Clamp 2D scale vector to specified min and max values.
456-
if (newScale.x <= zoomMinScale)
456+
if (newScale.x <= ZoomMinScale)
457457
{
458-
newScale = new Vector2(zoomMinScale, (zoomMinScale / originalRatio.x) * originalRatio.y);
458+
newScale = new Vector2(ZoomMinScale, (ZoomMinScale / originalRatio.x) * originalRatio.y);
459459
}
460-
else if (newScale.x >= zoomMaxScale)
460+
else if (newScale.x >= ZoomMaxScale)
461461
{
462-
newScale = new Vector2(zoomMaxScale, (zoomMaxScale / originalRatio.x) * originalRatio.y);
462+
newScale = new Vector2(ZoomMaxScale, (ZoomMaxScale / originalRatio.x) * originalRatio.y);
463463
}
464464

465465
// Same for the y dimension
466-
if (newScale.y <= zoomMinScale)
466+
if (newScale.y <= ZoomMinScale)
467467
{
468-
newScale = new Vector2((zoomMinScale / originalRatio.y) * originalRatio.x, zoomMinScale);
468+
newScale = new Vector2((ZoomMinScale / originalRatio.y) * originalRatio.x, ZoomMinScale);
469469
}
470-
else if (newScale.y >= zoomMaxScale)
470+
else if (newScale.y >= ZoomMaxScale)
471471
{
472-
newScale = new Vector2((zoomMaxScale / originalRatio.y) * originalRatio.x, zoomMaxScale);
472+
newScale = new Vector2((ZoomMaxScale / originalRatio.y) * originalRatio.x, ZoomMaxScale);
473473
}
474474

475475
return newScale;

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_ScrollPanZoom/Scripts/PanZoom_RectTransf.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,11 @@ protected override void Start()
7878
{
7979
// Assigning values to base PanZoom class
8080
// Zoom
81-
base.zoomAcceleration = zoomAcceleration;
82-
base.zoomSpeedMax = zoomSpeedMax;
83-
base.zoomMinScale = zoomMinScale;
84-
base.zoomMaxScale = zoomMaxScale;
85-
base.zoomGestureEnabledOnStartup = zoomGestureEnabledOnStartup;
81+
ZoomAcceleration = zoomAcceleration;
82+
ZoomSpeedMax = zoomSpeedMax;
83+
ZoomMinScale = zoomMinScale;
84+
ZoomMaxScale = zoomMaxScale;
85+
ZoomGestureEnabledOnStartup = zoomGestureEnabledOnStartup;
8686
timeInSecondsToZoom = zoomTimeInSecToZoom;
8787

8888
// Pan
@@ -105,10 +105,10 @@ protected override void Start()
105105
protected override void Update()
106106
{
107107
UpdateValues(ref navRectTransf, rectTransfToNavigate);
108-
UpdateValues(ref base.zoomAcceleration, zoomAcceleration);
109-
UpdateValues(ref base.zoomSpeedMax, zoomSpeedMax);
110-
UpdateValues(ref base.zoomMinScale, zoomMinScale);
111-
UpdateValues(ref base.zoomMaxScale, zoomMaxScale);
108+
UpdateValues(ref ZoomAcceleration, zoomAcceleration);
109+
UpdateValues(ref ZoomSpeedMax, zoomSpeedMax);
110+
UpdateValues(ref ZoomMinScale, zoomMinScale);
111+
UpdateValues(ref ZoomMaxScale, zoomMaxScale);
112112
UpdateValues(ref timeInSecondsToZoom, zoomTimeInSecToZoom);
113113

114114
UpdateValues(ref autoGazePanIsActive, panAutoScrollIsActive);

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_ScrollPanZoom/Scripts/PanZoom_Texture.cs

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright (c) Microsoft Corporation. All rights reserved.
22
// Licensed under the MIT License. See LICENSE in the project root for license information.
33

4+
using Microsoft.MixedReality.Toolkit.Input;
45
using UnityEngine;
56

67
namespace Microsoft.MixedReality.Toolkit.Examples.Demos.EyeTracking
@@ -70,11 +71,11 @@ protected override void Start()
7071
// Assigning values to base PanZoom class
7172
textureRenderer = rendererOfTextureToBeNavigated;
7273

73-
base.zoomAcceleration = zoomAcceleration;
74-
base.zoomSpeedMax = zoomSpeedMax;
75-
base.zoomMinScale = zoomMinScale;
76-
base.zoomMaxScale = zoomMaxScale;
77-
base.zoomGestureEnabledOnStartup = zoomGestureEnabledOnStartup;
74+
ZoomAcceleration = zoomAcceleration;
75+
ZoomSpeedMax = zoomSpeedMax;
76+
ZoomMinScale = zoomMinScale;
77+
ZoomMaxScale = zoomMaxScale;
78+
ZoomGestureEnabledOnStartup = zoomGestureEnabledOnStartup;
7879
timeInSecondsToZoom = zoomTimeInSecToZoom;
7980

8081
autoGazePanIsActive = panAutoScrollIsActive;
@@ -90,10 +91,10 @@ protected override void Update()
9091
{
9192
UpdateValues(ref textureRenderer, rendererOfTextureToBeNavigated);
9293

93-
UpdateValues(ref base.zoomAcceleration, zoomAcceleration);
94-
UpdateValues(ref base.zoomSpeedMax, zoomSpeedMax);
95-
UpdateValues(ref base.zoomMinScale, zoomMinScale);
96-
UpdateValues(ref base.zoomMaxScale, zoomMaxScale);
94+
UpdateValues(ref ZoomAcceleration, zoomAcceleration);
95+
UpdateValues(ref ZoomSpeedMax, zoomSpeedMax);
96+
UpdateValues(ref ZoomMinScale, zoomMinScale);
97+
UpdateValues(ref ZoomMaxScale, zoomMaxScale);
9798
UpdateValues(ref timeInSecondsToZoom, zoomTimeInSecToZoom);
9899

99100
UpdateValues(ref autoGazePanIsActive, panAutoScrollIsActive);

Assets/MixedRealityToolkit.Examples/Demos/EyeTracking/Demo_ScrollPanZoom/Scripts/Target_MoveToCamera.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ protected override void Update()
4949

5050
protected override void OnEyeFocusStop()
5151
{
52+
if (isInNearFocusMode && (!inTransition))
53+
{
54+
OnSelect();
55+
}
5256
}
5357

5458
public void OnSelect()

0 commit comments

Comments
 (0)