Skip to content

Commit c213ffe

Browse files
author
Stephen Hodgson
committed
Addresses some PR changes
1 parent 70f3f1b commit c213ffe

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

Assets/HoloToolkit/BuildAndDeploy/Editor/BuildDeployTools.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,20 @@ public class BuildDeployTools
2424

2525
public static bool CanBuild()
2626
{
27-
if (PlayerSettings.GetScriptingBackend(BuildTargetGroup.WSA) == ScriptingImplementation.IL2CPP && Il2CppAvailable())
27+
if (PlayerSettings.GetScriptingBackend(BuildTargetGroup.WSA) == ScriptingImplementation.IL2CPP && IsIl2CppAvailable())
2828
{
2929
return true;
3030
}
3131

32-
return PlayerSettings.GetScriptingBackend(BuildTargetGroup.WSA) == ScriptingImplementation.WinRTDotNET && DotNetAvailable();
32+
return PlayerSettings.GetScriptingBackend(BuildTargetGroup.WSA) == ScriptingImplementation.WinRTDotNET && IsDotNetAvailable();
3333
}
3434

35-
public static bool DotNetAvailable()
35+
public static bool IsDotNetAvailable()
3636
{
3737
return Directory.Exists(EditorApplication.applicationContentsPath + "\\PlaybackEngines\\MetroSupport\\Managed\\UAP");
3838
}
3939

40-
public static bool Il2CppAvailable()
40+
public static bool IsIl2CppAvailable()
4141
{
4242
return Directory.Exists(EditorApplication.applicationContentsPath + "\\PlaybackEngines\\MetroSupport\\Managed\\il2cpp");
4343
}

Assets/HoloToolkit/BuildAndDeploy/Editor/BuildDeployWindow.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ private void OnGUI()
236236

237237
if (GUILayout.Button("Open Build Directory"))
238238
{
239-
Process.Start("explorer.exe", "/f /open," + BuildDeployPrefs.AbsoluteBuildDirectory);
239+
Process.Start(BuildDeployPrefs.AbsoluteBuildDirectory);
240240
}
241241

242242
GUI.enabled = true;
@@ -375,8 +375,8 @@ private void OnGUI()
375375

376376
// Build Platform (and save setting, if it's changed)
377377
string curBuildPlatformString = BuildDeployPrefs.BuildPlatform;
378-
379378
BuildPlatformEnum buildPlatformOption;
379+
380380
if (curBuildPlatformString.ToLower().Equals("x86"))
381381
{
382382
buildPlatformOption = BuildPlatformEnum.x86;

0 commit comments

Comments
 (0)