Skip to content

Commit d9398ca

Browse files
committed
Remove references to EditorUserBuildSettings.wsaSubtarget
1 parent ee79acd commit d9398ca

File tree

2 files changed

+33
-2
lines changed

2 files changed

+33
-2
lines changed

Assets/MRTK/Core/Utilities/BuildAndDeploy/UwpAppxBuildTools.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,11 @@ public static void AddCapabilities(IBuildInfo buildInfo, XElement rootElement =
531531
AddGazeInputCapability(rootElement);
532532
}
533533

534-
if (uwpBuildInfo.ResearchModeCapabilityEnabled && EditorUserBuildSettings.wsaSubtarget == WSASubtarget.HoloLens)
534+
if (uwpBuildInfo.ResearchModeCapabilityEnabled
535+
#if !UNITY_2021_2_OR_NEWER
536+
&& EditorUserBuildSettings.wsaSubtarget == WSASubtarget.HoloLens
537+
#endif // !UNITY_2021_2_OR_NEWER
538+
)
535539
{
536540
AddResearchModeCapability(rootElement);
537541
}

Assets/MRTK/Tools/BuildWindow/BuildDeployWindow.cs

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,19 @@ private enum BuildDeployTab
3434
DeployOptions
3535
}
3636

37+
#if UNITY_2021_2_OR_NEWER
38+
/// <summary>
39+
/// Matches the deprecated WSASubtarget.
40+
/// </summary>
41+
private enum UWPSubtarget
42+
{
43+
AnyDevice = 0,
44+
PC = 1,
45+
Mobile = 2,
46+
HoloLens = 3
47+
}
48+
#endif // UNITY_2021_2_OR_NEWER
49+
3750
#endregion Internal Types
3851

3952
#region Constants and Readonly Values
@@ -166,7 +179,13 @@ private static bool CanInstall
166179
get
167180
{
168181
bool canInstall = true;
169-
if (EditorUserBuildSettings.wsaSubtarget == WSASubtarget.HoloLens)
182+
if (
183+
#if UNITY_2021_2_OR_NEWER
184+
currentSubtarget == UWPSubtarget.HoloLens
185+
#else
186+
EditorUserBuildSettings.wsaSubtarget == WSASubtarget.HoloLens
187+
#endif // UNITY_2021_2_OR_NEWER
188+
)
170189
{
171190
canInstall = DevicePortalConnectionEnabled;
172191
}
@@ -271,6 +290,10 @@ private static bool UseRemoteTarget
271290
private static DeviceInfo lastTestConnectionTarget;
272291
private static DateTime? lastTestConnectionTime = null;
273292

293+
#if UNITY_2021_2_OR_NEWER
294+
private static UWPSubtarget currentSubtarget = UWPSubtarget.AnyDevice;
295+
#endif // UNITY_2021_2_OR_NEWER
296+
274297
#endregion Fields
275298

276299
#region Methods
@@ -380,7 +403,11 @@ private void RenderStandaloneBuildView()
380403

381404
private void RenderUnityBuildView()
382405
{
406+
#if UNITY_2021_2_OR_NEWER
407+
currentSubtarget = (UWPSubtarget)EditorGUILayout.Popup("Target Device", (int)currentSubtarget, TARGET_DEVICE_OPTIONS, GUILayout.Width(HALF_WIDTH));
408+
#else
383409
EditorUserBuildSettings.wsaSubtarget = (WSASubtarget)EditorGUILayout.Popup("Target Device", (int)EditorUserBuildSettings.wsaSubtarget, TARGET_DEVICE_OPTIONS, GUILayout.Width(HALF_WIDTH));
410+
#endif // UNITY_2021_2_OR_NEWER
384411

385412
#if !UNITY_2019_1_OR_NEWER
386413
var curScriptingBackend = PlayerSettings.GetScriptingBackend(BuildTargetGroup.WSA);

0 commit comments

Comments
 (0)