eliminate obsolete warnings related to unity 2019.3.0f6 changes

Author: davidkline-ms

Assets/MixedRealityToolkit.Providers/WindowsMixedReality/XR2018/WindowsMixedRealityDeviceManager.cs

@@ -80,7 +80,11 @@ public bool CheckCapability(MixedRealityCapability capability)
             }
             else // Pre-Windows 10 1903.
             {
+                // Ensure compatibility with the pre-2019.3 XR architecture for customers / platforms
+                // with legacy requirements.
+#pragma warning disable 0618
                 if (!UnityEngine.XR.WSA.HolographicSettings.IsDisplayOpaque)
+#pragma warning restore 0618
                 {
                     // HoloLens supports GGV hands
                     return (capability == MixedRealityCapability.GGVHand);

Assets/MixedRealityToolkit.Providers/XRSDK/Editor/ConfigurationChecker.meta

@@ -4,7 +4,9 @@
 using Microsoft.MixedReality.Toolkit.CameraSystem;
 using Microsoft.MixedReality.Toolkit.Utilities;
 using UnityEngine;
+#if SPATIALTRACKING_ENABLED
 using UnityEngine.SpatialTracking;
+#endif // SPATIALTRACKING_ENABLED
 
 namespace Microsoft.MixedReality.Toolkit.XRSDK
 {
@@ -31,7 +33,9 @@ public GenericXRSDKCameraSettings(
             BaseCameraSettingsProfile profile = null) : base(cameraSystem, name, priority, profile)
         { }
 
+#if SPATIALTRACKING_ENABLED
         private TrackedPoseDriver trackedPoseDriver = null;
+#endif // SPATIALTRACKING_ENABLED
 
         #region IMixedRealityCameraSettings
 
@@ -63,6 +67,6 @@ public override void Disable()
             base.Disable();
         }
 
-        #endregion IMixedRealityCameraSettings
+#endregion IMixedRealityCameraSettings
     }
 }

Assets/MixedRealityToolkit.Providers/XRSDK/Editor/ConfigurationChecker/Microsoft.MixedReality.Toolkit.Providers.XRSDK.ConfigurationChecker.asmdef

@@ -61,11 +61,15 @@ public override void Initialize()
         /// <inheritdoc/>
         protected override List<Vector3> GetBoundaryGeometry()
         {
+            // Ensure compatibility with the pre-2019.3 XR architecture for customers / platforms
+            // with legacy requirements.
+#pragma warning disable 0618
             // Boundaries are supported for Room Scale experiences only.
             if (XRDevice.GetTrackingSpaceType() != TrackingSpaceType.RoomScale)
             {
                 return null;
             }
+#pragma warning restore 0618
 
             // Get the boundary geometry.
             var boundaryGeometry = new List<Vector3>(0);
@@ -83,6 +87,9 @@ protected override List<Vector3> GetBoundaryGeometry()
         /// </summary>
         protected override void SetTrackingSpace()
         {
+            // Ensure compatibility with the pre-2019.3 XR architecture for customers / platforms
+            // with legacy requirements.
+#pragma warning disable 0618
             TrackingSpaceType trackingSpace;
 
             // In current versions of Unity, there are two types of tracking spaces. For boundaries, if the scale
@@ -112,6 +119,7 @@ protected override void SetTrackingSpace()
             {
                 Debug.LogWarning("Tracking space unable to be set.");
             }
+#pragma warning restore 0618
         }
     }
 }

Assets/MixedRealityToolkit.Providers/XRSDK/Editor/ConfigurationChecker/Microsoft.MixedReality.Toolkit.Providers.XRSDK.ConfigurationChecker.asmdef.meta

@@ -163,7 +163,12 @@ private void AllRootCanvases()
 
             EditorGUILayout.Space();
 
-            if (PlayerSettings.virtualRealitySupported && (m_RenderMode.enumValueIndex == (int)RenderMode.ScreenSpaceOverlay))
+            // Ensure compatibility with the pre-2019.3 XR architecture for customers / platforms
+            // with legacy requirements.
+#pragma warning disable 0618
+            if (PlayerSettings.virtualRealitySupported &&
+#pragma warning restore 0618
+                (m_RenderMode.enumValueIndex == (int)RenderMode.ScreenSpaceOverlay))
             {
                 EditorGUILayout.HelpBox("Using a render mode of ScreenSpaceOverlay while VR is enabled will cause the Canvas to continue to incur a rendering cost, even though the Canvas will not be visible in VR.", MessageType.Warning);
             }

Assets/MixedRealityToolkit.Providers/XRSDK/GenericXRSDKCameraSettings.cs

@@ -133,6 +133,9 @@ private void OnGUI()
             EditorGUILayout.HelpBox(PerformanceTargetDescriptions[(int)PerfTarget], MessageType.Info);
             EditorGUILayout.Space();
 
+            // Ensure compatibility with the pre-2019.3 XR architecture for customers / platforms
+            // with legacy requirements.
+#pragma warning disable 0618
             if (!PlayerSettings.virtualRealitySupported)
             {
                 EditorGUILayout.HelpBox("Virtual reality support is not enabled in player settings", MessageType.Error);
@@ -141,6 +144,7 @@ private void OnGUI()
                     PlayerSettings.virtualRealitySupported = true;
                 }
             }
+#pragma warning disable 0618
             else
             {
                 selectedToolbarIndex = GUILayout.Toolbar(selectedToolbarIndex, ToolbarTitles);

Assets/MixedRealityToolkit.Services/BoundarySystem/MixedRealityBoundarySystem.cs

@@ -81,7 +81,11 @@ private static void ShowProjectConfigurationDialog()
         /// </summary>
         private static void LogConfigurationWarnings()
         {
+            // Ensure compatibility with the pre-2019.3 XR architecture for customers / platforms
+            // with legacy requirements.
+#pragma warning disable 0618
             if (!PlayerSettings.virtualRealitySupported)
+#pragma warning restore 0618
             {
                 Debug.LogWarning("<b>Virtual reality supported</b> not enabled. Check <i>XR Settings</i> under <i>Player Settings</i>");
             }