Merge pull request #1351 from StephenHodgson/MRTK-CompilerCleanup

Compiler messages cleanup

Author: StephenHodgson

Assets/HoloToolkit/SpatialSound/Scripts/UAudioManager/UAudioManagerBase.cs

@@ -1,30 +1,38 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
+using Random = UnityEngine.Random;
 
 namespace HoloToolkit.Unity
 {
     /// <summary>
     /// UAudioManagerBase provides the base functionality for UAudioManager classes.
     /// </summary>
     /// <typeparam name="TEvent">The type of AudioEvent being managed.</typeparam>
+    /// <typeparam name="TBank"></typeparam>
     /// <remarks>The TEvent type specified must derive from AudioEvent.</remarks>
     public partial class UAudioManagerBase<TEvent, TBank> : MonoBehaviour where TEvent : AudioEvent, new() where TBank : AudioBank<TEvent>, new()
     {
         public TBank[] DefaultBanks = null;
 
         [SerializeField]
-        [System.Obsolete]
+        [Obsolete]
         protected TEvent[] Events = null;
 
         protected const float InfiniteLoop = -1;
         protected List<ActiveEvent> ActiveEvents;
 
 #if UNITY_EDITOR
+        // Temp disable this obsolete warning until we remove Events field.
+        // This public editor only field is here for enabling users to export audio events
+        // into banks for the new paradigm.
+#pragma warning disable 612
         public TEvent[] EditorEvents { get { return Events; } set { Events = value; } }
+#pragma warning restore 612
         public List<ActiveEvent> ProfilerEvents { get { return ActiveEvents; } }
 #endif
 
@@ -34,7 +42,7 @@ protected void Awake()
         {
             ActiveEvents = new List<ActiveEvent>();
             LoadedBanks = new List<TBank>(DefaultBanks.Length + 5);
-            for(int i=0; i<DefaultBanks.Length; i++)
+            for (int i = 0; i < DefaultBanks.Length; i++)
             {
                 LoadBank(DefaultBanks[i]);
             }

Assets/HoloToolkit/UX/Scripts/Lines/LineBaseEditor.cs

@@ -42,13 +42,13 @@ protected override void DrawCustomSceneGUI()
         // Draw dotted lines regardless of selection
         if (drawDottedLine)
         {
-            DrawDottedLine(line, linePreviewResolutionSelected);
+            DrawDottedLine(line, previewResolution);
         }
 
         // Draw rotations only on selected object
         if (drawLineRotations && selected)
         {
-            DrawLineRotations(line, linePreviewResolutionSelected);
+            DrawLineRotations(line, previewResolution);
         }
 
         // Draw up vectors only on selected object

Assets/HoloToolkit/UX/Scripts/Lines/Spline.cs

@@ -279,7 +279,7 @@ protected override void DrawCustomFooter()
 
                 Spline line = (Spline)target;
 
-                HashSet<int> overlappingPointIndexes = new HashSet<int>();
+                overlappingPointIndexes.Clear();
 
                 if (DrawSectionStart(line.name + " Points", "Point Editing"))
                 {