assorted stability and perf fixes

Author: David Kline (ANALOG)

Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/Pointers/BaseControllerPointer.cs

@@ -139,14 +139,34 @@ protected override async void Start()
         {
             base.Start();
 
-            if (lateRegisterTeleport)
+            if (lateRegisterTeleport && MixedRealityToolkit.Instance.ActiveProfile.IsTeleportSystemEnabled)
             {
-                await new WaitUntil(() => MixedRealityToolkit.TeleportSystem != null);
+                if (MixedRealityToolkit.TeleportSystem == null)
+                {
+                    await new WaitUntil(() => MixedRealityToolkit.TeleportSystem != null);
+
+                    // We've been destroyed during the await.
+                    if (this == null)
+                    {
+                        return;
+                    }
+                }
+
                 lateRegisterTeleport = false;
                 MixedRealityToolkit.TeleportSystem.Register(gameObject);
             }
 
-            await WaitUntilInputSystemValid;
+            if (MixedRealityToolkit.InputSystem == null)
+            {
+                await WaitUntilInputSystemValid;
+            }
+
+            // We've been destroyed during the await.
+            if (this == null)
+            {
+                return;
+            }
+
             SetCursor();
         }
 

Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/Pointers/LinePointer.cs

@@ -150,7 +150,7 @@ public override void OnPreRaycast()
             for (int i = 0; i < Rays.Length; i++)
             {
                 Vector3 currentPoint = lineBase.GetUnClampedPoint(stepSize * (i + 1));
-                Rays[i] = new RayStep(lastPoint, currentPoint);
+                Rays[i].UpdateRayStep(ref lastPoint, ref currentPoint);
                 lastPoint = currentPoint;
             }
         }

Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/Pointers/TeleportPointer.cs

@@ -146,7 +146,7 @@ public override void OnPreRaycast()
             for (int i = 0; i < Rays.Length; i++)
             {
                 Vector3 currentPoint = LineBase.GetUnClampedPoint(stepSize * (i + 1));
-                Rays[i] = new RayStep(lastPoint, currentPoint);
+                Rays[i].UpdateRayStep(ref lastPoint, ref currentPoint);
                 lastPoint = currentPoint;
             }
 

Assets/MixedRealityToolkit.Services/InputSystem/FocusProvider.cs

@@ -252,9 +252,12 @@ public void UpdateFocusLockedHit()
                     pointerWasLocked = true;
                 }
 
-                // In case the focused object is moving, we need to update the focus point based on the object's new transform.
-                focusDetails.Point = focusDetails.Object.transform.TransformPoint(pointLocalSpace);
-                focusDetails.Normal = focusDetails.Object.transform.TransformDirection(normalLocalSpace);
+                if (focusDetails.Object != null && focusDetails.Object.transform != null)
+                {
+                    // In case the focused object is moving, we need to update the focus point based on the object's new transform.
+                    focusDetails.Point = focusDetails.Object.transform.TransformPoint(pointLocalSpace);
+                    focusDetails.Normal = focusDetails.Object.transform.TransformDirection(normalLocalSpace);
+                }
 
                 StartPoint = Pointer.Rays[0].Origin;
 

Assets/MixedRealityToolkit.Services/InputSystem/GazeProvider.cs

@@ -199,7 +199,8 @@ public override void OnPreRaycast()
                     newGazeNormal = stabilizer.StableRay.direction;
                 }
 
-                Rays[0].UpdateRayStep(newGazeOrigin, newGazeOrigin + (newGazeNormal * pointerExtent));
+                Vector3 endPoint = newGazeOrigin + (newGazeNormal * pointerExtent);
+                Rays[0].UpdateRayStep(ref newGazeOrigin, ref endPoint);
 
                 gazeProvider.HitPosition = Rays[0].Origin + (gazeProvider.lastHitDistance * Rays[0].Direction);
             }

Assets/MixedRealityToolkit.Services/InputSystem/InputSystemGlobalListener.cs

@@ -28,7 +28,17 @@ protected virtual async void Start()
         {
             if (lateInitialize)
             {
-                await WaitUntilInputSystemValid;
+                if (MixedRealityToolkit.InputSystem == null)
+                {
+                    await WaitUntilInputSystemValid;
+                }
+
+                if (this == null)
+                {
+                    // We've been destroyed during the await.
+                    return;
+                }
+
                 lateInitialize = false;
                 MixedRealityToolkit.InputSystem.Register(gameObject);
             }

Assets/MixedRealityToolkit/Definitions/Physics/RayStep.cs

@@ -31,7 +31,13 @@ public Vector3 GetPoint(float distance)
             return Vector3.MoveTowards(Origin, Terminus, distance);
         }
 
-        public void UpdateRayStep(Vector3 origin, Vector3 terminus)
+        /// <summary>
+        /// Update current raystep with new origin and terminus points. 
+        /// Pass by ref to avoid unnecessary struct copy into function since values will be copied anyways locally
+        /// </summary>
+        /// <param name="origin">beginning of raystep origin</param>
+        /// <param name="terminus">end of raystep</param>
+        public void UpdateRayStep(ref Vector3 origin, ref Vector3 terminus)
         {
             Origin = origin;
             Terminus = terminus;

Assets/MixedRealityToolkit/Utilities/CameraCache.cs

@@ -66,7 +66,10 @@ public static Camera Main
         /// <param name="newMain">New main camera to cache</param>
         public static Camera Refresh(Camera newMain)
         {
-            Debug.Assert(newMain != null, "No camera with MainCamera tag found in scene.  Did you forget to tag your camera?");
+            if (newMain == null)
+            {
+                Debug.LogWarning("A null camera was passed into CameraCache.Refresh()");
+            }
             return cachedCamera = newMain;
         }
     }