Removed isRecording field. The dictation system already performs that check internally when starting/stoping recording.

luval-microsoft · luval-microsoft · commit dec6b2683868 · 2019-04-03T10:08:20.000+01:00
diff --git a/Assets/MixedRealityToolkit.SDK/Features/Input/Handlers/DictationHandler.cs b/Assets/MixedRealityToolkit.SDK/Features/Input/Handlers/DictationHandler.cs
@@ -51,7 +51,6 @@ public class StringUnityEvent : UnityEvent<string> { }
         /// </summary>
         public StringUnityEvent OnDictationError;
 
-        private bool isRecording = false;
         private IMixedRealityDictationSystem dictationSystem;
 
         /// <summary>
@@ -61,7 +60,6 @@ public void StartRecording()
         {
             if (dictationSystem != null)
             {
-                isRecording = true;
                 dictationSystem.StartRecording(gameObject, initialSilenceTimeout, autoSilenceTimeout, recordingTime);
             }
         }
@@ -74,7 +72,6 @@ public void StopRecording()
             if (dictationSystem != null)
             {
                 dictationSystem.StopRecording();
-                isRecording = false;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,6 @@ public class StringUnityEvent : UnityEvent<string> { }`
`51`	`51`	`/// </summary>`
`52`	`52`	`public StringUnityEvent OnDictationError;`
`53`	`53`
`54`		`- private bool isRecording = false;`
`55`	`54`	`private IMixedRealityDictationSystem dictationSystem;`
`56`	`55`
`57`	`56`	`/// <summary>`
`@@ -61,7 +60,6 @@ public void StartRecording()`
`61`	`60`	`{`
`62`	`61`	`if (dictationSystem != null)`
`63`	`62`	`{`
`64`		`- isRecording = true;`
`65`	`63`	`dictationSystem.StartRecording(gameObject, initialSilenceTimeout, autoSilenceTimeout, recordingTime);`
`66`	`64`	`}`
`67`	`65`	`}`
`@@ -74,7 +72,6 @@ public void StopRecording()`
`74`	`72`	`if (dictationSystem != null)`
`75`	`73`	`{`
`76`	`74`	`dictationSystem.StopRecording();`
`77`		`- isRecording = false;`
`78`	`75`	`}`
`79`	`76`	`}`
`80`	`77`