Skip to content

Commit e1d1a43

Browse files
authored
Merge pull request #9740 from CDiaz-MS/pipeline_2020
Update pr.yaml and add Unity 2020 Pipeline
2 parents 9b31986 + 4653330 commit e1d1a43

File tree

4 files changed

+37
-6
lines changed

4 files changed

+37
-6
lines changed

Assets/MRTK/Tests/PlayModeTests/BaseCursorTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,8 @@ public IEnumerator ArticulatedCursorState()
138138
// Move back so the cursor is no longer on the object
139139
yield return hand.MoveTo(offObjectPos, numFramesPerMove);
140140
VerifyCursorStateFromPointers(inputSystem.FocusProvider.GetPointers<ShellHandRayPointer>(), CursorStateEnum.Interact);
141+
142+
yield return null;
141143
}
142144

143145
[UnityTest]

pipelines/config/settings.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ variables:
22
# Unity version on AIPMR build agents
33
Unity2018Version: Unity2018.4.26f1
44
Unity2019Version: Unity2019.4.8f1
5+
Unity2020Version: Unity2020.3.5f1
56
# Unity version on internal build agents (release builds)
67
Unity2018VersionInternal: Unity2018.4.26f1
78
Unity2019VersionInternal: Unity2019.4.17f1

pipelines/pr-2019.yaml renamed to pipelines/pr-2020.yaml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,26 @@
1-
# Build for PR validation.
1+
# Build for PR validation via Unity 2020.
22

33
variables:
44
- template: config/settings.yml
55

66
jobs:
7-
- job: PRValidation
7+
- job: CodeValidation
8+
pool:
9+
vmImage: windows-2019
10+
steps:
11+
- template: templates/validation.yml
12+
parameters:
13+
# For mrtk_pr builds, validation scripts (code and docs) should be scoped to only
14+
# the set of changed files, so that we can save some time. There's no need to
15+
# check unchanged files for code style/doc style violations.
16+
scopedValidation: true
17+
18+
- job: Unity2020Validation
819
timeoutInMinutes: 90
920
pool:
1021
name: On-Prem Unity
1122
demands:
12-
- ${{ variables.Unity2019Version }}
23+
- ${{ variables.Unity2020Version }}
1324
- COG-UnityCache-WUS2-01
1425
- SDK_18362 -equals TRUE
1526
- VS2019 -equals TRUE
@@ -27,6 +38,6 @@ jobs:
2738
buildUWPX86: false
2839
buildUWPArm: false
2940
buildUWPDotNet: false
30-
UnityVersion: $(Unity2019Version)
41+
UnityVersion: $(Unity2020Version)
3142

3243
- template: templates/end.yml

pipelines/pr.yaml

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Build for PR validation.
1+
# Build for PR validation via Unity 2018 and 2019
22

33
variables:
44
- template: config/settings.yml
@@ -15,7 +15,7 @@ jobs:
1515
# check unchanged files for code style/doc style violations.
1616
scopedValidation: true
1717

18-
- job: UnityValidation
18+
- job: Unity2018Validation
1919
timeoutInMinutes: 90
2020
pool:
2121
name: On-Prem Unity
@@ -38,4 +38,21 @@ jobs:
3838
buildUWPArm: false
3939
buildUWPDotNet: false
4040
UnityVersion: $(Unity2018Version)
41+
42+
- job: Unity2019Validation
43+
timeoutInMinutes: 90
44+
pool:
45+
name: On-Prem Unity
46+
demands:
47+
- ${{ variables.Unity2019Version }}
48+
- COG-UnityCache-WUS2-01
49+
- SDK_18362 -equals TRUE
50+
- VS2019 -equals TRUE
51+
steps:
52+
- template: templates/common.yml
53+
parameters:
54+
buildUWPX86: false
55+
buildUWPArm: false
56+
buildUWPDotNet: false
57+
UnityVersion: $(Unity2019Version)
4158
- template: templates/end.yml

0 commit comments

Comments
 (0)