Fixed issue where hand joint lookup would throw dictionary exceptions for visualizers (#10574)

* fixed issue where hand joint lookup would throw dictionary exceptions

* whitepsace fix

Author: RogPodge

Assets/MRTK/Core/Providers/Hands/BaseHandVisualizer.cs

@@ -126,6 +126,11 @@ public virtual void OnHandJointsUpdated(InputEventData<IDictionary<TrackedHandJo
                 for (int i = 1; i < ArticulatedHandPose.JointCount; i++)
                 {
                     TrackedHandJoint handJoint = (TrackedHandJoint)i;
+                    // Skip this hand joint if the event data doesn't have an entry for it
+                    if (!eventData.InputData.ContainsKey(handJoint))
+                    {
+                        continue;
+                    }
                     MixedRealityPose handJointPose = eventData.InputData[handJoint];
                     Transform jointTransform = jointsArray[i];
 

Assets/MRTK/Providers/Oculus/XRSDK/MRTK-Quest/Editor/OculusXRSDKHandtrackingConfigurationChecker.cs

@@ -211,9 +211,10 @@ internal static void ReconcileOculusIntegrationDefine(bool oculusIntegrationPres
         }
 
         /// <summary>
-        /// Adds warnings to the nowarn line in the csc.rsp file located at the root of assets.  Warning 618 and 649 are added to the nowarn line because if
+        /// Adds warnings to the nowarn line in the csc.rsp file located at the root of assets.  Warning 414, 618 and 649 are added to the nowarn line because if
         /// the MRTK source is from the repo, warnings are converted to errors. Warnings are not converted to errors if the MRTK source is from the unity packages.
-        /// Warning 618 and 649 are logged when Oculus Integration is imported into the project, 618 is the obsolete warning and 649 is a null on start warning.
+        /// Warning 414, 618 and 649 are logged when Oculus Integration is imported into the project, 414 is an unsued variable warning,
+        /// 618 is the obsolete warning and 649 is a null on start warning.
         /// </summary>
         static void UpdateCSC()
         {
@@ -229,6 +230,7 @@ static void UpdateCSC()
             // List of new warning numbers to add to the csc file
             List<string> warningNumbersToAdd = new List<string>()
             {
+                "414",
                 "618",
                 "649"
             };

Assets/MRTK/Providers/Oculus/XRSDK/MRTK-Quest/Scripts/Input/Controllers/OculusHand.cs

@@ -268,7 +268,7 @@ protected bool UpdateHandData(OVRHand ovrHand, OVRSkeleton ovrSkeleton)
 
                 UpdatePalm();
             }
-            
+
             HandDefinition?.UpdateHandJoints(jointPoses);
 
             // Note: After some testing, it seems when moving your hand fast, Oculus's pinch estimation data gets frozen, which leads to stuck pinches.
@@ -371,8 +371,6 @@ protected void UpdatePalm()
 
         protected void UpdateJointPose(TrackedHandJoint joint, Vector3 position, Quaternion rotation)
         {
-            Vector3 jointPosition = position;
-
             // TODO Figure out kalman filter coefficients to get good quality smoothing
 #if LATER
             if (joint == TrackedHandJoint.IndexTip)
@@ -385,7 +383,7 @@ protected void UpdateJointPose(TrackedHandJoint joint, Vector3 position, Quatern
             }
 #endif
 
-            MixedRealityPose pose = new MixedRealityPose(jointPosition, rotation);
+            MixedRealityPose pose = new MixedRealityPose(position, rotation);
             if (!jointPoses.ContainsKey(joint))
             {
                 jointPoses.Add(joint, pose);

Assets/MRTK/SDK/Features/UX/Scripts/RiggedHandVisualizer/RiggedHandVisualizer.cs

@@ -319,6 +319,11 @@ public override void OnHandJointsUpdated(InputEventData<IDictionary<TrackedHandJ
                     for (int i = 1; i < ArticulatedHandPose.JointCount; i++)
                     {
                         TrackedHandJoint handJoint = (TrackedHandJoint)i;
+                        // Skip this hand joint if the event data doesn't have an entry for it
+                        if (!eventData.InputData.ContainsKey(handJoint))
+                        {
+                            continue;
+                        }
                         MixedRealityPose handJointPose = eventData.InputData[handJoint];
                         Transform jointTransform = riggedVisualJointsArray[i];