Skip to content

Commit f49902b

Browse files
author
David Kline
authored
Merge pull request #9897 from keveleigh/fix-android-build
Fix building OpenXR for Android
2 parents b7c2694 + 3c02983 commit f49902b

File tree

5 files changed

+38
-38
lines changed

5 files changed

+38
-38
lines changed

Assets/MRTK/Providers/OpenXR/Scripts/MicrosoftArticulatedHand.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
using UnityEngine;
1111
using UnityEngine.XR;
1212

13-
#if MSFT_OPENXR
13+
#if MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
1414
#if MSFT_OPENXR_0_1_3_OR_NEWER
1515
using FrameTime = Microsoft.MixedReality.OpenXR.FrameTime;
1616
#else
@@ -27,7 +27,7 @@
2727
using HandTracker = Microsoft.MixedReality.OpenXR.Preview.HandTracker;
2828
using Preview = Microsoft.MixedReality.OpenXR.Preview;
2929
#endif // MSFT_OPENXR_0_2_0_OR_NEWER
30-
#endif // MSFT_OPENXR
30+
#endif // MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
3131

3232
namespace Microsoft.MixedReality.Toolkit.XRSDK.OpenXR
3333
{
@@ -51,13 +51,13 @@ public MicrosoftArticulatedHand(TrackingState trackingState, Handedness controll
5151
handMeshProvider = controllerHandedness == Handedness.Left ? OpenXRHandMeshProvider.Left : OpenXRHandMeshProvider.Right;
5252
handMeshProvider?.SetInputSource(inputSource);
5353

54-
#if MSFT_OPENXR
54+
#if MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
5555
#if MSFT_OPENXR_0_2_0_OR_NEWER
5656
handTracker = controllerHandedness == Handedness.Left ? HandTracker.Left : HandTracker.Right;
5757
#else
5858
handTracker = new HandTracker(controllerHandedness == Handedness.Left ? Preview.Handedness.Left : Preview.Handedness.Right, Preview.HandPoseType.Tracked);
5959
#endif
60-
#endif // MSFT_OPENXR
60+
#endif // MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
6161
}
6262

6363
private readonly ArticulatedHandDefinition handDefinition;
@@ -69,14 +69,14 @@ public MicrosoftArticulatedHand(TrackingState trackingState, Handedness controll
6969
private Quaternion currentPointerRotation = Quaternion.identity;
7070
private MixedRealityPose currentPointerPose = MixedRealityPose.ZeroIdentity;
7171

72-
#if MSFT_OPENXR
72+
#if MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
7373
private static readonly HandJoint[] HandJoints = Enum.GetValues(typeof(HandJoint)) as HandJoint[];
7474
private readonly HandTracker handTracker = null;
7575
private readonly HandJointLocation[] locations = new HandJointLocation[HandTracker.JointCount];
7676
#else
7777
private static readonly HandFinger[] handFingers = Enum.GetValues(typeof(HandFinger)) as HandFinger[];
7878
private readonly List<Bone> fingerBones = new List<Bone>();
79-
#endif // MSFT_OPENXR
79+
#endif // MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
8080

8181
#region IMixedRealityHand Implementation
8282

@@ -257,7 +257,7 @@ private void UpdateHandData(InputDevice inputDevice)
257257
{
258258
handMeshProvider?.UpdateHandMesh();
259259

260-
#if MSFT_OPENXR
260+
#if MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
261261
if (handTracker != null && handTracker.TryLocateHandJoints(FrameTime.OnUpdate, locations))
262262
{
263263
foreach (HandJoint handJoint in HandJoints)
@@ -295,14 +295,14 @@ private void UpdateHandData(InputDevice inputDevice)
295295
}
296296
}
297297
}
298-
#endif // MSFT_OPENXR
298+
#endif // MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
299299

300300
handDefinition?.UpdateHandJoints(unityJointPoses);
301301
}
302302
}
303303
}
304304

305-
#if MSFT_OPENXR
305+
#if MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
306306
private TrackedHandJoint ConvertToTrackedHandJoint(HandJoint handJoint)
307307
{
308308
switch (handJoint)
@@ -381,6 +381,6 @@ private TrackedHandJoint ConvertToTrackedHandJoint(HandFinger finger, int index)
381381
default: return TrackedHandJoint.None;
382382
}
383383
}
384-
#endif // MSFT_OPENXR
384+
#endif // MSFT_OPENXR && (UNITY_STANDALONE_WIN || UNITY_WSA)
385385
}
386386
}

Assets/MRTK/Providers/OpenXR/Scripts/MicrosoftControllerModelProvider.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
using System.Threading.Tasks;
55
using UnityEngine;
66

7-
#if MSFT_OPENXR_0_9_4_OR_NEWER
7+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
88
using Microsoft.MixedReality.OpenXR;
99
using Microsoft.MixedReality.Toolkit.Utilities.Gltf.Serialization;
1010
using System.Collections.Generic;
11-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
11+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
1212

1313
namespace Microsoft.MixedReality.Toolkit.XRSDK.OpenXR
1414
{
@@ -19,15 +19,15 @@ internal class MicrosoftControllerModelProvider
1919
{
2020
public MicrosoftControllerModelProvider(Utilities.Handedness handedness)
2121
{
22-
#if MSFT_OPENXR_0_9_4_OR_NEWER
22+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
2323
controllerModelProvider = handedness == Utilities.Handedness.Left ? ControllerModel.Left : ControllerModel.Right;
24-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
24+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
2525
}
2626

27-
#if MSFT_OPENXR_0_9_4_OR_NEWER
27+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
2828
private static readonly Dictionary<ulong, GameObject> ControllerModelDictionary = new Dictionary<ulong, GameObject>(2);
2929
private readonly ControllerModel controllerModelProvider;
30-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
30+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
3131

3232
// Disables "This async method lacks 'await' operators and will run synchronously." when the correct OpenXR package isn't installed
3333
#pragma warning disable CS1998
@@ -39,7 +39,7 @@ public async Task<GameObject> TryGenerateControllerModelFromPlatformSDK()
3939
{
4040
GameObject gltfGameObject = null;
4141

42-
#if MSFT_OPENXR_0_9_4_OR_NEWER
42+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
4343
if (!controllerModelProvider.TryGetControllerModelKey(out ulong modelKey))
4444
{
4545
Debug.LogError("Failed to obtain controller model key from platform.");
@@ -76,7 +76,7 @@ public async Task<GameObject> TryGenerateControllerModelFromPlatformSDK()
7676
ControllerModelDictionary.Add(modelKey, gltfGameObject);
7777
}
7878
}
79-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
79+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
8080

8181
return gltfGameObject;
8282
}

Assets/MRTK/Providers/OpenXR/Scripts/OpenXRHandMeshProvider.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// Copyright (c) Microsoft Corporation.
22
// Licensed under the MIT License.
33

4-
#if MSFT_OPENXR_0_2_0_OR_NEWER
4+
#if MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
55
using Microsoft.MixedReality.OpenXR;
66
using System.Collections.Generic;
77
using UnityEngine;
8-
#endif // MSFT_OPENXR_0_2_0_OR_NEWER
8+
#endif // MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
99

1010
using Microsoft.MixedReality.Toolkit.Input;
1111
using Unity.Profiling;
@@ -21,23 +21,23 @@ internal class OpenXRHandMeshProvider
2121
/// The user's left hand.
2222
/// </summary>
2323
public static OpenXRHandMeshProvider Left { get; } =
24-
#if MSFT_OPENXR_0_2_0_OR_NEWER
24+
#if MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
2525
new OpenXRHandMeshProvider(HandMeshTracker.Left, Utilities.Handedness.Left);
2626
#else
2727
null;
28-
#endif // MSFT_OPENXR_0_2_0_OR_NEWER
28+
#endif // MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
2929

3030
/// <summary>
3131
/// The user's right hand.
3232
/// </summary>
3333
public static OpenXRHandMeshProvider Right { get; } =
34-
#if MSFT_OPENXR_0_2_0_OR_NEWER
34+
#if MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
3535
new OpenXRHandMeshProvider(HandMeshTracker.Right, Utilities.Handedness.Right);
3636
#else
3737
null;
38-
#endif // MSFT_OPENXR_0_2_0_OR_NEWER
38+
#endif // MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
3939

40-
#if MSFT_OPENXR_0_2_0_OR_NEWER
40+
#if MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
4141
private OpenXRHandMeshProvider(HandMeshTracker handMeshTracker, Utilities.Handedness handedness)
4242
{
4343
this.handMeshTracker = handMeshTracker;
@@ -57,7 +57,7 @@ private OpenXRHandMeshProvider(HandMeshTracker handMeshTracker, Utilities.Handed
5757
private readonly List<int> triangles = new List<int>();
5858

5959
private Vector2[] handMeshUVs = null;
60-
#endif // MSFT_OPENXR_0_2_0_OR_NEWER
60+
#endif // MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
6161

6262
private IMixedRealityInputSource inputSource = null;
6363

@@ -74,7 +74,7 @@ private OpenXRHandMeshProvider(HandMeshTracker handMeshTracker, Utilities.Handed
7474
/// </summary>
7575
public void UpdateHandMesh()
7676
{
77-
#if MSFT_OPENXR_0_2_0_OR_NEWER
77+
#if MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
7878
using (UpdateHandMeshPerfMarker.Auto())
7979
{
8080
MixedRealityInputSystemProfile inputSystemProfile = CoreServices.InputSystem?.InputSystemProfile;
@@ -154,7 +154,7 @@ private Vector2[] InitializeUVs(Vector3[] neutralPoseVertices)
154154
}
155155

156156
return uvs;
157-
#endif // MSFT_OPENXR_0_2_0_OR_NEWER
157+
#endif // MSFT_OPENXR_0_2_0_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
158158
}
159159
}
160160
}

Assets/MRTK/Providers/OpenXR/Scripts/OpenXRReprojectionUpdater.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33

44
using UnityEngine;
55

6-
#if MSFT_OPENXR_0_9_4_OR_NEWER
6+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
77
using Microsoft.MixedReality.OpenXR;
88
using System.Linq;
9-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
9+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
1010

1111
namespace Microsoft.MixedReality.Toolkit.XRSDK.OpenXR
1212
{
@@ -17,7 +17,7 @@ public class OpenXRReprojectionUpdater : MonoBehaviour
1717
/// </summary>
1818
public HolographicReprojectionMethod ReprojectionMethod { get; set; }
1919

20-
#if MSFT_OPENXR_0_9_4_OR_NEWER
20+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
2121
private ReprojectionSettings reprojectionSettings = default;
2222

2323
private void OnPostRender()
@@ -54,6 +54,6 @@ private ReprojectionMode MapMRTKReprojectionMethodToOpenXR(HolographicReprojecti
5454
return ReprojectionMode.NoReprojection;
5555
}
5656
}
57-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
57+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
5858
}
5959
}

Assets/MRTK/Providers/OpenXR/Scripts/OpenXRSpatialAwarenessMeshObserver.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
using Microsoft.MixedReality.Toolkit.Utilities;
66
using UnityEngine;
77

8-
#if MSFT_OPENXR_0_9_4_OR_NEWER
8+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
99
using Microsoft.MixedReality.OpenXR;
1010
using Unity.Profiling;
1111
using UnityEngine.XR.OpenXR;
12-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
12+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
1313

1414
namespace Microsoft.MixedReality.Toolkit.XRSDK.OpenXR
1515
{
@@ -40,13 +40,13 @@ public OpenXRSpatialAwarenessMeshObserver(
4040
{ }
4141

4242
protected override bool? IsActiveLoader =>
43-
#if MSFT_OPENXR_0_9_4_OR_NEWER
43+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
4444
LoaderHelpers.IsLoaderActive<OpenXRLoaderBase>();
4545
#else
4646
false;
47-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
47+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
4848

49-
#if MSFT_OPENXR_0_9_4_OR_NEWER
49+
#if MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
5050
private static readonly ProfilerMarker ApplyUpdatedMeshDisplayOptionPerfMarker = new ProfilerMarker($"[MRTK] {nameof(OpenXRSpatialAwarenessMeshObserver)}.ApplyUpdatedMeshDisplayOption");
5151

5252
/// <inheritdoc/>
@@ -107,6 +107,6 @@ private VisualMeshLevelOfDetail MapMRTKLevelOfDetailToOpenXR(SpatialAwarenessMes
107107
return VisualMeshLevelOfDetail.Coarse;
108108
}
109109
}
110-
#endif // MSFT_OPENXR_0_9_4_OR_NEWER
110+
#endif // MSFT_OPENXR_0_9_4_OR_NEWER && (UNITY_STANDALONE_WIN || UNITY_WSA)
111111
}
112112
}

0 commit comments

Comments
 (0)