Fixing inconsistency with max-component usage in handle collider construction

Author: Zee2

Assets/MRTK/SDK/Features/UX/Scripts/BoundsControl/Visuals/PerAxisHandles.cs

@@ -95,7 +95,8 @@ private void UpdateColliderType()
                 {
                     // attach new collider
                     var handleBounds = VisualUtils.GetMaxBounds(GetVisual(handle).gameObject);
-                    var invScale = handleBounds.size.x == 0.0f ? 0.0f : config.HandleSize / handleBounds.size.x;
+                    float maxDim = VisualUtils.GetMaxComponent(handleBounds.size);
+                    float invScale = maxDim == 0.0f ? 0.0f : config.HandleSize / maxDim;
                     Vector3 colliderSizeScaled = handleBounds.size * invScale;
                     Vector3 colliderCenterScaled = handleBounds.center * invScale;
                     if (config.HandlePrefabColliderType == HandlePrefabCollider.Box)
@@ -109,7 +110,7 @@ private void UpdateColliderType()
                     {
                         SphereCollider sphere = handle.gameObject.AddComponent<SphereCollider>();
                         sphere.center = colliderCenterScaled;
-                        sphere.radius = colliderSizeScaled.x * 0.5f;
+                        sphere.radius = VisualUtils.GetMaxComponent(colliderSizeScaled) * 0.5f;
                         sphere.radius += VisualUtils.GetMaxComponent(config.ColliderPadding);
                     }
                 }
@@ -236,7 +237,8 @@ protected override void RecreateVisuals()
 
         protected override void UpdateColliderBounds(Transform handle, Vector3 visualSize)
         {
-            var invScale = visualSize.x == 0.0f ? 0.0f : config.HandleSize / visualSize.x;
+            float maxDim = VisualUtils.GetMaxComponent(visualSize);
+            float invScale = maxDim == 0.0f ? 0.0f : config.HandleSize / maxDim;
             GetVisual(handle).transform.localScale = new Vector3(invScale, invScale, invScale);
             Vector3 colliderSizeScaled = visualSize * invScale;
             if (config.HandlePrefabColliderType == HandlePrefabCollider.Box)
@@ -248,7 +250,7 @@ protected override void UpdateColliderBounds(Transform handle, Vector3 visualSiz
             else
             {
                 SphereCollider collider = handle.gameObject.GetComponent<SphereCollider>();
-                collider.radius = colliderSizeScaled.x * 0.5f;
+                collider.radius = VisualUtils.GetMaxComponent(colliderSizeScaled) * 0.5f;
                 collider.radius += VisualUtils.GetMaxComponent(config.ColliderPadding);
             }
         }

Assets/MRTK/SDK/Features/UX/Scripts/BoundsControl/Visuals/ProximityEffect/ProximityEffect.cs

@@ -276,8 +276,9 @@ private void ScaleObject(ProximityState state, Transform scaleVisual, float obje
                     weight = lerp ? config.CloseGrowRate : 1.0f;
                     break;
             }
-
-            float newLocalScale = (scaleVisual.localScale.x * (1.0f - weight)) + (objectSize * targetScale * weight);
+            
+            float maxScaleAxis = VisualUtils.GetMaxComponent(scaleVisual.localScale);
+            float newLocalScale = (maxScaleAxis * (1.0f - weight)) + (objectSize * targetScale * weight);
             scaleVisual.localScale = new Vector3(newLocalScale, newLocalScale, newLocalScale);
         }