Skip to content

Commit fa86b66

Browse files
authored
Merge pull request #9695 from MaxWang-MS/build_scene_fix
Only use scenes specified in command line when flags are present
2 parents d73d6cd + af35260 commit fa86b66

File tree

1 file changed

+22
-2
lines changed

1 file changed

+22
-2
lines changed

Assets/MRTK/Core/Utilities/BuildAndDeploy/UnityPlayerBuildTools.cs

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,10 @@ public static string GetProjectPath()
215215
public static void ParseBuildCommandLine(ref IBuildInfo buildInfo)
216216
{
217217
string[] arguments = Environment.GetCommandLineArgs();
218+
219+
// Boolean used to track whether builfInfo contains scenes that are not specified by command line arguments.
220+
// These non command line arugment scenes should be overwritten by those specified in the command line.
221+
bool buildInfoContainsNonCommandLineScene = buildInfo.Scenes.Count() > 0;
218222

219223
for (int i = 0; i < arguments.Length; ++i)
220224
{
@@ -224,13 +228,29 @@ public static void ParseBuildCommandLine(ref IBuildInfo buildInfo)
224228
buildInfo.AutoIncrement = true;
225229
break;
226230
case "-sceneList":
227-
buildInfo.Scenes = buildInfo.Scenes.Union(SplitSceneList(arguments[++i]));
231+
if (buildInfoContainsNonCommandLineScene)
232+
{
233+
buildInfo.Scenes = SplitSceneList(arguments[++i]);
234+
buildInfoContainsNonCommandLineScene = false;
235+
}
236+
else
237+
{
238+
buildInfo.Scenes = buildInfo.Scenes.Union(SplitSceneList(arguments[++i]));
239+
}
228240
break;
229241
case "-sceneListFile":
230242
string path = arguments[++i];
231243
if (File.Exists(path))
232244
{
233-
buildInfo.Scenes = buildInfo.Scenes.Union(SplitSceneList(File.ReadAllText(path)));
245+
if (buildInfoContainsNonCommandLineScene)
246+
{
247+
buildInfo.Scenes = SplitSceneList(File.ReadAllText(path));
248+
buildInfoContainsNonCommandLineScene = false;
249+
}
250+
else
251+
{
252+
buildInfo.Scenes = buildInfo.Scenes.Union(SplitSceneList(File.ReadAllText(path)));
253+
}
234254
}
235255
else
236256
{

0 commit comments

Comments
 (0)