Skip to content

Commit fb7c736

Browse files
committed
Merge pull request #10330 from jverral/user/joverral/eyesmooth_nit
Perf nit: Check if anyone is hooked into events before doing math to…
1 parent f7a1c6c commit fb7c736

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

Assets/MRTK/Core/Utilities/EyeGazeSmoother.cs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,16 +124,16 @@ private bool IsSaccading(Ray rayOld, Ray rayNew)
124124
{
125125
Vector2 hv1 = new Vector2(v1.x, 0);
126126
Vector2 hv2 = new Vector2(v2.x, 0);
127-
if (Vector2.Angle(hv1, hv2) > saccadeThreshInDegree)
127+
if (OnSaccadeX != null && Vector2.Angle(hv1, hv2) > saccadeThreshInDegree)
128128
{
129-
PostOnSaccadeHorizontally();
129+
OnSaccadeX.Invoke();
130130
}
131131

132132
Vector2 vv1 = new Vector2(0, v1.y);
133133
Vector2 vv2 = new Vector2(0, v2.y);
134-
if (Vector2.Angle(vv1, vv2) > saccadeThreshInDegree)
134+
if (OnSaccadeY != null && Vector2.Angle(vv1, vv2) > saccadeThreshInDegree)
135135
{
136-
PostOnSaccadeVertically();
136+
OnSaccadeY.Invoke();
137137
}
138138

139139
PostOnSaccade();
@@ -145,7 +145,5 @@ private bool IsSaccading(Ray rayOld, Ray rayNew)
145145
}
146146

147147
private void PostOnSaccade() => OnSaccade?.Invoke();
148-
private void PostOnSaccadeHorizontally() => OnSaccadeX?.Invoke();
149-
private void PostOnSaccadeVertically() => OnSaccadeY?.Invoke();
150148
}
151149
}

0 commit comments

Comments
 (0)