Don't keep reallocating the states list

keveleigh · keveleigh · commit ffd3049380d9 · 2020-01-23T15:55:45.000-08:00
diff --git a/Assets/MixedRealityToolkit.Providers/WindowsMixedReality/XRSDK/Controllers/WindowsMixedRealityXRSDKArticulatedHand.cs b/Assets/MixedRealityToolkit.Providers/WindowsMixedReality/XRSDK/Controllers/WindowsMixedRealityXRSDKArticulatedHand.cs
@@ -52,6 +52,7 @@ public WindowsMixedRealityXRSDKArticulatedHand(TrackingState trackingState, Hand
         private int[] handMeshTriangleIndices = null;
         private bool hasRequestedHandMeshObserver = false;
         private Vector2[] handMeshUVs;
+        private readonly List<object> states = new List<object>();
 
         protected void InitializeUVs(Vector3[] neutralPoseVertices)
         {
@@ -179,7 +180,6 @@ private void UpdateHandData(InputDevice inputDevice)
                 return;
             }
 
-            List<object> states = new List<object>();
 #if WMR_ENABLED
             XRSDKSubsystemHelpers.InputSubsystem?.GetCurrentSourceStates(states);
 #endif // WMR_ENABLED

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ public WindowsMixedRealityXRSDKArticulatedHand(TrackingState trackingState, Hand`
`52`	`52`	`private int[] handMeshTriangleIndices = null;`
`53`	`53`	`private bool hasRequestedHandMeshObserver = false;`
`54`	`54`	`private Vector2[] handMeshUVs;`
	`55`	`+ private readonly List<object> states = new List<object>();`
`55`	`56`
`56`	`57`	`protected void InitializeUVs(Vector3[] neutralPoseVertices)`
`57`	`58`	`{`
`@@ -179,7 +180,6 @@ private void UpdateHandData(InputDevice inputDevice)`
`179`	`180`	`return;`
`180`	`181`	`}`
`181`	`182`
`182`		`- List<object> states = new List<object>();`
`183`	`183`	`#if WMR_ENABLED`
`184`	`184`	`XRSDKSubsystemHelpers.InputSubsystem?.GetCurrentSourceStates(states);`
`185`	`185`	`#endif // WMR_ENABLED`