Merge branch 'hotfix' into UT-10888-backend

Author: UtkarshMishra-Microsoft

src/backend/tests/agents/test_product.py

@@ -2,7 +2,6 @@
 import sys
 from unittest.mock import MagicMock
 
-# --- Fake missing Azure modules ---
 sys.modules["azure.monitor.events"] = MagicMock()
 sys.modules["azure.monitor.events.extension"] = MagicMock()
 
@@ -15,6 +14,12 @@
 sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "../../../")))
 
 # Set required environment variables before importing modules that depend on them.
+import pytest
+
+# Mock Azure SDK dependencies
+sys.modules["azure.monitor.events.extension"] = MagicMock()
+
+# Set up environment variables
 os.environ["COSMOSDB_ENDPOINT"] = "https://mock-endpoint"
 os.environ["COSMOSDB_KEY"] = "mock-key"
 os.environ["COSMOSDB_DATABASE"] = "mock-database"
@@ -23,13 +28,12 @@
 os.environ["AZURE_OPENAI_API_VERSION"] = "2023-01-01"
 os.environ["AZURE_OPENAI_ENDPOINT"] = "https://mock-openai-endpoint"
 
-# Import product functions and classes.
+
+# Import the required functions for testing
 from src.backend.agents.product import (
     add_mobile_extras_pack,
     get_product_info,
-    get_billing_date,
     update_inventory,
-    add_new_product,
     schedule_product_launch,
     analyze_sales_data,
     get_customer_feedback,
@@ -87,13 +91,16 @@
 from src.backend.context.cosmos_memory import CosmosBufferedChatCompletionContext
 from src.backend.agents.base_agent import BaseAgent
 
-# --- Tests for Product Functions ---
+)
+
 
+# Parameterized tests for repetitive cases
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "function, args, expected_substrings",
     [
         (add_mobile_extras_pack, ("Roaming Pack", "2025-01-01"), ["Roaming Pack", "2025-01-01", "AGENT SUMMARY:"]),
+        (add_mobile_extras_pack, ("Roaming Pack", "2025-01-01"), ["Roaming Pack", "2025-01-01"]),
         (get_product_info, (), ["Simulated Phone Plans", "Plan A"]),
         (update_inventory, ("Product A", 50), ["Inventory for", "Product A"]),
         (schedule_product_launch, ("New Product", "2025-02-01"), ["New Product", "2025-02-01"]),
@@ -106,6 +113,12 @@
         (handle_product_recall, ("Product A", "Defective batch"), ["Product recall for", "Defective batch"]),
         (set_product_discount, ("Product A", 15.0), ["Discount for", "15.0%"]),
         (manage_supply_chain, ("Product A", "Supplier X"), ["Supply chain for", "Supplier X"]),
+        (handle_product_recall, ("Product A", "Defective batch"), ["Product recall for", "Defective batch"]),
+        (set_product_discount, ("Product A", 15.0), ["Discount for", "15.0%"]),
+        (manage_supply_chain, ("Product A", "Supplier X"), ["Supply chain for", "Supplier X"]),
+        (check_inventory, ("Product A",), ["Inventory status for", "Product A"]),
+        (update_product_price, ("Product A", 99.99), ["Price for", "$99.99"]),
+        (provide_product_recommendations, ("High Performance",), ["Product recommendations", "High Performance"]),
         (forecast_product_demand, ("Product A", "Next Month"), ["Demand for", "Next Month"]),
         (handle_product_complaints, ("Product A", "Complaint about quality"), ["Complaint for", "Product A"]),
         (generate_product_report, ("Product A", "Sales"), ["Sales report for", "Product A"]),
@@ -172,3 +185,9 @@ def test_get_product_tools():
     assert any(isinstance(tool, FunctionTool) for tool in tools)
     names = [tool.name for tool in tools]
     assert "add_mobile_extras_pack" in names or "get_product_info" in names
+
+# Specific test for monitoring market trends
+@pytest.mark.asyncio
+async def test_monitor_market_trends():
+    result = await monitor_market_trends()
+    assert "Market trends monitored" in result

src/backend/tests/context/test_cosmos_memory.py

@@ -29,7 +29,6 @@
     LLMMessage,
 )
 
-# --- DummyModel for Testing ---
 class DummyModel(BaseDataModel):
     id: str
     session_id: str
@@ -413,3 +412,72 @@ async def test_close(cosmos_context):
 async def test_context_manager(cosmos_context):
     async with cosmos_context as ctx:
         assert ctx == cosmos_context
+=======
+import pytest
+from unittest.mock import AsyncMock, patch
+from azure.cosmos.partition_key import PartitionKey
+from src.backend.context.cosmos_memory import CosmosBufferedChatCompletionContext
+
+
+# Helper to create async iterable
+async def async_iterable(mock_items):
+    """Helper to create an async iterable."""
+    for item in mock_items:
+        yield item
+
+
+@pytest.fixture
+def mock_env_variables(monkeypatch):
+    """Mock all required environment variables."""
+    env_vars = {
+        "COSMOSDB_ENDPOINT": "https://mock-endpoint",
+        "COSMOSDB_KEY": "mock-key",
+        "COSMOSDB_DATABASE": "mock-database",
+        "COSMOSDB_CONTAINER": "mock-container",
+        "AZURE_OPENAI_DEPLOYMENT_NAME": "mock-deployment-name",
+        "AZURE_OPENAI_API_VERSION": "2023-01-01",
+        "AZURE_OPENAI_ENDPOINT": "https://mock-openai-endpoint",
+    }
+    for key, value in env_vars.items():
+        monkeypatch.setenv(key, value)
+
+
+@pytest.fixture
+def mock_cosmos_client():
+    """Fixture for mocking Cosmos DB client and container."""
+    mock_client = AsyncMock()
+    mock_container = AsyncMock()
+    mock_client.create_container_if_not_exists.return_value = mock_container
+
+    # Mocking context methods
+    mock_context = AsyncMock()
+    mock_context.store_message = AsyncMock()
+    mock_context.retrieve_messages = AsyncMock(
+        return_value=async_iterable([{"id": "test_id", "content": "test_content"}])
+    )
+
+    return mock_client, mock_container, mock_context
+
+
+@pytest.fixture
+def mock_config(mock_cosmos_client):
+    """Fixture to patch Config with mock Cosmos DB client."""
+    mock_client, _, _ = mock_cosmos_client
+    with patch(
+        "src.backend.config.Config.GetCosmosDatabaseClient", return_value=mock_client
+    ), patch("src.backend.config.Config.COSMOSDB_CONTAINER", "mock-container"):
+        yield
+
+
+@pytest.mark.asyncio
+async def test_initialize(mock_config, mock_cosmos_client):
+    """Test if the Cosmos DB container is initialized correctly."""
+    mock_client, mock_container, _ = mock_cosmos_client
+    context = CosmosBufferedChatCompletionContext(
+        session_id="test_session", user_id="test_user"
+    )
+    await context.initialize()
+    mock_client.create_container_if_not_exists.assert_called_once_with(
+        id="mock-container", partition_key=PartitionKey(path="/session_id")
+    )
+    assert context._container == mock_container

src/backend/tests/test_app.py

@@ -7,11 +7,18 @@
 
 # --- MOCK EXTERNAL DEPENDENCIES ---
 # Prevent import errors for Azure modules.
+from unittest.mock import MagicMock, patch
+import pytest
+from fastapi.testclient import TestClient
+
+# Mock Azure dependencies to prevent import errors
 sys.modules["azure.monitor"] = MagicMock()
 sys.modules["azure.monitor.events.extension"] = MagicMock()
 sys.modules["azure.monitor.opentelemetry"] = MagicMock()
 
+
 # Set required environment variables
+# Mock environment variables before importing app
 os.environ["COSMOSDB_ENDPOINT"] = "https://mock-endpoint"
 os.environ["COSMOSDB_KEY"] = "mock-key"
 os.environ["COSMOSDB_DATABASE"] = "mock-database"
@@ -29,7 +36,6 @@
 
 client = TestClient(app)
 
-# --- FAKE CLASSES AND FUNCTIONS ---
 class FakePlan:
     id = "fake_plan_id"
     summary = "Fake plan summary"
@@ -114,14 +120,28 @@ async def get_all_messages(self):
             "ts": 123456789,
         }]
 
-# --- PYTEST FIXTURE TO OVERRIDE DEPENDENCIES ---
+
 @pytest.fixture(autouse=True)
 def override_dependencies(monkeypatch):
     # Override authentication so that the headers always yield a valid user.
+
+# Mock telemetry initialization to prevent errors
+with patch("azure.monitor.opentelemetry.configure_azure_monitor", MagicMock()):
+    from src.backend.app import app
+
+# Initialize FastAPI test client
+client = TestClient(app)
+
+
+@pytest.fixture(autouse=True)
+def mock_dependencies(monkeypatch):
+    """Mock dependencies to simplify tests."""
+
     monkeypatch.setattr(
         "src.backend.auth.auth_utils.get_authenticated_user_details",
         lambda headers: {"user_principal_id": "mock-user-id"},
     )
+
     # Override the agent tools retrieval to return a tool with the expected values.
     monkeypatch.setattr(
         "src.backend.utils.retrieve_all_agent_tools",
@@ -135,25 +155,37 @@ def override_dependencies(monkeypatch):
     monkeypatch.setattr("src.backend.app.initialize_runtime_and_context", fake_initialize_runtime_and_context)
     monkeypatch.setattr("src.backend.app.CosmosBufferedChatCompletionContext", FakeCosmos)
     monkeypatch.setattr("src.backend.app.track_event_if_configured", lambda event, props: None)
-
-# --- TEST CASES ---
-# Note: We remove extra fields (like "user_id") from payloads so that they match the expected schema.
+    
 
 def test_input_task_invalid_json():
     invalid_json = "Invalid JSON data"
     headers = {"Authorization": "Bearer mock-token"}
     response = client.post("/input_task", data=invalid_json, headers=headers)
     assert response.status_code == 422
     assert "detail" in response.json()
+    
 
 def test_input_task_missing_description():
     payload = {"session_id": ""}
     headers = {"Authorization": "Bearer mock-token"}
     response = client.post("/input_task", json=payload, headers=headers)
+    monkeypatch.setattr(
+        "src.backend.utils.retrieve_all_agent_tools",
+        lambda: [{"agent": "test_agent", "function": "test_function"}],
+    )
+
+
+def test_input_task_invalid_json():
+    """Test the case where the input JSON is invalid."""
+    invalid_json = "Invalid JSON data"
+
+    headers = {"Authorization": "Bearer mock-token"}
+    response = client.post("/input_task", data=invalid_json, headers=headers)
+
     assert response.status_code == 422
     assert "detail" in response.json()
 
-
+    
 def test_human_feedback_valid():
     payload = {
         "step_id": "step1",
@@ -301,7 +333,37 @@ def test_get_plans_not_found():
     headers = {"Authorization": "Bearer mock-token"}
     response = client.get("/plans", params={"session_id": "nonexistent"}, headers=headers)
     assert response.status_code == 404
-    assert response.json()["detail"] == "Plan not found"
+
+    
+def test_input_task_missing_description():
+    """Test the case where the input task description is missing."""
+    input_task = {
+        "session_id": None,
+        "user_id": "mock-user-id",
+    }
+
+    headers = {"Authorization": "Bearer mock-token"}
+    response = client.post("/input_task", json=input_task, headers=headers)
+
+    # Assert response for missing description
+    assert response.status_code == 422
+    assert "detail" in response.json()
+
+
+def test_basic_endpoint():
+    """Test a basic endpoint to ensure the app runs."""
+    response = client.get("/")
+    assert response.status_code == 404  # The root endpoint is not defined
+
+
+def test_input_task_empty_description():
+    """Tests if /input_task handles an empty description."""
+    empty_task = {"session_id": None, "user_id": "mock-user-id", "description": ""}
+    headers = {"Authorization": "Bearer mock-token"}
+    response = client.post("/input_task", json=empty_task, headers=headers)
+
+    assert response.status_code == 422
+    assert "detail" in response.json()  # Assert error message for missing description
 
 
 if __name__ == "__main__":