Skip to content

Commit 2497292

Browse files
authored
Merge pull request #164 from Fr4nc3/main
fix: conflict from main repo main branch
2 parents eadf67b + 55deb6d commit 2497292

File tree

4 files changed

+66
-36
lines changed

4 files changed

+66
-36
lines changed

.github/workflows/azure-dev.yml

Lines changed: 47 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
- dev
66
- main
77
- feature/azd-semantickernel
8-
workflow_dispatch:
8+
workflow_dispatch:
99

1010
permissions:
1111
contents: read
@@ -16,13 +16,36 @@ jobs:
1616
template_validation_job:
1717
runs-on: ubuntu-latest
1818
name: Template validation
19-
2019
steps:
2120
# Step 1: Checkout the code from your repository
2221
- name: Checkout code
2322
uses: actions/checkout@v4
2423

25-
# Step 2: Validate the Azure template using microsoft/template-validation-action
24+
# Step 2: Set up Python
25+
- name: Set up Python
26+
uses: actions/setup-python@v4
27+
with:
28+
python-version: "3.9"
29+
30+
# Step 3: Create and populate the virtual environment
31+
- name: Create virtual environment and install dependencies
32+
run: |
33+
python -m venv .venv
34+
source .venv/bin/activate
35+
python -m pip install --upgrade pip
36+
pip install azure-mgmt-resource azure-identity azure-core azure-mgmt-subscription azure-cli-core
37+
# Install any other dependencies that might be needed
38+
pip freeze > requirements-installed.txt
39+
echo "Virtual environment created with these packages:"
40+
cat requirements-installed.txt
41+
42+
# Step 4: Create azd directory if it doesn't exist
43+
- name: Create azd directory
44+
run: |
45+
mkdir -p ./.azd || true
46+
touch ./.azd/.env || true
47+
48+
# Step 5: Validate the Azure template
2649
- name: Validate Azure Template
2750
uses: microsoft/[email protected]
2851
id: validation
@@ -34,7 +57,27 @@ jobs:
3457
AZURE_LOCATION: ${{ secrets.AZURE_LOCATION }}
3558
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3659

60+
# Step 6: Debug output in case of failure
61+
- name: Debug on failure
62+
if: failure()
63+
run: |
64+
echo "Validation failed. Checking environment:"
65+
ls -la
66+
if [ -d ".venv" ]; then
67+
echo ".venv directory exists"
68+
ls -la .venv/bin/
69+
else
70+
echo ".venv directory does not exist"
71+
fi
72+
if [ -d "tva_*" ]; then
73+
echo "TVA directory exists:"
74+
find . -name "tva_*" -type d
75+
ls -la $(find . -name "tva_*" -type d)
76+
else
77+
echo "No TVA directory found"
78+
fi
3779
38-
# Step 3: Print the result of the validation
80+
# Step 7: Print the result of the validation
3981
- name: Print result
82+
if: success()
4083
run: cat ${{ steps.validation.outputs.resultFile }}

azure.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
# yaml-language-server: $schema=https://raw.githubusercontent.com/Azure/azure-dev/main/schemas/v1.0/azure.yaml.json
2-
name: multi-agent-custom-automation-engine-solution-accelerator
2+
name: multi-agent-custom-automation-engine-solution-accelerator
3+

documentation/ManualAzureDeployment.md

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,26 @@
11
# Manual Azure Deployment
2-
Manual Deployment differs from the ‘Quick Deploy’ option in that it will install an Azure Container Registry (ACR) service, and relies on the installer to build and push the necessary containers to this ACR. This allows you to build and push your own code changes and provides a sample solution you can customize based on your requirements.
2+
3+
Manual Deployment differs from the ‘Quick Deploy’ option in that it will install an Azure Container Registry (ACR) service, and relies on the installer to build and push the necessary containers to this ACR. This allows you to build and push your own code changes and provides a sample solution you can customize based on your requirements.
34

45
## Prerequisites
56

67
- Current Azure CLI installed
7-
You can update to the latest version using ```az upgrade```
8+
You can update to the latest version using `az upgrade`
89
- Azure account with appropriate permissions
910
- Docker installed
1011

1112
## Deploy the Azure Services
12-
All of the necessary Azure services can be deployed using the /deploy/macae.bicep script. This script will require the following parameters:
13+
14+
All of the necessary Azure services can be deployed using the /deploy/macae.bicep script. This script will require the following parameters:
1315

1416
```
1517
az login
1618
az account set --subscription <SUBSCRIPTION_ID>
1719
az group create --name <RG_NAME> --location <RG_LOCATION>
1820
```
21+
1922
To deploy the script you can use the Azure CLI.
23+
2024
```
2125
az deployment group create \
2226
--resource-group <RG_NAME> \
@@ -26,9 +30,10 @@ az deployment group create \
2630

2731
Note: if you are using windows with PowerShell, the continuation character (currently ‘\’) should change to the tick mark (‘`’).
2832

29-
The template will require you fill in locations for Cosmos and OpenAI services. This is to avoid the possibility of regional quota errors for either of these resources.
33+
The template will require you fill in locations for Cosmos and OpenAI services. This is to avoid the possibility of regional quota errors for either of these resources.
3034

3135
## Create the Containers
36+
3237
- Get admin credentials from ACR
3338

3439
Retrieve the admin credentials for your Azure Container Registry (ACR):
@@ -49,7 +54,7 @@ az acr login --name <e.g. macaeacr2t62qyozi76bs>
4954

5055
## Build and push the image
5156

52-
Build the frontend and backend Docker images and push them to your Azure Container Registry. Run the following from the src/backend and the src/frontend directory contexts:
57+
Build the frontend and backend Docker images and push them to your Azure Container Registry. Run the following from the src/backend and the src/frontend directory contexts:
5358

5459
```sh
5560
az acr build \
@@ -60,12 +65,13 @@ az acr build \
6065

6166
## Add images to the Container APP and Web App services
6267

63-
To add your newly created backend image:
68+
To add your newly created backend image:
69+
6470
- Navigate to the Container App Service in the Azure portal
6571
- Click on Application/Containers in the left pane
6672
- Click on the "Edit and deploy" button in the upper left of the containers pane
67-
- In the "Create and deploy new revision" page, click on your container image 'backend'. This will give you the option of reconfiguring the container image, and also has an Environment variables tab
68-
- Change the properties page to
73+
- In the "Create and deploy new revision" page, click on your container image 'backend'. This will give you the option of reconfiguring the container image, and also has an Environment variables tab
74+
- Change the properties page to
6975
- point to your Azure Container registry with a private image type and your image name (e.g. backendmacae:latest)
7076
- under "Authentication type" select "Managed Identity" and choose the 'mace-containerapp-pull'... identity setup in the bicep template
7177
- In the environment variables section add the following (each with a 'Manual entry' source):
@@ -75,8 +81,8 @@ To add your newly created backend image:
7581

7682
name: 'COSMOSDB_DATABASE'
7783
value: 'macae'
78-
Note: To change the default, you will need to create the database in Cosmos
79-
84+
Note: To change the default, you will need to create the database in Cosmos
85+
8086
name: 'COSMOSDB_CONTAINER'
8187
value: 'memory'
8288

@@ -88,7 +94,7 @@ To add your newly created backend image:
8894

8995
name: 'AZURE_OPENAI_API_VERSION'
9096
value: '2024-08-01-preview'
91-
Note: Version should be updated based on latest available
97+
Note: Version should be updated based on latest available
9298

9399
name: 'FRONTEND_SITE_NAME'
94100
value: 'https://<website Name>.azurewebsites.net'
@@ -106,4 +112,3 @@ az webapp config container set --resource-group <resource_group_name> \
106112
--container-image-name <e.g. macaeacr2t62qyozi76bs.azurecr.io/frontendmacae:latest> \
107113
--container-registry-url <e.g. https://macaeacr2t62qyozi76bs.azurecr.io>
108114
```
109-

src/backend/.env.old

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)