Merge pull request #146 from microsoft/psl-tools-fixed

fix: initialization logic across multiple agent classes and renames various kernel tool methods

Author: Fr4nc3

src/backend/kernel_agents/generic_agent.py

@@ -41,7 +41,7 @@ def __init__(
             definition: Optional definition instance
         """
         # Load configuration if tools not provided
-        if tools is None:
+        if not tools:
             # Get tools directly from GenericTools class
             tools_dict = GenericTools.get_all_kernel_functions()
             logging.info(

src/backend/kernel_agents/hr_agent.py

@@ -44,7 +44,7 @@ def __init__(
             definition: Optional definition instance
         """
         # Load configuration if tools not provided
-        if tools is None:
+        if not tools:
             # Get tools directly from HrTools class
             tools_dict = HrTools.get_all_kernel_functions()
             tools = [KernelFunction.from_method(func) for func in tools_dict.values()]

src/backend/kernel_agents/human_agent.py

@@ -55,7 +55,7 @@ def __init__(
             definition: Optional definition instance
         """
         # Load configuration if tools not provided
-        if tools is None:
+        if not tools:
             # Get tools directly from HumanTools class
             tools_dict = HumanTools.get_all_kernel_functions()
             tools = [KernelFunction.from_method(func) for func in tools_dict.values()]

src/backend/kernel_agents/marketing_agent.py

@@ -43,7 +43,7 @@ def __init__(
             definition: Optional definition instance
         """
         # Load configuration if tools not provided
-        if tools is None:
+        if not tools:
             # Get tools directly from MarketingTools class
             tools_dict = MarketingTools.get_all_kernel_functions()
             tools = [KernelFunction.from_method(func) for func in tools_dict.values()]

src/backend/kernel_agents/procurement_agent.py

@@ -43,7 +43,7 @@ def __init__(
             definition: Optional definition instance
         """
         # Load configuration if tools not provided
-        if tools is None:
+        if not tools:
             # Get tools directly from ProcurementTools class
             tools_dict = ProcurementTools.get_all_kernel_functions()
             tools = [KernelFunction.from_method(func) for func in tools_dict.values()]

src/backend/kernel_agents/product_agent.py

@@ -46,7 +46,7 @@ def __init__(
             definition: Optional definition instance
         """
         # Load configuration if tools not provided
-        if tools is None:
+        if not tools:
             # Get tools directly from ProductTools class
             tools_dict = ProductTools.get_all_kernel_functions()
             tools = [KernelFunction.from_method(func) for func in tools_dict.values()]

src/backend/kernel_agents/tech_support_agent.py

@@ -43,7 +43,7 @@ def __init__(
             definition: Optional definition instance
         """
         # Load configuration if tools not provided
-        if tools is None:
+        if not tools:
             # Get tools directly from TechSupportTools class
             tools_dict = TechSupportTools.get_all_kernel_functions()
             tools = [KernelFunction.from_method(func) for func in tools_dict.values()]

src/backend/kernel_tools/hr_tools.py

@@ -271,7 +271,7 @@ async def track_employee_attendance(employee_name: str) -> str:
 
     @staticmethod
     @kernel_function(description="Organize a health and wellness program.")
-    async def organize_health_and_wellness_program(program_name: str, date: str) -> str:
+    async def organize_wellness_program(program_name: str, date: str) -> str:
         return (
             f"##### Health and Wellness Program Organized\n"
             f"**Program Name:** {program_name}\n"

src/backend/kernel_tools/marketing_tools.py

@@ -23,7 +23,7 @@ async def analyze_market_trends(industry: str) -> str:
 
     @staticmethod
     @kernel_function(description="Generate social media posts for a campaign.")
-    async def generate_social_media_posts(campaign_name: str, platforms: list) -> str:
+    async def generate_social_posts(campaign_name: str, platforms: list) -> str:
         platforms_str = ", ".join(platforms)
         return f"Social media posts for campaign '{campaign_name}' generated for platforms: {platforms_str}."
 
@@ -44,12 +44,6 @@ async def conduct_customer_survey(survey_topic: str, target_group: str) -> str:
     async def perform_competitor_analysis(competitor_name: str) -> str:
         return f"Competitor analysis performed on '{competitor_name}'."
 
-    @staticmethod
-    @kernel_function(description="Optimize SEO strategy using specified keywords.")
-    async def optimize_seo_strategy(keywords: list) -> str:
-        keywords_str = ", ".join(keywords)
-        return f"SEO strategy optimized with keywords: {keywords_str}."
-
     @staticmethod
     @kernel_function(description="Schedule a marketing event.")
     async def schedule_marketing_event(
@@ -211,7 +205,7 @@ async def organize_trade_show(booth_number: str, event_name: str) -> str:
 
     @staticmethod
     @kernel_function(description="Manage a customer retention program.")
-    async def manage_customer_retention_program(program_name: str) -> str:
+    async def manage_retention_program(program_name: str) -> str:
         return f"Customer retention program '{program_name}' managed."
 
     @staticmethod
@@ -261,7 +255,7 @@ async def optimize_conversion_funnel(stage: str) -> str:
 
     @staticmethod
     @kernel_function(description="Run an influencer marketing campaign.")
-    async def run_influencer_marketing_campaign(
+    async def run_influencer_campaign(
         campaign_name: str, influencers: list
     ) -> str:
         influencers_str = ", ".join(influencers)
@@ -280,15 +274,15 @@ async def develop_customer_personas(segment_name: str) -> str:
     # This function does NOT have the kernel_function annotation
     # because it's meant for introspection rather than being exposed as a tool
     @staticmethod
-    def get_all_kernel_functions() -> List[Callable]:
+    def get_all_kernel_functions() -> dict[str, Callable]:
         """
         Returns a dictionary of all methods in this class that have the @kernel_function annotation.
         This function itself is not annotated with @kernel_function.
 
         Returns:
             Dict[str, Callable]: Dictionary with function names as keys and function objects as values
         """
-        kernel_functions = []
+        kernel_functions = {}
 
         # Get all class methods
         for name, method in inspect.getmembers(
@@ -304,6 +298,6 @@ def get_all_kernel_functions() -> List[Callable]:
             if hasattr(method, "__kernel_function__") or "kernel_function" in str(
                 method_attrs
             ):
-                kernel_functions.append(method)
+                kernel_functions[name] = method
 
         return kernel_functions

src/backend/kernel_tools/procurement_tools.py

@@ -466,8 +466,8 @@ async def verify_delivery(item_name: str, delivery_status: str) -> str:
         )
 
     @staticmethod
-    @kernel_function(description="Handle procurement risk assessment.")
-    async def handle_procurement_risk_assessment(risk_details: str) -> str:
+    @kernel_function(description="assess procurement risk assessment.")
+    async def assess_procurement_risk(risk_details: str) -> str:
         return (
             f"##### Procurement Risk Assessment\n"
             f"**Details:** {risk_details}\n\n"